x-tools / xtools

src/AppBundle/Controller/ArticleInfoController.php

Unused Use Statements -4 removed lines

@@ -9,13 +9,9 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Process\Process;
 use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
-use Xtools\ProjectRepository;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\ArticleInfo;
 
 /**

Spacing +7 added lines, -7 removed lines

@@ -84,10 +84,10 @@ 
             $rendered = str_replace('"', '\"', trim($rendered));
 
             // Uglify temporary file.
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
-            $script .= $this->get('kernel')->getRootDir() .
-                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
+            $script .= $this->get('kernel')->getRootDir().
+                "/Resources/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
                 "&& rm $tmpFile >/dev/null";
             $process = new Process($script);
             $process->run();
@@ -106,10 +106,10 @@ 
             $rendered = str_replace('\"', '"', trim($rendered));
 
             // Add comment after uglifying since it removes comments.
-            $rendered = "/**\n * This code was automatically generated and should not " .
-                "be manually edited.\n * For updates, please copy and paste from " .
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
+            $rendered = "/**\n * This code was automatically generated and should not ".
+                "be manually edited.\n * For updates, please copy and paste from ".
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
         }
 
         $response = new \Symfony\Component\HttpFoundation\Response($rendered);

src/AppBundle/Controller/SimpleEditCounterController.php

Unused Use Statements -2 removed lines

@@ -12,8 +12,6 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\Project;
-use Xtools\ProjectRepository;
-use Xtools\User;
 
 /**
  * This controller handles the Simple Edit Counter tool.

Spacing +4 added lines, -4 removed lines

@@ -132,16 +132,16 @@ 
                 $rev = $row['value'];
             }
             if ($row['source'] == 'groups') {
-                $groups .= $row['value']. ', ';
+                $groups .= $row['value'].', ';
             }
         }
 
         // Unknown user - If the user is created the $results variable will have 3 entries.
         // This is a workaround to detect non-existent IPs.
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
-            $this->addFlash('notice', [ 'no-result', $username]);
+            $this->addFlash('notice', ['no-result', $username]);
 
-            return $this->redirectToRoute('SimpleEditCounterProject', [ 'project' => $project->getDomain() ]);
+            return $this->redirectToRoute('SimpleEditCounterProject', ['project' => $project->getDomain()]);
         }
 
         // Remove the last comma and space
@@ -170,7 +170,7 @@ 
             'project' => $project,
             'id' => $id,
             'arch' => $arch,
-            'rev' => $rev + $arch,
+            'rev' => $rev+$arch,
             'live' => $rev,
             'groups' => $groups,
             'globalGroups' => $globalGroups,

src/AppBundle/Controller/MetaController.php

Spacing +6 added lines, -6 removed lines

@@ -74,7 +74,7 @@ 
         $timeline = [];
         $startObj = new DateTime($start);
         $endObj = new DateTime($end);
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
         $grandSum = 0;
 
         // Generate array of date labels
@@ -84,17 +84,17 @@ 
 
         foreach ($data as $entry) {
             if (!isset($totals[$entry['tool']])) {
-                $totals[$entry['tool']] = (int) $entry['count'];
+                $totals[$entry['tool']] = (int)$entry['count'];
 
                 // Create arrays for each tool, filled with zeros for each date in the timeline
                 $timeline[$entry['tool']] = array_fill(0, $numDays, 0);
             } else {
-                $totals[$entry['tool']] += (int) $entry['count'];
+                $totals[$entry['tool']] += (int)$entry['count'];
             }
 
             $date = new DateTime($entry['date']);
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
-            $timeline[$entry['tool']][$dateIndex] = (int) $entry['count'];
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
+            $timeline[$entry['tool']][$dateIndex] = (int)$entry['count'];
 
             $grandSum += $entry['count'];
         }
@@ -145,7 +145,7 @@ 
         }
 
         $conn = $this->container->get('doctrine')->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/AppBundle/Controller/XtoolsController.php

Spacing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $params = $this->convertLegacyParams($params);
 
         // Remove blank values.
-        return array_filter($params, function ($param) {
+        return array_filter($params, function($param) {
             // 'namespace' or 'username' could be '0'.
             return $param !== null && $param !== '';
         });

Doc Comments +1 added lines, -1 removed lines

@@ -248,7 +248,7 @@
      * @param  bool   $useDefaults Whether to use defaults if the values
      *   are blank. The start date is set to one month before the end date,
      *   and the end date is set to the present.
-     * @return mixed[] Start and end date as UTC timestamps or 'false' if empty.
+     * @return integer[] Start and end date as UTC timestamps or 'false' if empty.
      */
     public function getUTCFromDateParams($start, $end, $useDefaults = true)
     {

src/AppBundle/Controller/AdminStatsController.php

Unused Use Statements -1 removed lines

@@ -16,7 +16,6 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Xtools\AdminStats;
 use Xtools\AdminStatsRepository;
-use Xtools\ProjectRepository;
 
 /**
  * Class AdminStatsController

Spacing +1 added lines, -1 removed lines

@@ -171,7 +171,7 @@
     public function adminStatsApiAction($project, $days = 30)
     {
         // Maximum 30 days.
-        $days = min((int) $days, 30);
+        $days = min((int)$days, 30);
         $start = date('Y-m-d', strtotime("-$days days"));
         $end = date('Y-m-d');
 

src/Xtools/AdminStats.php

Unused Use Statements -3 removed lines

@@ -5,9 +5,6 @@
 
 namespace Xtools;
 
-use Symfony\Component\DependencyInjection\Container;
-use DateTime;
-
 /**
  * AdminStats returns information about users with administrative
  * rights on a given wiki.

Spacing +2 added lines, -2 removed lines

@@ -117,7 +117,7 @@ 
      */
     public function numDays()
     {
-        return ($this->end - $this->start) / 60 / 60 / 24;
+        return ($this->end-$this->start) / 60 / 60 / 24;
     }
 
     /**
@@ -280,7 +280,7 @@ 
      */
     public function getNumAdminsWithActions()
     {
-        return $this->numAdmins() - $this->adminsWithoutActions;
+        return $this->numAdmins()-$this->adminsWithoutActions;
     }
 
     /**

src/AppBundle/Helper/ApiHelper.php

Spacing +4 added lines, -4 removed lines

@@ -60,7 +60,7 @@ 
     public function groups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -88,7 +88,7 @@ 
     public function globalGroups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -130,7 +130,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -215,7 +215,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);

src/Xtools/AdminStatsRepository.php

Spacing +1 added lines, -1 removed lines

@@ -52,7 +52,7 @@
         $userGroupsTable = $project->getTableName('user_groups');
         $ufgTable = $project->getTableName('user_former_groups');
 
-        $adminGroups = join(array_map(function ($group) {
+        $adminGroups = join(array_map(function($group) {
             return "'$group'";
         }, $this->getAdminGroups($project)), ',');