x-tools / xtools

src/Xtools/PagesRepository.php

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
      * Get metadata about a single page from the API.
      * @param Project $project The project to which the page belongs.
      * @param string $pageTitle Page title.
-     * @return string[] Array with some of the following keys: pageid, title, missing, displaytitle,
+     * @return string|null Array with some of the following keys: pageid, title, missing, displaytitle,
      * url.
      */
     public function getPageInfo(Project $project, $pageTitle)
@@ -135,7 +135,7 @@ 
      * @param int $numRevisions Number of revisions, if known. This is used solely to determine the
      *   OFFSET if we are given a $limit (see below). If $limit is set and $numRevisions is not set,
      *   a separate query is ran to get the nuber of revisions.
-     * @return Doctrine\DBAL\Driver\PDOStatement
+     * @return \Doctrine\DBAL\Driver\Statement
      */
     public function getRevisionsStmt(Page $page, User $user = null, $limit = null, $numRevisions = null)
     {

Spacing +5 added lines, -5 removed lines

@@ -148,7 +148,7 @@ 
         // supply as the OFFSET.
         $limitClause = '';
         if (intval($limit) > 0 && isset($numRevisions)) {
-            $offset = $numRevisions - $limit;
+            $offset = $numRevisions-$limit;
             $limitClause = "LIMIT $offset, $limit";
         }
 
@@ -378,7 +378,7 @@ 
 
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
 
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
                 FROM wikidatawiki_p.wb_items_per_site
                 WHERE ips_item_id = :wikidataId";
 
@@ -388,7 +388,7 @@ 
 
         $result = $resultQuery->fetchAll();
 
-        return $count ? (int) $result[0]['count'] : $result;
+        return $count ? (int)$result[0]['count'] : $result;
     }
 
     /**
@@ -428,7 +428,7 @@ 
 
         // Transform to associative array by 'type'
         foreach ($res as $row) {
-            $data[$row['type'] . '_count'] = $row['value'];
+            $data[$row['type'].'_count'] = $row['value'];
         }
 
         return $data;
@@ -466,7 +466,7 @@ 
 
         $project = $page->getProject()->getDomain();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
             "$project/all-access/user/$title/daily/$start/$end";
 
         $res = $client->request('GET', $url);

src/AppBundle/Controller/EditCounterController.php

Spacing +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
 
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

Unused Use Statements -3 removed lines

@@ -14,11 +14,8 @@
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Xtools\EditCounter;
 use Xtools\EditCounterRepository;
-use Xtools\Page;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
-use Xtools\UserRepository;
 
 /**
  * Class EditCounterController

src/AppBundle/Twig/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
         }
 
         // Find the path, and complain if English doesn't exist.
-        $path = $this->container->getParameter('kernel.root_dir') . '/../i18n';
+        $path = $this->container->getParameter('kernel.root_dir').'/../i18n';
         if (!file_exists("$path/en.json")) {
             throw new Exception("Language directory doesn't exist: $path");
         }

src/AppBundle/Twig/AppExtension.php

Spacing +39 added lines, -39 removed lines

@@ -44,32 +44,32 @@ 
     {
         $options = ['is_safe' => ['html']];
         return [
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
-            new \Twig_SimpleFunction('releaseDate', [ $this, 'gitDate' ]),
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
+            new \Twig_SimpleFunction('releaseDate', [$this, 'gitDate']),
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
+            new \Twig_SimpleFunction('link', [$this, 'link']),
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
             new \Twig_SimpleFunction('logged_in_user', [$this, 'functionLoggedInUser']),
             new \Twig_SimpleFunction('isUserAnon', [$this, 'isUserAnon']),
             new \Twig_SimpleFunction('nsName', [$this, 'nsName']),
@@ -85,7 +85,7 @@ 
     public function requestTime()
     {
         if (!isset($this->requestTime)) {
-            $this->requestTime = microtime(true) - $this->getCurrentRequest()->server->get('REQUEST_TIME_FLOAT');
+            $this->requestTime = microtime(true)-$this->getCurrentRequest()->server->get('REQUEST_TIME_FLOAT');
         }
 
         return $this->requestTime;
@@ -158,7 +158,7 @@ 
      */
     public function intuitionMessage($message = "", $vars = [])
     {
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
     }
 
     /**
@@ -187,10 +187,10 @@ 
      */
     public function getAllLangs()
     {
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
 
         $languages = array_values(array_unique(array_map(
-            function ($filename) {
+            function($filename) {
                 return basename($filename, '.json');
             },
             $messageFiles
@@ -537,9 +537,9 @@ 
     public function getFilters()
     {
         return [
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
             new \Twig_SimpleFilter('num_format', [$this, 'numberFormat']),
             new \Twig_SimpleFilter('date_format', [$this, 'dateFormat']),
         ];
@@ -613,10 +613,10 @@ 
         if (!$denominator) {
             $quotient = $numerator;
         } else {
-            $quotient = ( $numerator / $denominator ) * 100;
+            $quotient = ($numerator / $denominator) * 100;
         }
 
-        return $this->numberFormat($quotient, $precision) . '%';
+        return $this->numberFormat($quotient, $precision).'%';
     }
 
     /**
@@ -691,20 +691,20 @@ 
 
         if ($seconds >= 86400) {
             // Over a day
-            $val = (int) floor($seconds / 86400);
+            $val = (int)floor($seconds / 86400);
             $key = 'days';
         } elseif ($seconds >= 3600) {
             // Over an hour, less than a day
-            $val = (int) floor($seconds / 3600);
+            $val = (int)floor($seconds / 3600);
             $key = 'hours';
         } elseif ($seconds >= 60) {
             // Over a minute, less than an hour
-            $val = (int) floor($seconds / 60);
+            $val = (int)floor($seconds / 60);
             $key = 'minutes';
         }
 
         if ($translate) {
-            return $this->numberFormat($val) . ' ' . $this->intuitionMessage("num-$key", [$val]);
+            return $this->numberFormat($val).' '.$this->intuitionMessage("num-$key", [$val]);
         } else {
             return [$this->numberFormat($val), "num-$key"];
         }

src/Xtools/User.php

Spacing +11 added lines, -11 removed lines

@@ -92,7 +92,7 @@ 
             return $this->editCounts[$domain];
         }
 
-        $this->editCounts[$domain] = (int) $this->getRepository()->getEditCount(
+        $this->editCounts[$domain] = (int)$this->getRepository()->getEditCount(
             $project->getDatabaseName(),
             $this->getUsername()
         );
@@ -158,7 +158,7 @@ 
      */
     public function isAnon()
     {
-        return (bool) filter_var($this->username, FILTER_VALIDATE_IP);
+        return (bool)filter_var($this->username, FILTER_VALIDATE_IP);
     }
 
     /**
@@ -220,7 +220,7 @@ 
      */
     public function countEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -233,7 +233,7 @@ 
      */
     public function countAutomatedEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -265,12 +265,12 @@ 
 
         $namespaces = $project->getNamespaces();
 
-        return array_map(function ($rev) use ($namespaces) {
+        return array_map(function($rev) use ($namespaces) {
             $pageTitle = $rev['page_title'];
             $fullPageTitle = '';
 
             if ($rev['page_namespace'] !== '0') {
-                $fullPageTitle = $namespaces[$rev['page_namespace']] . ":$pageTitle";
+                $fullPageTitle = $namespaces[$rev['page_namespace']].":$pageTitle";
             } else {
                 $fullPageTitle = $pageTitle;
             }
@@ -278,12 +278,12 @@ 
             return [
                 'full_page_title' => $fullPageTitle,
                 'page_title' => $pageTitle,
-                'page_namespace' => (int) $rev['page_namespace'],
-                'rev_id' => (int) $rev['rev_id'],
+                'page_namespace' => (int)$rev['page_namespace'],
+                'rev_id' => (int)$rev['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $rev['timestamp']),
-                'minor' => (bool) $rev['minor'],
-                'length' => (int) $rev['length'],
-                'length_change' => (int) $rev['length_change'],
+                'minor' => (bool)$rev['minor'],
+                'length' => (int)$rev['length'],
+                'length_change' => (int)$rev['length_change'],
                 'comment' => $rev['comment'],
             ];
         }, $revs);

src/Xtools/TopEdits.php

Spacing +6 added lines, -6 removed lines

@@ -119,9 +119,9 @@ 
         $displayTitles = $this->getDisplayTitles($pages);
 
         foreach ($pages as $page) {
-            $nsId = (int) $page['page_namespace'];
-            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $page['page_title'];
+            $nsId = (int)$page['page_namespace'];
+            $nsTitle = $nsId > 0 ? $this->project->getNamespaces()[$page['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$page['page_title'];
             $page['displaytitle'] = $displayTitles[$pageTitle];
 
             // $page['page_title'] is retained without the namespace
@@ -148,11 +148,11 @@ 
         $namespaces = $this->project->getNamespaces();
 
         // First extract page titles including namespace.
-        $pageTitles = array_map(function ($page) use ($namespaces) {
+        $pageTitles = array_map(function($page) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $page['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']] . ':' : '';
-            return $nsTitle . $page['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$page['page_namespace']].':' : '';
+            return $nsTitle.$page['page_title'];
         }, $topPages);
 
         return $this->getRepository()->getDisplayTitles($this->project, $pageTitles);

Unused Use Statements -3 removed lines

@@ -5,9 +5,6 @@
 
 namespace Xtools;
 
-use Symfony\Component\DependencyInjection\Container;
-use DateTime;
-
 /**
  * TopEdits returns the top-edited pages by a user.
  */

src/AppBundle/Controller/DeleteCounterController.php

Unused Use Statements -1 removed lines

@@ -12,7 +12,6 @@
 use Symfony\Component\HttpFoundation\Response;
 use Xtools\Project;
 use Xtools\ProjectRepository;
-use Xtools\User;
 use Xtools\UserRepository;
 
 /**

Spacing +5 added lines, -5 removed lines

@@ -56,7 +56,7 @@ 
 
         // If we've got a project and user, redirect to results.
         if ($projectName != '' && $username != '') {
-            $routeParams = [ 'project' => $projectName, 'username' => $username ];
+            $routeParams = ['project' => $projectName, 'username' => $username];
             return $this->redirectToRoute(
                 'DeletionCounterResult',
                 $routeParams
@@ -127,7 +127,7 @@ 
         $types = $this->container->getParameter("deletion_counter");
 
         if (!isset($types[$domain])) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounter',
                 [
@@ -153,7 +153,7 @@ 
         $resultQuery->execute();
 
         if ($resultQuery->errorCode() > 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounterProject',
                 [
@@ -166,7 +166,7 @@ 
         $resultData = $resultQuery->fetchAll();
 
         if (count($resultData) == 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
             return $this->redirectToRoute(
                 'DeletionCounterProject',
                 [
@@ -185,7 +185,7 @@ 
         // Unknown user or generated no results
         // This is a workaround to detect non-existent IPs.
         if (count($results) == 0) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
+            $this->addFlash('notice', ['no-result', $username]);
 
             return $this->redirectToRoute(
                 'DeletionCounterProject',

src/Xtools/TopEditsRepository.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments() && $namespace === 0;
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM page_assessments
                     WHERE pa_page_id = page_id
@@ -92,7 +92,7 @@ 
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments();
         $pageAssessmentsTable = $this->getTableName($project->getDatabaseName(), 'page_assessments');
         $paSelect = $hasPageAssessments
-            ?  ", (
+            ? ", (
                     SELECT pa_class
                     FROM $pageAssessmentsTable
                     WHERE pa_page_id = e.page_id

src/AppBundle/Controller/TopEditsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -156,7 +156,7 @@
      * @param Request $request The HTTP request.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespace The namespace ID or 'all'
+     * @param integer $namespace The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      * @codeCoverageIgnore
      */

Unused Use Statements -4 removed lines

@@ -11,12 +11,8 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Xtools\Page;
-use Xtools\PagesRepository;
 use Xtools\Project;
-use Xtools\ProjectRepository;
 use Xtools\User;
-use Xtools\UserRepository;
 use Xtools\TopEdits;
 use Xtools\TopEditsRepository;
 use Xtools\Edit;

Spacing +1 added lines, -1 removed lines

@@ -191,7 +191,7 @@
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,