x-tools / xtools

web/app_dev.php

Spacing +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
 // Feel free to remove this, extend it, or make something more sophisticated.
 if (isset($_SERVER['HTTP_CLIENT_IP'])
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
 ) {
     header('HTTP/1.0 403 Forbidden');
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');

xtools_utilities/nonautomated_edits_parse.php

Spacing +4 added lines, -4 removed lines

@@ -15,11 +15,11 @@
 $data = json_decode($file, true);
 
 // Output the contents to the piped file
-print ( "parameters:
+print ("parameters:
   automated_tools:\r\n" );
 foreach ($data as $row) {
-    print "  - " . $row["name"] . ": '" . $row["regex"] . "'\r\n";
+    print "  - ".$row["name"].": '".$row["regex"]."'\r\n";
 }
-print ( "
+print ("
 
-  semi-automated edits source: $url" );
+  semi-automated edits source: $url");

src/AppBundle/Helper/PageviewsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -12,8 +12,8 @@ 
         $title = str_replace(' ', '_', $title);
         $client = new GuzzleHttp\Client();
 
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
 
         $res = $client->request('GET', $url);
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@ 
         $data = $this->getLastDays($project, $title, $days);
 
         // FIXME: needs to handle gotchas
-        return array_sum(array_map(function ($item) {
+        return array_sum(array_map(function($item) {
             return $item->views;
         }, $data->items));
     }

src/AppBundle/Twig/Extension.php

Spacing +1 added lines, -1 removed lines

@@ -45,7 +45,7 @@
         }
 
         // Find the path, and complain if English doesn't exist.
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
         if (!file_exists("$path/en.json")) {
             throw new Exception("Language directory doesn't exist: $path");
         }

src/AppBundle/Controller/AdminStatsController.php

Spacing +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
 
         // Iterate over query results, loading each user id into the array
         while ($row = $res->fetch()) {
-            $adminIdArr[] = $row["user_id"] ;
+            $adminIdArr[] = $row["user_id"];
         }
 
         // Set the query results to be useful in a sql statement.

src/AppBundle/Controller/QuoteController.php

Spacing +2 added lines, -2 removed lines

@@ -111,7 +111,7 @@ 
             'quote/all.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 'xtPage' => 'bash',
                 'quotes' => $quotes,
@@ -160,7 +160,7 @@ 
             'quote/view.html.twig',
             [
                 'base_dir' => realpath(
-                    $this->getParameter('kernel.root_dir') . '/..'
+                    $this->getParameter('kernel.root_dir').'/..'
                 ),
                 "xtPage" => "bash",
                 "text" => $text,

src/AppBundle/Helper/ApiHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
      * Get a list of namespaces on the given project.
      *
      * @param string    $project such as en.wikipedia.org
-     * @return string[] Array of namespace IDs (keys) to names (values).
+     * @return string Array of namespace IDs (keys) to names (values).
      */
     public function namespaces($project)
     {

Spacing +13 added lines, -13 removed lines

@@ -66,12 +66,12 @@ 
             throw new Exception("Unable to find project '$projectName'");
         }
 
-        $cacheKey = "siteinfo." . $project->getDatabaseName();
+        $cacheKey = "siteinfo.".$project->getDatabaseName();
         if ($this->cacheHas($cacheKey)) {
             return $this->cacheGet($cacheKey);
         }
 
-        $params = [ 'meta'=>'siteinfo', 'siprop'=>'general|namespaces' ];
+        $params = ['meta'=>'siteinfo', 'siprop'=>'general|namespaces'];
         $query = new SimpleRequest('query', $params);
 
         $result = [
@@ -135,7 +135,7 @@ 
     public function groups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -154,7 +154,7 @@ 
     public function globalGroups($project, $username)
     {
         $this->setUp($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
 
@@ -202,7 +202,7 @@ 
                 $groups[] = "B";
             }
             if (in_array("steward", $admin["groups"])) {
-                $groups[] = "S" ;
+                $groups[] = "S";
             }
             if (in_array("checkuser", $admin["groups"])) {
                 $groups[] = "CU";
@@ -213,7 +213,7 @@ 
             if (in_array("bot", $admin["groups"])) {
                 $groups[] = "Bot";
             }
-            $result[ $admin["name"] ] = [
+            $result[$admin["name"]] = [
                 "groups" => implode('/', $groups)
             ];
         }
@@ -288,7 +288,7 @@ 
             $normalized = [];
             if (isset($result['query']['normalized'])) {
                 array_map(
-                    function ($e) use (&$normalized) {
+                    function($e) use (&$normalized) {
                         $normalized[$e['to']] = $e['from'];
                     },
                     $result['query']['normalized']
@@ -334,7 +334,7 @@ 
         ];
 
         // get assessments for this page from the API
-        $assessments = $this->massApi($params, $project, function ($data) {
+        $assessments = $this->massApi($params, $project, function($data) {
             return isset($data['pages'][0]['pageassessments']) ? $data['pages'][0]['pageassessments'] : [];
         }, 'pacontinue')['pages'];
 
@@ -358,7 +358,7 @@ 
                 $classAttrs = $config['class']['Unknown'];
                 $assessment['class']['value'] = '???';
                 $assessment['class']['category'] = $classAttrs['category'];
-                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/". $classAttrs['badge'];
+                $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".$classAttrs['badge'];
             } else {
                 $classAttrs = $config['class'][$classValue];
                 $assessment['class'] = [
@@ -369,7 +369,7 @@ 
 
                 // add full URL to badge icon
                 if ($classAttrs['badge'] !== '') {
-                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/" .
+                    $assessment['class']['badge'] = "https://upload.wikimedia.org/wikipedia/commons/".
                         $classAttrs['badge'];
                 }
 
@@ -418,9 +418,9 @@ 
         $config = $this->getAssessmentsConfig();
 
         if (isset($config[$project]['class'][$class])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class'][$class]['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class'][$class]['badge'];
         } elseif (isset($config[$project]['class']['Unknown'])) {
-            return "https://upload.wikimedia.org/wikipedia/commons/" . $config[$project]['class']['Unknown']['badge'];
+            return "https://upload.wikimedia.org/wikipedia/commons/".$config[$project]['class']['Unknown']['badge'];
         } else {
             return "";
         }
@@ -513,7 +513,7 @@ 
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
         $innerPromise = $this->api->getRequestAsync($query);
 
-        $innerPromise->then(function ($result) use (&$data) {
+        $innerPromise->then(function($result) use (&$data) {
             // some failures come back as 200s, so we still resolve and let the outer function handle it
             if (isset($result['error']) || !isset($result['query'])) {
                 return $data['promise']->resolve($data);

src/AppBundle/Controller/TopEditsController.php

Doc Comments +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
      * List top edits by this user for all pages in a particular namespace.
      * @param User $user The User.
      * @param Project $project The project.
-     * @param integer|string $namespaceId The namespace ID or 'all'
+     * @param integer $namespaceId The namespace ID or 'all'
      * @return \Symfony\Component\HttpFoundation\Response
      */
     protected function namespaceTopEdits(User $user, Project $project, $namespaceId)

Spacing +6 added lines, -6 removed lines

@@ -55,7 +55,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectName != "") {
-            return $this->redirectToRoute("TopEditsResults", [ 'project'=>$projectName ]);
+            return $this->redirectToRoute("TopEditsResults", ['project'=>$projectName]);
         }
 
         // Set default project so we can populate the namespace selector.
@@ -131,11 +131,11 @@ 
         }
 
         // Get page info about these 100 pages, so we can use their display title.
-        $titles = array_map(function ($e) use ($namespaces) {
+        $titles = array_map(function($e) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $e['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']] . ':' : '';
-            return $nsTitle . $e['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']].':' : '';
+            return $nsTitle.$e['page_title'];
         }, $editData);
         /** @var ApiHelper $apiHelper */
         $apiHelper = $this->get('app.api_helper');
@@ -146,8 +146,8 @@ 
         foreach ($editData as $editDatum) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $editDatum['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $editDatum['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$editDatum['page_title'];
             $editDatum['displaytitle'] = $displayTitles[$pageTitle];
             // $editDatum['page_title'] is retained without the namespace
             //  so we can link to TopEdits for that page

src/Xtools/UserRepository.php

Spacing +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -96,7 +96,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.