x-tools / xtools

src/AppBundle/Controller/EditCounterController.php

Spacing +3 added lines, -3 removed lines

@@ -78,10 +78,10 @@ 
         $username = $request->query->get('username', $request->query->get('user'));
 
         if (($project || $queryProject) && $username) {
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
             return $this->redirectToRoute("EditCounterResult", $routeParams);
         } elseif (!$project && $queryProject) {
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
         }
 
         $project = ProjectRepository::getProject($queryProject, $this->container);
@@ -116,7 +116,7 @@ 
         }
         $isSubRequest = $this->container->get('request_stack')->getParentRequest() !== null;
         return $this->render('editCounter/result.html.twig', [
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->project->getTitle(),
+            'xtTitle' => $this->user->getUsername().' - '.$this->project->getTitle(),
             'xtPage' => 'ec',
             'base_dir' => realpath($this->getParameter('kernel.root_dir').'/..'),
             'is_sub_request' => $isSubRequest,

src/AppBundle/Controller/PagesController.php

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // set default wiki so we can populate the namespace selector
@@ -207,8 +207,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash('notice', [ 'no-result', $username ]);
-            return $this->redirectToRoute('PagesProject', [ 'project' => $project ]);
+            $this->addFlash('notice', ['no-result', $username]);
+            return $this->redirectToRoute('PagesProject', ['project' => $project]);
         }
 
         ksort($pagesByNamespaceByDate);

src/Xtools/EditCounterRepository.php

Spacing +5 added lines, -5 removed lines

@@ -146,10 +146,10 @@ 
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
         $logCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -366,9 +366,9 @@ 
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
             return $e['total'];
         }, $results));
 
@@ -427,7 +427,7 @@ 
             }
             $queries[] = $sql;
         }
-        $sql = "(\n" . join("\n) UNION (\n", $queries) . ")\n";
+        $sql = "(\n".join("\n) UNION (\n", $queries).")\n";
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
         $resultQuery->bindParam(":username", $username);
         $resultQuery->execute();

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
      */
     public function isAutomated($summary, $projectDomain)
     {
-        return (bool) $this->getTool($summary, $projectDomain);
+        return (bool)$this->getTool($summary, $projectDomain);
     }
 
     /**
@@ -109,14 +109,14 @@ 
 
         $revertEntries = array_filter(
             $this->getTools($projectDomain),
-            function ($tool) {
+            function($tool) {
                 return isset($tool['revert']);
             }
         );
 
         // If 'revert' is set to `true`, the use 'regex' as the regular expression,
         //  otherwise 'revert' is assumed to be the regex string.
-        $this->revertTools[$projectDomain] = array_map(function ($revertTool) {
+        $this->revertTools[$projectDomain] = array_map(function($revertTool) {
             return [
                 'link' => $revertTool['link'],
                 'regex' => $revertTool['revert'] === true ? $revertTool['regex'] : $revertTool['revert']

src/AppBundle/Controller/EditSummaryController.php

Spacing +4 added lines, -6 removed lines

@@ -143,8 +143,8 @@ 
     {
         $dbName = $project->getDatabaseName();
 
-        $cacheKey = 'editsummaryusage.' . $dbName . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editsummaryusage.'.$dbName.'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $cache = $this->container->get('cache.app');
         if ($cache->hasItem($cacheKey)) {
@@ -231,8 +231,7 @@ 
             if ($row['rev_minor_edit'] == 0) {
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMajor++;
                 }
 
@@ -249,8 +248,7 @@ 
                 // If there is a comment, count it
                 if ($row['rev_comment'] !== '') {
                     isset($monthEditsummaryTotals[$monthkey]) ?
-                        $monthEditsummaryTotals[$monthkey]++ :
-                        $monthEditsummaryTotals[$monthkey] = 1;
+                        $monthEditsummaryTotals[$monthkey]++ : $monthEditsummaryTotals[$monthkey] = 1;
                     $totalSummariesMinor++;
                     $totalEditsMinor++;
                 } else {

src/AppBundle/Controller/TopEditsController.php

Spacing +6 added lines, -6 removed lines

@@ -168,11 +168,11 @@ 
         }
 
         // Get page info about these 100 pages, so we can use their display title.
-        $titles = array_map(function ($e) use ($namespaces) {
+        $titles = array_map(function($e) use ($namespaces) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $e['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']] . ':' : '';
-            return $nsTitle . $e['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$e['page_namespace']].':' : '';
+            return $nsTitle.$e['page_title'];
         }, $editData);
 
         /** @var ApiHelper $apiHelper */
@@ -188,8 +188,8 @@ 
         foreach ($editData as $editDatum) {
             // If non-mainspace, prepend namespace to the titles.
             $ns = $editDatum['page_namespace'];
-            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']] . ':' : '';
-            $pageTitle = $nsTitle . $editDatum['page_title'];
+            $nsTitle = $ns > 0 ? $namespaces[$editDatum['page_namespace']].':' : '';
+            $pageTitle = $nsTitle.$editDatum['page_title'];
             $editDatum['displaytitle'] = $displayTitles[$pageTitle];
             // $editDatum['page_title'] is retained without the namespace
             //  so we can link to TopEdits for that page
@@ -249,7 +249,7 @@ 
         // Send all to the template.
         return $this->render('topedits/result_article.html.twig', [
             'xtPage' => 'topedits',
-            'xtTitle' => $user->getUsername() . ' - ' . $page->getTitle(),
+            'xtTitle' => $user->getUsername().' - '.$page->getTitle(),
             'project' => $project,
             'user' => $user,
             'page' => $page,

src/Xtools/Edit.php

Spacing +10 added lines, -10 removed lines

@@ -49,7 +49,7 @@ 
         $this->page = $page;
 
         // Copy over supported attributes
-        $this->id = (int) $attrs['id'];
+        $this->id = (int)$attrs['id'];
 
         // Allow DateTime or string (latter assumed to be of format YmdHis)
         if ($attrs['timestamp'] instanceof DateTime) {
@@ -198,7 +198,7 @@ 
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
 
         if ($isSection) {
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 $this->getPage()->getTitle(),
                 $this->getProject()->getArticlePath()
@@ -208,8 +208,8 @@ 
             // Must have underscores for the link to properly go to the section
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
 
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
         }
 
@@ -223,7 +223,7 @@ 
             );
 
             // Use normalized page title (underscored, capitalized)
-            $pageUrl = $this->getProject()->getUrl(false) . str_replace(
+            $pageUrl = $this->getProject()->getUrl(false).str_replace(
                 '$1',
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
                 $this->getProject()->getArticlePath()
@@ -261,8 +261,8 @@ 
     public function getDiffUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -272,8 +272,8 @@ 
     public function getPermaUrl()
     {
         $project = $this->getProject();
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
-        return rtrim($project->getUrl(), '/') . $path;
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
+        return rtrim($project->getUrl(), '/').$path;
     }
 
     /**
@@ -305,7 +305,7 @@ 
      */
     public function isAutomated(Container $container)
     {
-        return (bool) $this->getTool($container);
+        return (bool)$this->getTool($container);
     }
 
     /**

src/Xtools/User.php

Spacing +8 added lines, -8 removed lines

@@ -174,7 +174,7 @@ 
      */
     public function countAutomatedEdits(Project $project, $namespace = 'all', $start = '', $end = '')
     {
-        return (int) $this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
+        return (int)$this->getRepository()->countAutomatedEdits($project, $this, $namespace, $start, $end);
     }
 
     /**
@@ -206,21 +206,21 @@ 
 
         $namespaces = $project->getNamespaces();
 
-        return array_map(function ($rev) use ($namespaces) {
+        return array_map(function($rev) use ($namespaces) {
             $pageTitle = $rev['page_title'];
 
             if ($rev['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$rev['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$rev['page_namespace']].":$pageTitle";
             }
 
             return [
                 'page_title' => $pageTitle,
-                'page_namespace' => (int) $rev['page_namespace'],
-                'rev_id' => (int) $rev['rev_id'],
+                'page_namespace' => (int)$rev['page_namespace'],
+                'rev_id' => (int)$rev['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $rev['timestamp']),
-                'minor' => (bool) $rev['minor'],
-                'length' => (int) $rev['length'],
-                'length_change' => (int) $rev['length_change'],
+                'minor' => (bool)$rev['minor'],
+                'length' => (int)$rev['length'],
+                'length_change' => (int)$rev['length_change'],
                 'comment' => $rev['comment'],
             ];
         }, $revs);

src/Xtools/UserRepository.php

Spacing +27 added lines, -27 removed lines

@@ -78,7 +78,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -113,7 +113,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.
@@ -157,8 +157,8 @@ 
     {
         $username = $user->getUsername();
 
-        $cacheKey = 'pages.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $redirects;
+        $cacheKey = 'pages.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$redirects;
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -216,7 +216,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? 'GROUP BY rev_page' : '') . "
+            ".($hasPageAssessments ? 'GROUP BY rev_page' : '')."
             )
 
             UNION
@@ -263,21 +263,21 @@ 
      */
     public function countEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'editcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -337,21 +337,21 @@ 
      */
     public function countAutomatedEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'autoeditcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autoeditcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -383,7 +383,7 @@ 
             $tagJoin = $tags != '' ? "LEFT OUTER JOIN $tagTable ON ct_rev_id = rev_id" : '';
             $condTools[] = "ct_tag IN ($tags)";
         }
-        $condTool = 'AND (' . implode(' OR ', $condTools) . ')';
+        $condTool = 'AND ('.implode(' OR ', $condTools).')';
 
         $sql = "SELECT COUNT(DISTINCT(rev_id))
                 FROM $revisionTable
@@ -408,7 +408,7 @@ 
             $resultQuery->bindParam('namespace', $namespace);
         }
         $resultQuery->execute();
-        $result = (int) $resultQuery->fetchColumn();
+        $result = (int)$resultQuery->fetchColumn();
 
         // Cache for 10 minutes, and return.
         $cacheItem = $this->cache->getItem($cacheKey)
@@ -440,21 +440,21 @@ 
         $end = '',
         $offset = 0
     ) {
-        $cacheKey = 'nonautoedits.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $offset;
+        $cacheKey = 'nonautoedits.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$offset;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND revs.rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -547,21 +547,21 @@ 
         $start = '',
         $end = ''
     ) {
-        $cacheKey = 'autotoolcounts.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autotoolcounts.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -608,13 +608,13 @@ 
                 if ($condTool === '') {
                     $condTool = "ct_tag = $tag";
                 } else {
-                    $condTool = '(' . $condTool . " OR ct_tag = $tag)";
+                    $condTool = '('.$condTool." OR ct_tag = $tag)";
                 }
             }
 
             // Developer error, no regex or tag provided for this tool.
             if ($condTool === '') {
-                throw new Exception("No regex or tag found for the tool $toolname. " .
+                throw new Exception("No regex or tag found for the tool $toolname. ".
                     "Please verify this entry in semi_automated.yml");
             }
 
@@ -666,8 +666,8 @@ 
         }
 
         // Sort the array by count
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         // Cache for 10 minutes, and return.