Completed
Pull Request — master (#34)
by Sam
03:28
created
src/AppBundle/Twig/AppExtension.php 1 patch
Spacing   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -16,39 +16,39 @@  discard block
 block discarded – undo
16 16
     {
17 17
         $options = ['is_safe' => ['html']];
18 18
         return [
19
-            new \Twig_SimpleFunction('request_time', [ $this, 'requestTime' ], $options),
20
-            new \Twig_SimpleFunction('memory_usage', [ $this, 'requestMemory' ], $options),
21
-            new \Twig_SimpleFunction('year', [ $this, 'generateYear' ], $options),
22
-            new \Twig_SimpleFunction('msgPrintExists', [ $this, 'intuitionMessagePrintExists' ], $options),
23
-            new \Twig_SimpleFunction('msgExists', [ $this, 'intuitionMessageExists' ], $options),
24
-            new \Twig_SimpleFunction('msg', [ $this, 'intuitionMessage' ], $options),
25
-            new \Twig_SimpleFunction('lang', [ $this, 'getLang' ], $options),
26
-            new \Twig_SimpleFunction('langName', [ $this, 'getLangName' ], $options),
27
-            new \Twig_SimpleFunction('allLangs', [ $this, 'getAllLangs' ]),
28
-            new \Twig_SimpleFunction('isRTL', [ $this, 'intuitionIsRTL' ]),
29
-            new \Twig_SimpleFunction('isRTLLang', [ $this, 'intuitionIsRTLLang' ]),
30
-            new \Twig_SimpleFunction('shortHash', [ $this, 'gitShortHash' ]),
31
-            new \Twig_SimpleFunction('hash', [ $this, 'gitHash' ]),
32
-            new \Twig_SimpleFunction('enabled', [ $this, 'tabEnabled' ]),
33
-            new \Twig_SimpleFunction('tools', [ $this, 'allTools' ]),
34
-            new \Twig_SimpleFunction('color', [ $this, 'getColorList' ]),
35
-            new \Twig_SimpleFunction('chartColor', [ $this, 'chartColor' ]),
36
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
37
-            new \Twig_SimpleFunction('isSingleWiki', [ $this, 'isSingleWiki' ]),
38
-            new \Twig_SimpleFunction('getReplagThreshold', [ $this, 'getReplagThreshold' ]),
39
-            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [ $this, 'loadStylesheetsFromCDN' ]),
40
-            new \Twig_SimpleFunction('isWMFLabs', [ $this, 'isWMFLabs' ]),
41
-            new \Twig_SimpleFunction('replag', [ $this, 'replag' ]),
42
-            new \Twig_SimpleFunction('link', [ $this, 'link' ]),
43
-            new \Twig_SimpleFunction('quote', [ $this, 'quote' ]),
44
-            new \Twig_SimpleFunction('bugReportURL', [ $this, 'bugReportURL' ]),
19
+            new \Twig_SimpleFunction('request_time', [$this, 'requestTime'], $options),
20
+            new \Twig_SimpleFunction('memory_usage', [$this, 'requestMemory'], $options),
21
+            new \Twig_SimpleFunction('year', [$this, 'generateYear'], $options),
22
+            new \Twig_SimpleFunction('msgPrintExists', [$this, 'intuitionMessagePrintExists'], $options),
23
+            new \Twig_SimpleFunction('msgExists', [$this, 'intuitionMessageExists'], $options),
24
+            new \Twig_SimpleFunction('msg', [$this, 'intuitionMessage'], $options),
25
+            new \Twig_SimpleFunction('lang', [$this, 'getLang'], $options),
26
+            new \Twig_SimpleFunction('langName', [$this, 'getLangName'], $options),
27
+            new \Twig_SimpleFunction('allLangs', [$this, 'getAllLangs']),
28
+            new \Twig_SimpleFunction('isRTL', [$this, 'intuitionIsRTL']),
29
+            new \Twig_SimpleFunction('isRTLLang', [$this, 'intuitionIsRTLLang']),
30
+            new \Twig_SimpleFunction('shortHash', [$this, 'gitShortHash']),
31
+            new \Twig_SimpleFunction('hash', [$this, 'gitHash']),
32
+            new \Twig_SimpleFunction('enabled', [$this, 'tabEnabled']),
33
+            new \Twig_SimpleFunction('tools', [$this, 'allTools']),
34
+            new \Twig_SimpleFunction('color', [$this, 'getColorList']),
35
+            new \Twig_SimpleFunction('chartColor', [$this, 'chartColor']),
36
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
37
+            new \Twig_SimpleFunction('isSingleWiki', [$this, 'isSingleWiki']),
38
+            new \Twig_SimpleFunction('getReplagThreshold', [$this, 'getReplagThreshold']),
39
+            new \Twig_SimpleFunction('loadStylesheetsFromCDN', [$this, 'loadStylesheetsFromCDN']),
40
+            new \Twig_SimpleFunction('isWMFLabs', [$this, 'isWMFLabs']),
41
+            new \Twig_SimpleFunction('replag', [$this, 'replag']),
42
+            new \Twig_SimpleFunction('link', [$this, 'link']),
43
+            new \Twig_SimpleFunction('quote', [$this, 'quote']),
44
+            new \Twig_SimpleFunction('bugReportURL', [$this, 'bugReportURL']),
45 45
         ];
46 46
     }
47 47
 
48 48
     public function requestTime($decimals = 3)
49 49
     {
50 50
 
51
-        return number_format(microtime(true) - $_SERVER['REQUEST_TIME_FLOAT'], $decimals);
51
+        return number_format(microtime(true)-$_SERVER['REQUEST_TIME_FLOAT'], $decimals);
52 52
     }
53 53
 
54 54
     public function requestMemory()
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
     // TODO: refactor all intuition stuff so it can be used anywhere
69 69
     public function intuitionMessageExists($message = "")
70 70
     {
71
-        return $this->getIntuition()->msgExists($message, [ "domain" => "xtools" ]);
71
+        return $this->getIntuition()->msgExists($message, ["domain" => "xtools"]);
72 72
     }
73 73
 
74 74
     public function intuitionMessagePrintExists($message = "", $vars = [])
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
     public function intuitionMessage($message = "", $vars = [])
89 89
     {
90
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
90
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
91 91
     }
92 92
 
93 93
     public function getLang()
@@ -108,10 +108,10 @@  discard block
 block discarded – undo
108 108
      */
109 109
     public function getAllLangs()
110 110
     {
111
-        $messageFiles = glob($this->container->getParameter("kernel.root_dir") . '/../i18n/*.json');
111
+        $messageFiles = glob($this->container->getParameter("kernel.root_dir").'/../i18n/*.json');
112 112
 
113 113
         $languages = array_values(array_unique(array_map(
114
-            function ($filename) {
114
+            function($filename) {
115 115
                 return basename($filename, '.json');
116 116
             },
117 117
             $messageFiles
@@ -168,41 +168,41 @@  discard block
 block discarded – undo
168 168
     public static function getColorList($num = false)
169 169
     {
170 170
         $colors = [
171
-            0 => '#Cc0000',# '#FF005A', #red '#FF5555',
171
+            0 => '#Cc0000', # '#FF005A', #red '#FF5555',
172 172
             1 => '#F7b7b7',
173
-            2 => '#5c8d20',# '#008800', #green'#55FF55',
173
+            2 => '#5c8d20', # '#008800', #green'#55FF55',
174 174
             3 => '#85eD82',
175 175
             4 => '#2E97E0', # blue
176 176
             5 => '#B9E3F9',
177
-            6 => '#e1711d',  # orange
177
+            6 => '#e1711d', # orange
178 178
             7 => '#ffc04c',
179 179
             8 => '#FDFF98', # yellow
180 180
             9 => '#5555FF',
181 181
             10 => '#55FFFF',
182
-            11 => '#0000C0',  #
183
-            12 => '#008800',  # green
182
+            11 => '#0000C0', #
183
+            12 => '#008800', # green
184 184
             13 => '#00C0C0',
185
-            14 => '#FFAFAF',  # rosé
186
-            15 => '#808080',  # gray
185
+            14 => '#FFAFAF', # rosé
186
+            15 => '#808080', # gray
187 187
             16 => '#00C000',
188 188
             17 => '#404040',
189
-            18 => '#C0C000',  # green
189
+            18 => '#C0C000', # green
190 190
             19 => '#C000C0',
191
-            100 => '#75A3D1',  # blue
192
-            101 => '#A679D2',  # purple
191
+            100 => '#75A3D1', # blue
192
+            101 => '#A679D2', # purple
193 193
             102 => '#660000',
194 194
             103 => '#000066',
195
-            104 => '#FAFFAF',  # caramel
195
+            104 => '#FAFFAF', # caramel
196 196
             105 => '#408345',
197 197
             106 => '#5c8d20',
198
-            107 => '#e1711d',  # red
199
-            108 => '#94ef2b',  # light green
200
-            109 => '#756a4a',  # brown
198
+            107 => '#e1711d', # red
199
+            108 => '#94ef2b', # light green
200
+            109 => '#756a4a', # brown
201 201
             110 => '#6f1dab',
202 202
             111 => '#301e30',
203 203
             112 => '#5c9d96',
204
-            113 => '#a8cd8c',  # earth green
205
-            114 => '#f2b3f1',  # light purple
204
+            113 => '#a8cd8c', # earth green
205
+            114 => '#f2b3f1', # light purple
206 206
             115 => '#9b5828',
207 207
             118 => '#99FFFF',
208 208
             119 => '#99BBFF',
@@ -223,8 +223,8 @@  discard block
 block discarded – undo
223 223
             446 => '#06DCFB',
224 224
             447 => '#892EE4',
225 225
             460 => '#99FF66',
226
-            461 => '#99CC66',  # green
227
-            470 => '#CCCC33',  # ocker
226
+            461 => '#99CC66', # green
227
+            470 => '#CCCC33', # ocker
228 228
             471 => '#CCFF33',
229 229
             480 => '#6699FF',
230 230
             481 => '#66FFFF',
@@ -239,18 +239,18 @@  discard block
 block discarded – undo
239 239
             1198 => '#FF34B3',
240 240
             1199 => '#8B1C62',
241 241
 
242
-            '#61a9f3',# blue
243
-            '#f381b9',# pink
242
+            '#61a9f3', # blue
243
+            '#f381b9', # pink
244 244
             '#61E3A9',
245 245
             '#D56DE2',
246 246
             '#85eD82',
247 247
             '#F7b7b7',
248 248
             '#CFDF49',
249 249
             '#88d8f2',
250
-            '#07AF7B',# green
250
+            '#07AF7B', # green
251 251
             '#B9E3F9',
252 252
             '#FFF3AD',
253
-            '#EF606A',# red
253
+            '#EF606A', # red
254 254
             '#EC8833',
255 255
             '#FFF100',
256 256
             '#87C9A5',
@@ -400,8 +400,8 @@  discard block
 block discarded – undo
400 400
     public function getFilters()
401 401
     {
402 402
         return [
403
-            new \Twig_SimpleFilter('capitalize_first', [ $this, 'capitalizeFirst' ]),
404
-            new \Twig_SimpleFilter('percent_format', [ $this, 'percentFormat' ]),
403
+            new \Twig_SimpleFilter('capitalize_first', [$this, 'capitalizeFirst']),
404
+            new \Twig_SimpleFilter('percent_format', [$this, 'percentFormat']),
405 405
         ];
406 406
     }
407 407
 
@@ -428,9 +428,9 @@  discard block
 block discarded – undo
428 428
         if (!$denominator) {
429 429
             $quotient = $numerator;
430 430
         } else {
431
-            $quotient = ( $numerator / $denominator ) * 100;
431
+            $quotient = ($numerator / $denominator) * 100;
432 432
         }
433 433
 
434
-        return round($quotient, $precision) . '%';
434
+        return round($quotient, $precision).'%';
435 435
     }
436 436
 }
Please login to merge, or discard this patch.
src/AppBundle/Helper/AutomatedEditsHelper.php 2 patches
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -3,12 +3,7 @@
 block discarded – undo
3 3
 namespace AppBundle\Helper;
4 4
 
5 5
 use DateTime;
6
-use Doctrine\DBAL\Connection;
7
-use Psr\Cache\CacheItemPoolInterface;
8
-use Symfony\Component\Config\Definition\Exception\Exception;
9
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
10 6
 use Symfony\Component\DependencyInjection\ContainerInterface;
11
-use Symfony\Component\VarDumper\VarDumper;
12 7
 use Xtools\ProjectRepository;
13 8
 
14 9
 class AutomatedEditsHelper extends HelperBase
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -143,12 +143,12 @@  discard block
 block discarded – undo
143 143
         }
144 144
 
145 145
         // Get diff sizes, based on length of each parent revision
146
-        $parentRevIds = array_map(function ($edit) {
146
+        $parentRevIds = array_map(function($edit) {
147 147
             return $edit['rev_parent_id'];
148 148
         }, $editData);
149 149
         $query = "SELECT rev_len, rev_id
150 150
                   FROM revision
151
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
151
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
152 152
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
153 153
 
154 154
         // reformat with rev_id as the key, rev_len as the value
@@ -158,24 +158,24 @@  discard block
 block discarded – undo
158 158
         }
159 159
 
160 160
         // Build our array of nonautomated edits
161
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
161
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
162 162
             $pageTitle = $edit['page_title'];
163 163
 
164 164
             if ($edit['page_namespace'] !== '0') {
165
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
165
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
166 166
             }
167 167
 
168 168
             $diffSize = $edit['rev_len'];
169 169
             if ($edit['rev_parent_id'] > 0) {
170
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
170
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
171 171
             }
172 172
 
173 173
             return [
174 174
                 'page_title' => $pageTitle,
175
-                'namespace' => (int) $edit['page_namespace'],
176
-                'rev_id' => (int) $edit['rev_id'],
175
+                'namespace' => (int)$edit['page_namespace'],
176
+                'rev_id' => (int)$edit['rev_id'],
177 177
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
178
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
178
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
179 179
                 'summary' => $edit['rev_comment'],
180 180
                 'size' => $diffSize
181 181
             ];
Please login to merge, or discard this patch.
src/Xtools/UserRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@  discard block
 block discarded – undo
60 60
 
61 61
         $this->stopwatch->start($cacheKey, 'XTools');
62 62
         $api = $this->getMediawikiApi($project);
63
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
63
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
64 64
         $query = new SimpleRequest('query', $params);
65 65
         $result = [];
66 66
         $res = $api->getRequest($query);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         // Create the API query.
98 98
         $api = $this->getMediawikiApi($project);
99
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
99
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
100 100
         $query = new SimpleRequest('query', $params);
101 101
 
102 102
         // Get the result.
Please login to merge, or discard this patch.
src/AppBundle/Controller/EditCounterController.php 2 patches
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,13 +2,9 @@
 block discarded – undo
2 2
 
3 3
 namespace AppBundle\Controller;
4 4
 
5
-use AppBundle\Helper\ApiHelper;
6
-use AppBundle\Helper\AutomatedEditsHelper;
7
-use AppBundle\Helper\LabsHelper;
8 5
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10 7
 use Symfony\Component\HttpFoundation\Request;
11
-use Symfony\Component\VarDumper\VarDumper;
12 8
 use Xtools\EditCounter;
13 9
 use Xtools\EditCounterRepository;
14 10
 use Xtools\Project;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -65,10 +65,10 @@
 block discarded – undo
65 65
         $username = $request->query->get('username');
66 66
 
67 67
         if (($project || $queryProject) && $username) {
68
-            $routeParams = [ 'project'=>($project ?: $queryProject), 'username' => $username ];
68
+            $routeParams = ['project'=>($project ?: $queryProject), 'username' => $username];
69 69
             return $this->redirectToRoute("EditCounterResult", $routeParams);
70 70
         } elseif (!$project && $queryProject) {
71
-            return $this->redirectToRoute("EditCounterProject", [ 'project'=>$queryProject ]);
71
+            return $this->redirectToRoute("EditCounterProject", ['project'=>$queryProject]);
72 72
         }
73 73
 
74 74
         $project = ProjectRepository::getProject($queryProject, $this->container);
Please login to merge, or discard this patch.
src/Xtools/EditCounter.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      */
42 42
     protected function getRevisionCounts()
43 43
     {
44
-        if (! is_array($this->revisionCounts)) {
44
+        if (!is_array($this->revisionCounts)) {
45 45
             $this->revisionCounts = $this->getRepository()
46 46
                 ->getRevisionCounts($this->project, $this->user);
47 47
         }
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
      */
55 55
     protected function getRevisionDates()
56 56
     {
57
-        if (! is_array($this->revisionDates)) {
57
+        if (!is_array($this->revisionDates)) {
58 58
             $this->revisionDates = $this->getRepository()
59 59
                 ->getRevisionDates($this->project, $this->user);
60 60
         }
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
      */
68 68
     protected function getPageCounts()
69 69
     {
70
-        if (! is_array($this->pageCounts)) {
70
+        if (!is_array($this->pageCounts)) {
71 71
             $this->pageCounts = $this->getRepository()
72 72
                 ->getPageCounts($this->project, $this->user);
73 73
         }
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
      */
81 81
     protected function getLogCounts()
82 82
     {
83
-        if (! is_array($this->logCounts)) {
83
+        if (!is_array($this->logCounts)) {
84 84
             $this->logCounts = $this->getRepository()
85 85
                 ->getLogCounts($this->project, $this->user);
86 86
         }
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
      */
110 110
     public function countAllRevisions()
111 111
     {
112
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
112
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
113 113
     }
114 114
 
115 115
     /**
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
      */
129 129
     public function countRevisionsWithoutComments()
130 130
     {
131
-        return $this->countAllRevisions() - $this->countRevisionsWithComments();
131
+        return $this->countAllRevisions()-$this->countRevisionsWithComments();
132 132
     }
133 133
 
134 134
     /**
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     public function countAllPagesEdited()
197 197
     {
198
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
198
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
199 199
     }
200 200
 
201 201
     /**
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
      */
214 214
     public function countPagesCreated()
215 215
     {
216
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
216
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
217 217
     }
218 218
 
219 219
     /**
@@ -359,9 +359,9 @@  discard block
 block discarded – undo
359 359
     public function approvals()
360 360
     {
361 361
         $logCounts = $this->getLogCounts();
362
-        $total = $logCounts['review-approve'] +
363
-        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
364
-        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
362
+        $total = $logCounts['review-approve']+
363
+        (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
364
+        (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
365 365
         (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
366 366
         return $total;
367 367
     }
@@ -387,8 +387,8 @@  discard block
 block discarded – undo
387 387
         // Get counts.
388 388
         $editCounts = $this->getRepository()->getRevisionCountsAllProjects($user, $project);
389 389
         // Sort.
390
-        uasort($editCounts, function ($a, $b) {
391
-            return $b['total'] - $a['total'];
390
+        uasort($editCounts, function($a, $b) {
391
+            return $b['total']-$a['total'];
392 392
         });
393 393
         // Truncate, and return.
394 394
         return array_slice($editCounts, 0, $numProjects);
@@ -457,14 +457,14 @@  discard block
 block discarded – undo
457 457
             if (!isset($out['totals'][$ns])) {
458 458
                 $out['totals'][$ns] = [];
459 459
             }
460
-            $out['totals'][$ns][$total['year'] . $total['month']] = $total['count'];
460
+            $out['totals'][$ns][$total['year'].$total['month']] = $total['count'];
461 461
         }
462 462
         // Fill in the blanks (where no edits were made in a given month for a namespace).
463 463
         for ($y = $out['min_year']; $y <= $out['max_year']; $y++) {
464 464
             for ($m = 1; $m <= 12; $m++) {
465 465
                 foreach ($out['totals'] as $nsId => &$total) {
466
-                    if (!isset($total[$y . $m])) {
467
-                        $total[$y . $m] = 0;
466
+                    if (!isset($total[$y.$m])) {
467
+                        $total[$y.$m] = 0;
468 468
                     }
469 469
                 }
470 470
             }
Please login to merge, or discard this patch.
src/Xtools/EditCounterRepository.php 2 patches
Doc Comments   +1 added lines, -5 removed lines patch added patch discarded remove patch
@@ -250,7 +250,6 @@  discard block
 block discarded – undo
250 250
      * Get a user's total edit count on one or more project.
251 251
      * Requires the CentralAuth extension to be installed on the project.
252 252
      *
253
-     * @param string $username The username.
254 253
      * @param Project $project The project to start from.
255 254
      * @return mixed[]|boolean Array of total edit counts, or false if none could be found.
256 255
      */
@@ -300,7 +299,7 @@  discard block
 block discarded – undo
300 299
 
301 300
     /**
302 301
      * Get total edit counts for the top 10 projects for this user.
303
-     * @param string $username The username.
302
+     * @param string $stopwatchName
304 303
      * @return string[] Elements are arrays with 'dbName', 'url', 'name', and 'total'.
305 304
      */
306 305
     protected function getRevisionCountsAllProjectsNoCentralAuth(
@@ -395,7 +394,6 @@  discard block
 block discarded – undo
395 394
 
396 395
     /**
397 396
      * Get this user's most recent 10 edits across all projects.
398
-     * @param string $username The username.
399 397
      * @param integer $topN The number of items to return.
400 398
      * @param integer $days The number of days to search from each wiki.
401 399
      * @return string[]
@@ -453,7 +451,6 @@  discard block
 block discarded – undo
453 451
 
454 452
     /**
455 453
      * Get data for a bar chart of monthly edit totals per namespace.
456
-     * @param string $username The username.
457 454
      * @return string[]
458 455
      */
459 456
     public function getMonthCounts(Project $project, User $user)
@@ -489,7 +486,6 @@  discard block
 block discarded – undo
489 486
 
490 487
     /**
491 488
      * Get yearly edit totals for this user, grouped by namespace.
492
-     * @param string $username
493 489
      * @return string[] ['<namespace>' => ['<year>' => 'total', ... ], ... ]
494 490
      */
495 491
     public function getYearCounts(Project $project, User $user)
Please login to merge, or discard this patch.
Spacing   +25 added lines, -25 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
     public function getRevisionCounts(Project $project, User $user)
19 19
     {
20 20
         // Set up cache.
21
-        $cacheKey = 'revisioncounts.' . $project->getDatabaseName() . '.' . $user->getUsername();
21
+        $cacheKey = 'revisioncounts.'.$project->getDatabaseName().'.'.$user->getUsername();
22 22
         if ($this->cache->hasItem($cacheKey)) {
23 23
             return $this->cache->getItem($cacheKey)->get();
24 24
         }
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     public function getRevisionDates(Project $project, User $user)
80 80
     {
81 81
         // Set up cache.
82
-        $cacheKey = 'revisiondates.' . $project->getDatabaseName() . '.' . $user->getUsername();
82
+        $cacheKey = 'revisiondates.'.$project->getDatabaseName().'.'.$user->getUsername();
83 83
         if ($this->cache->hasItem($cacheKey)) {
84 84
             return $this->cache->getItem($cacheKey)->get();
85 85
         }
@@ -151,10 +151,10 @@  discard block
 block discarded – undo
151 151
         $results = $resultQuery->fetchAll();
152 152
 
153 153
         $pageCounts = array_combine(
154
-            array_map(function ($e) {
154
+            array_map(function($e) {
155 155
                 return $e['source'];
156 156
             }, $results),
157
-            array_map(function ($e) {
157
+            array_map(function($e) {
158 158
                 return $e['value'];
159 159
             }, $results)
160 160
         );
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 
186 186
         // Query.
187 187
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
188
-            FROM " . $this->getTableName($project->getDatabaseName(), 'logging') . "
188
+            FROM " . $this->getTableName($project->getDatabaseName(), 'logging')."
189 189
             WHERE log_user = :userId
190 190
             GROUP BY log_type, log_action";
191 191
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
@@ -194,10 +194,10 @@  discard block
 block discarded – undo
194 194
         $resultQuery->execute();
195 195
         $results = $resultQuery->fetchAll();
196 196
         $logCounts = array_combine(
197
-            array_map(function ($e) {
197
+            array_map(function($e) {
198 198
                 return $e['source'];
199 199
             }, $results),
200
-            array_map(function ($e) {
200
+            array_map(function($e) {
201 201
                 return $e['value'];
202 202
             }, $results)
203 203
         );
@@ -346,9 +346,9 @@  discard block
 block discarded – undo
346 346
         $resultQuery->bindParam(":id", $userId);
347 347
         $resultQuery->execute();
348 348
         $results = $resultQuery->fetchAll();
349
-        $namespaceTotals = array_combine(array_map(function ($e) {
349
+        $namespaceTotals = array_combine(array_map(function($e) {
350 350
             return $e['page_namespace'];
351
-        }, $results), array_map(function ($e) {
351
+        }, $results), array_map(function($e) {
352 352
             return $e['total'];
353 353
         }, $results));
354 354
         return $namespaceTotals;
@@ -412,14 +412,14 @@  discard block
 block discarded – undo
412 412
                 $revisions = $this->cache->getItem($cacheKey)->get();
413 413
             } else {
414 414
                 $sql =
415
-                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, " .
416
-                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, " .
417
-                    " page_title, page_namespace " . " FROM " .
418
-                    $this->getTableName($project['dbname'], 'revision') . "    JOIN " .
419
-                    $this->getTableName($project['dbname'], 'page') .
420
-                    "    ON (rev_page = page_id)" .
421
-                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username" .
422
-                    " ORDER BY rev_timestamp DESC" . " LIMIT 10";
415
+                    "SELECT rev_id, rev_timestamp, UNIX_TIMESTAMP(rev_timestamp) AS unix_timestamp, ".
416
+                    " rev_minor_edit, rev_deleted, rev_len, rev_parent_id, rev_comment, ".
417
+                    " page_title, page_namespace "." FROM ".
418
+                    $this->getTableName($project['dbname'], 'revision')."    JOIN ".
419
+                    $this->getTableName($project['dbname'], 'page').
420
+                    "    ON (rev_page = page_id)".
421
+                    " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username".
422
+                    " ORDER BY rev_timestamp DESC"." LIMIT 10";
423 423
                 $resultQuery = $this->getProjectsConnection()->prepare($sql);
424 424
                 $resultQuery->bindParam(":username", $username);
425 425
                 $resultQuery->execute();
@@ -434,7 +434,7 @@  discard block
 block discarded – undo
434 434
             if (count($revisions) === 0) {
435 435
                 continue;
436 436
             }
437
-            $revsWithProject = array_map(function (&$item) use ($project) {
437
+            $revsWithProject = array_map(function(&$item) use ($project) {
438 438
                 $item['project_name'] = $project['wikiName'];
439 439
                 $item['project_url'] = $project['url'];
440 440
                 $item['project_db_name'] = $project['dbName'];
@@ -444,8 +444,8 @@  discard block
 block discarded – undo
444 444
             }, $revisions);
445 445
             $allRevisions = array_merge($allRevisions, $revsWithProject);
446 446
         }
447
-        usort($allRevisions, function ($a, $b) {
448
-            return $b['rev_timestamp'] - $a['rev_timestamp'];
447
+        usort($allRevisions, function($a, $b) {
448
+            return $b['rev_timestamp']-$a['rev_timestamp'];
449 449
         });
450 450
 
451 451
         return array_slice($allRevisions, 0, $topN);
@@ -467,12 +467,12 @@  discard block
 block discarded – undo
467 467
         $revisionTable = $this->getTableName($project->getDatabaseName(), 'revision');
468 468
         $pageTable = $this->getTableName($project->getDatabaseName(), 'page');
469 469
         $sql =
470
-            "SELECT " . "     YEAR(rev_timestamp) AS `year`," .
471
-            "     MONTH(rev_timestamp) AS `month`," . "     page_namespace," .
470
+            "SELECT "."     YEAR(rev_timestamp) AS `year`,".
471
+            "     MONTH(rev_timestamp) AS `month`,"."     page_namespace,".
472 472
             "     COUNT(rev_id) AS `count` "
473
-            . " FROM $revisionTable    JOIN $pageTable ON (rev_page = page_id)" .
474
-            " WHERE rev_user_text = :username" .
475
-            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace " .
473
+            . " FROM $revisionTable    JOIN $pageTable ON (rev_page = page_id)".
474
+            " WHERE rev_user_text = :username".
475
+            " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace ".
476 476
             " ORDER BY rev_timestamp DESC";
477 477
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
478 478
         $resultQuery->bindParam(":username", $username);
Please login to merge, or discard this patch.
tests/AppBundle/Controller/ApiControllerTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@
 block discarded – undo
34 34
             $this->assertEquals(200, $client->getResponse()->getStatusCode());
35 35
 
36 36
             // Check that a correct namespace value was returned
37
-            $namespaces = (array) json_decode($client->getResponse()->getContent());
37
+            $namespaces = (array)json_decode($client->getResponse()->getContent());
38 38
             $this->assertEquals('Utilisateur', array_values($namespaces)[2]); // User in French
39 39
         }
40 40
     }
Please login to merge, or discard this patch.
app/autoload.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,6 +8,6 @@
 block discarded – undo
8 8
  */
9 9
 $loader = require __DIR__.'/../vendor/autoload.php';
10 10
 
11
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
11
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
12 12
 
13 13
 return $loader;
Please login to merge, or discard this patch.
app/AppKernel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
             new AppBundle\AppBundle(),
28 28
         ];
29 29
 
30
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
30
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
31 31
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
32 32
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
33 33
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();
Please login to merge, or discard this patch.