Completed
Pull Request — master (#15)
by Sam
02:40
created
src/AppBundle/Controller/ArticleInfoController.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -380,7 +380,6 @@
 block discarded – undo
380 380
 
381 381
     /**
382 382
      * Get the size of the diff
383
-     * @param  int $rev The index of the revision within $this->pageHistory
384 383
      * @return int Size of the diff
385 384
      */
386 385
     private function getDiffSize($revIndex)
Please login to merge, or discard this patch.
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -55,9 +55,9 @@  discard block
 block discarded – undo
55 55
         $article = $request->query->get('article');
56 56
 
57 57
         if ($projectQuery != '' && $article != '') {
58
-            return $this->redirectToRoute('ArticleInfoResult', [ 'project'=>$projectQuery, 'article' => $article ]);
58
+            return $this->redirectToRoute('ArticleInfoResult', ['project'=>$projectQuery, 'article' => $article]);
59 59
         } elseif ($article != '') {
60
-            return $this->redirectToRoute('ArticleInfoProject', [ 'project'=>$projectQuery ]);
60
+            return $this->redirectToRoute('ArticleInfoProject', ['project'=>$projectQuery]);
61 61
         }
62 62
 
63 63
         return $this->render('articleInfo/index.html.twig', [
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
             'url' => $basicInfo['fullurl']
102 102
         ];
103 103
 
104
-        $this->pageInfo['watchers'] = ( isset($basicInfo['watchers']) ) ? $basicInfo['watchers'] : "< 30";
104
+        $this->pageInfo['watchers'] = (isset($basicInfo['watchers'])) ? $basicInfo['watchers'] : "< 30";
105 105
 
106 106
         $pageProps = isset($basicInfo['pageprops']) ? $basicInfo['pageprops'] : [];
107 107
 
@@ -163,8 +163,8 @@  discard block
 block discarded – undo
163 163
      */
164 164
     private function getRevCount()
165 165
     {
166
-        $query = "SELECT COUNT(*) AS count FROM " . $this->revisionTable
167
-                 . " WHERE rev_page = '" . $this->pageInfo['id'] . "'";
166
+        $query = "SELECT COUNT(*) AS count FROM ".$this->revisionTable
167
+                 . " WHERE rev_page = '".$this->pageInfo['id']."'";
168 168
         $res = $this->conn->query($query)->fetchAll();
169 169
         return $res[0]['count'];
170 170
     }
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
                   FROM $this->revisionTable
197 197
                   LEFT JOIN $userGroupsTable ON rev_user = ug_user
198 198
                   LEFT JOIN $userFromerGroupsTable ON rev_user = ufg_user
199
-                  WHERE rev_page = " . $this->pageInfo['id'] . " AND (ug_group = 'bot' OR ufg_group = 'bot')
199
+                  WHERE rev_page = ".$this->pageInfo['id']." AND (ug_group = 'bot' OR ufg_group = 'bot')
200 200
                   GROUP BY rev_user_text";
201 201
         $res = $this->conn->query($query)->fetchAll();
202 202
 
@@ -205,14 +205,14 @@  discard block
 block discarded – undo
205 205
         $sum = 0;
206 206
         foreach ($res as $bot) {
207 207
             $bots[$bot['username']] = [
208
-                'count' => (int) $bot['count'],
208
+                'count' => (int)$bot['count'],
209 209
                 'current' => $bot['current'] === 'bot'
210 210
             ];
211 211
             $sum += $bot['count'];
212 212
         }
213 213
 
214
-        uasort($bots, function ($a, $b) {
215
-            return $b['count'] - $a['count'];
214
+        uasort($bots, function($a, $b) {
215
+            return $b['count']-$a['count'];
216 216
         });
217 217
 
218 218
         $this->pageInfo['general']['bot_revision_count'] = $sum;
@@ -248,10 +248,10 @@  discard block
 block discarded – undo
248 248
 
249 249
             if ($info['all'] > 1) {
250 250
                 // Number of seconds between first and last edit
251
-                $secs = intval(strtotime($info['last']) - strtotime($info['first']) / $info['all']);
251
+                $secs = intval(strtotime($info['last'])-strtotime($info['first']) / $info['all']);
252 252
 
253 253
                 // Average time between edits (in days)
254
-                $this->pageInfo['editors'][$editor]['atbe'] = $secs / ( 60 * 60 * 24 );
254
+                $this->pageInfo['editors'][$editor]['atbe'] = $secs / (60 * 60 * 24);
255 255
             }
256 256
 
257 257
             if (count($info['sizes'])) {
@@ -297,7 +297,7 @@  discard block
 block discarded – undo
297 297
 
298 298
         // Transform to associative array by 'type'
299 299
         foreach ($res as $row) {
300
-            $data[$row['type'] . '_count'] = $row['value'];
300
+            $data[$row['type'].'_count'] = $row['value'];
301 301
         }
302 302
 
303 303
         return $data;
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
         $title = str_replace(' ', '_', $this->pageInfo['title']);
314 314
         $query = "SELECT log_action, log_type, log_timestamp AS timestamp
315 315
                   FROM $loggingTable
316
-                  WHERE log_namespace = '" . $this->pageInfo['namespace'] . "'
316
+                  WHERE log_namespace = '".$this->pageInfo['namespace']."'
317 317
                   AND log_title = '$title' AND log_timestamp > 1
318 318
                   AND log_type IN ('delete', 'move', 'protect', 'stable')";
319 319
         $events = $this->conn->query($query)->fetchAll();
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
         $query = "SELECT rev_id, rev_parent_id, rev_user_text, rev_user, rev_timestamp,
372 372
                   rev_minor_edit, rev_len, rev_comment
373 373
                   FROM $this->revisionTable
374
-                  WHERE rev_page = '" . $this->pageInfo['id'] . "' AND rev_timestamp > 1
374
+                  WHERE rev_page = '".$this->pageInfo['id']."' AND rev_timestamp > 1
375 375
                   ORDER BY rev_timestamp";
376 376
 
377 377
         $res = $this->conn->query($query)->fetchAll();
@@ -391,9 +391,9 @@  discard block
 block discarded – undo
391 391
             return $rev['rev_len'];
392 392
         }
393 393
 
394
-        $lastRev = $this->pageHistory[$revIndex - 1];
394
+        $lastRev = $this->pageHistory[$revIndex-1];
395 395
 
396
-        return $rev['rev_len'] - $lastRev['rev_len'];
396
+        return $rev['rev_len']-$lastRev['rev_len'];
397 397
     }
398 398
 
399 399
     /**
@@ -413,12 +413,12 @@  discard block
 block discarded – undo
413 413
         // The month of the first edit. Used as a comparison when building the per-month data
414 414
         $firstEditMonth = strtotime(date('Y-m-01, 00:00', strtotime($firstEdit['rev_timestamp'])));
415 415
 
416
-        $lastEdit = $this->pageHistory[ $revisionCount - 1 ];
417
-        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[ $revisionCount - 2 ];
416
+        $lastEdit = $this->pageHistory[$revisionCount-1];
417
+        $secondLastEdit = $revisionCount === 1 ? $lastEdit : $this->pageHistory[$revisionCount-2];
418 418
 
419 419
         // Now we can start our master array. This one will be HUGE!
420 420
         $lastEditSize = ($revisionCount > 1)
421
-            ? $lastEdit['rev_len'] - $secondLastEdit['rev_len']
421
+            ? $lastEdit['rev_len']-$secondLastEdit['rev_len']
422 422
             : $lastEdit['rev_len'];
423 423
         $data = [
424 424
             'general' => [
@@ -515,7 +515,7 @@  discard block
 block discarded – undo
515 515
             // Increment year and month counts for all edits
516 516
             $data['year_count'][$timestamp['year']]['all']++;
517 517
             $data['year_count'][$timestamp['year']]['months'][$timestamp['month']]['all']++;
518
-            $data['year_count'][$timestamp['year']]['size'] = (int) $rev['rev_len'];
518
+            $data['year_count'][$timestamp['year']]['size'] = (int)$rev['rev_len'];
519 519
 
520 520
             $editsThisMonth = $data['year_count'][$timestamp['year']]['months'][$timestamp['month']]['all'];
521 521
             if ($editsThisMonth > $data['max_edits_per_month']) {
@@ -559,9 +559,9 @@  discard block
 block discarded – undo
559 559
                 }
560 560
 
561 561
                 // determine if the next revision was a revert
562
-                $nextRevision = isset($this->pageHistory[$i + 1]) ? $this->pageHistory[$i + 1] : null;
562
+                $nextRevision = isset($this->pageHistory[$i+1]) ? $this->pageHistory[$i+1] : null;
563 563
                 $nextRevisionIsRevert = $nextRevision &&
564
-                    $this->getDiffSize($i + 1) === -$diffSize &&
564
+                    $this->getDiffSize($i+1) === -$diffSize &&
565 565
                     $this->aeh->isRevert($nextRevision['rev_comment']);
566 566
 
567 567
                 // don't count this edit as content removal if the next edit reverted it
Please login to merge, or discard this patch.
var/SymfonyRequirements.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -223,7 +223,7 @@  discard block
 block discarded – undo
223 223
      * Adds a mandatory requirement in form of a php.ini configuration.
224 224
      *
225 225
      * @param string        $cfgName           The configuration name used for ini_get()
226
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
226
+     * @param boolean|string $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
227 227
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
228 228
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
229 229
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
@@ -241,7 +241,7 @@  discard block
 block discarded – undo
241 241
      * Adds an optional recommendation in form of a php.ini configuration.
242 242
      *
243 243
      * @param string        $cfgName           The configuration name used for ini_get()
244
-     * @param bool|callback $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
244
+     * @param string|false $evaluation        Either a boolean indicating whether the configuration should evaluate to true or false,
245 245
      *                                         or a callback function receiving the configuration value as parameter to determine the fulfillment of the requirement
246 246
      * @param bool          $approveCfgAbsence If true the Requirement will be fulfilled even if the configuration option does not exist, i.e. ini_get() returns false.
247 247
      *                                         This is helpful for abandoned configs in later PHP versions or configs of an optional extension, like Suhosin.
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
      */
50 50
     public function __construct($fulfilled, $testMessage, $helpHtml, $helpText = null, $optional = false)
51 51
     {
52
-        $this->fulfilled = (bool) $fulfilled;
53
-        $this->testMessage = (string) $testMessage;
54
-        $this->helpHtml = (string) $helpHtml;
55
-        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string) $helpText;
56
-        $this->optional = (bool) $optional;
52
+        $this->fulfilled = (bool)$fulfilled;
53
+        $this->testMessage = (string)$testMessage;
54
+        $this->helpHtml = (string)$helpHtml;
55
+        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string)$helpText;
56
+        $this->optional = (bool)$optional;
57 57
     }
58 58
 
59 59
     /**
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
             );
545 545
         }
546 546
 
547
-        $pcreVersion = defined('PCRE_VERSION') ? (float) PCRE_VERSION : null;
547
+        $pcreVersion = defined('PCRE_VERSION') ? (float)PCRE_VERSION : null;
548 548
 
549 549
         $this->addRequirement(
550 550
             null !== $pcreVersion,
@@ -783,7 +783,7 @@  discard block
 block discarded – undo
783 783
         $unit = '';
784 784
         if (!ctype_digit($size)) {
785 785
             $unit = strtolower(substr($size, -1, 1));
786
-            $size = (int) substr($size, 0, -1);
786
+            $size = (int)substr($size, 0, -1);
787 787
         }
788 788
         switch ($unit) {
789 789
             case 'g':
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
             case 'k':
794 794
                 return $size * 1024;
795 795
             default:
796
-                return (int) $size;
796
+                return (int)$size;
797 797
         }
798 798
     }
799 799
 
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
                 continue;
816 816
             }
817 817
 
818
-            return (int) $package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
818
+            return (int)$package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
819 819
         }
820 820
 
821 821
         return false;
Please login to merge, or discard this patch.
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
xtools_utilities/nonautomated_edits_parse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -15,11 +15,11 @@
 block discarded – undo
15 15
 $data = json_decode($file, true);
16 16
 
17 17
 // Output the contents to the piped file
18
-print ( "parameters:
18
+print ("parameters:
19 19
   automated_tools:\r\n" );
20 20
 foreach ($data as $row) {
21
-    print "  - " . $row["name"] . ": '" . $row["regex"] . "'\r\n";
21
+    print "  - ".$row["name"].": '".$row["regex"]."'\r\n";
22 22
 }
23
-print ( "
23
+print ("
24 24
 
25
-  semi-automated edits source: $url" );
25
+  semi-automated edits source: $url");
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminScoreController.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
27 27
         $username = $request->query->get('user');
28 28
 
29 29
         if ($projectQuery != "" && $username != "") {
30
-            return $this->redirectToRoute("AdminScoreResult", [ 'project'=>$projectQuery, 'username' => $username ]);
30
+            return $this->redirectToRoute("AdminScoreResult", ['project'=>$projectQuery, 'username' => $username]);
31 31
         } elseif ($projectQuery != "") {
32
-            return $this->redirectToRoute("AdminScoreProject", [ 'project'=>$projectQuery ]);
32
+            return $this->redirectToRoute("AdminScoreProject", ['project'=>$projectQuery]);
33 33
         }
34 34
 
35 35
         // Otherwise fall through.
@@ -67,20 +67,20 @@  discard block
 block discarded – undo
67 67
         $archiveTable = $lh->getTable("archive", $dbName);
68 68
 
69 69
         // MULTIPLIERS (to review)
70
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
71
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
72
-        $USER_PAGE_MULT = 0.1;     # 0 if =
70
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
71
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
72
+        $USER_PAGE_MULT = 0.1; # 0 if =
73 73
         $PATROLS_MULT = 1; # 0 if =
74
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
74
+        $BLOCKS_MULT = 1.4; # 0 if = 10
75 75
         $AFD_MULT = 1.15;
76
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
76
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
77 77
         $AIV_MULT = 1.15;
78
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
79
-        $NAMESPACES_MULT = 1.0;     # 0 if =
78
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
79
+        $NAMESPACES_MULT = 1.0; # 0 if =
80 80
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
81 81
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
82
-        $RPP_MULT = 1.15;     # 0 if =
83
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
82
+        $RPP_MULT = 1.15; # 0 if =
83
+        $USERRIGHTS_MULT = 0.75; # 0 if =
84 84
 
85 85
         // Grab the connection to the replica database (which is separate from the above)
86 86
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -154,15 +154,15 @@  discard block
 block discarded – undo
154 154
                 $now = new DateTime();
155 155
                 $date = new DateTime($value);
156 156
                 $diff = $date->diff($now);
157
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
157
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
158 158
                 $value = $formula-365;
159 159
             }
160 160
 
161 161
             if ($key == "id") {
162 162
                 $id = $value;
163 163
             } else {
164
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
165
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
164
+                $multiplierKey = strtoupper($row["source"]."_MULT");
165
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
166 166
                 $score = max(min($value * $multiplier, 100), -100);
167 167
                 $master[$key]["mult"] = $multiplier;
168 168
                 $master[$key]["value"] = $value;
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
         }
173 173
 
174 174
         if ($id == 0) {
175
-            $this->addFlash("notice", [ "noresult", $username ]);
176
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
175
+            $this->addFlash("notice", ["noresult", $username]);
176
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
177 177
         }
178 178
 
179 179
         // replace this example code with whatever you need
Please login to merge, or discard this patch.
src/AppBundle/Controller/SimpleEditCounterController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
         $username = $request->query->get('user');
32 32
 
33 33
         if ($projectQuery != "" && $username != "") {
34
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
34
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
35 35
             return $this->redirectToRoute("SimpleEditCounterResult", $routeParams);
36 36
         } elseif ($projectQuery != "") {
37
-            return $this->redirectToRoute("SimpleEditCounterProject", [ 'project'=>$projectQuery ]);
37
+            return $this->redirectToRoute("SimpleEditCounterProject", ['project'=>$projectQuery]);
38 38
         }
39 39
 
40 40
         // Otherwise fall through.
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
         $resultQuery->execute();
90 90
 
91 91
         if ($resultQuery->errorCode() > 0) {
92
-            $this->addFlash("notice", [ "noresult", $username ]);
93
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
92
+            $this->addFlash("notice", ["noresult", $username]);
93
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
94 94
         }
95 95
 
96 96
         // Fetch the result data
@@ -114,16 +114,16 @@  discard block
 block discarded – undo
114 114
                 $rev = $row["value"];
115 115
             }
116 116
             if ($row["source"] == "groups") {
117
-                $groups .= $row["value"]. ", ";
117
+                $groups .= $row["value"].", ";
118 118
             }
119 119
         }
120 120
 
121 121
         // Unknown user - If the user is created the $results variable will have 3 entries.
122 122
         // This is a workaround to detect non-existent IPs.
123 123
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
124
-            $this->addFlash('notice', [ "noresult", $username ]);
124
+            $this->addFlash('notice', ["noresult", $username]);
125 125
 
126
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
126
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
127 127
         }
128 128
 
129 129
         // Remove the last comma and space
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             'project_url' => $url,
153 153
             'id' => $id,
154 154
             'arch' => $arch,
155
-            'rev' => $rev + $arch,
155
+            'rev' => $rev+$arch,
156 156
             'live' => $rev,
157 157
             'groups' => $groups,
158 158
             'globalGroups' => $globalGroups,
Please login to merge, or discard this patch.
src/AppBundle/Helper/PageviewsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
         $title = str_replace(' ', '_', $title);
13 13
         $client = new GuzzleHttp\Client();
14 14
 
15
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
16
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
15
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
16
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
17 17
 
18 18
         $res = $client->request('GET', $url);
19 19
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $data = $this->getLastDays($project, $title, $days);
33 33
 
34 34
         // FIXME: needs to handle gotchas
35
-        return array_sum(array_map(function ($item) {
35
+        return array_sum(array_map(function($item) {
36 36
             return $item->views;
37 37
         }, $data->items));
38 38
     }
Please login to merge, or discard this patch.
src/AppBundle/Twig/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         // Find the path, and complain if English doesn't exist.
48
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
48
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
49 49
         if (!file_exists("$path/en.json")) {
50 50
             throw new Exception("Language directory doesn't exist: $path");
51 51
         }
Please login to merge, or discard this patch.
src/AppBundle/Helper/EditCounterHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
 
147 147
     /**
148 148
      *
149
-     * @param $username
149
+     * @param string $username
150 150
      * @return integer
151 151
      */
152 152
     public function getPageCounts($username, $totalRevisions)
Please login to merge, or discard this patch.
Spacing   +32 added lines, -32 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
     {
60 60
         $topEditCounts = [];
61 61
         foreach ($this->labsHelper->allProjects() as $project) {
62
-            $cacheKey = 'topprojects.' . $project['dbName'] . '.' . $username;
62
+            $cacheKey = 'topprojects.'.$project['dbName'].'.'.$username;
63 63
             if ($this->cacheHas($cacheKey)) {
64 64
                 $total = $this->cacheGet($cacheKey);
65 65
             } else {
@@ -75,8 +75,8 @@  discard block
 block discarded – undo
75 75
             }
76 76
             $topEditCounts[$project['dbName']] = array_merge($project, ['total' => $total]);
77 77
         }
78
-        uasort($topEditCounts, function ($a, $b) {
79
-            return $b['total'] - $a['total'];
78
+        uasort($topEditCounts, function($a, $b) {
79
+            return $b['total']-$a['total'];
80 80
         });
81 81
         return array_slice($topEditCounts, 0, $numProjects);
82 82
     }
@@ -146,10 +146,10 @@  discard block
 block discarded – undo
146 146
         }
147 147
 
148 148
         $revisionCounts = array_combine(
149
-            array_map(function ($e) {
149
+            array_map(function($e) {
150 150
                 return $e['source'];
151 151
             }, $results),
152
-            array_map(function ($e) {
152
+            array_map(function($e) {
153 153
                 return $e['value'];
154 154
             }, $results)
155 155
         );
@@ -157,8 +157,8 @@  discard block
 block discarded – undo
157 157
         // Count the number of days, accounting for when there's zero or one edit.
158 158
         $revisionCounts['days'] = 0;
159 159
         if (isset($revisionCounts['first']) && isset($revisionCounts['last'])) {
160
-            $editingTimeInSeconds = ceil($revisionCounts['last'] - $revisionCounts['first']);
161
-            $revisionCounts['days'] = $editingTimeInSeconds ? $editingTimeInSeconds/(60*60*24) : 1;
160
+            $editingTimeInSeconds = ceil($revisionCounts['last']-$revisionCounts['first']);
161
+            $revisionCounts['days'] = $editingTimeInSeconds ? $editingTimeInSeconds / (60 * 60 * 24) : 1;
162 162
         }
163 163
 
164 164
         // Format the first and last dates.
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
             : 0;
171 171
 
172 172
         // Sum deleted and live to make the total.
173
-        $revisionCounts['total'] = $revisionCounts['deleted'] + $revisionCounts['live'];
173
+        $revisionCounts['total'] = $revisionCounts['deleted']+$revisionCounts['live'];
174 174
 
175 175
         // Calculate the average number of live edits per day.
176 176
         $revisionCounts['avg_per_day'] = round(
@@ -214,16 +214,16 @@  discard block
 block discarded – undo
214 214
         $results = $resultQuery->fetchAll();
215 215
 
216 216
         $pageCounts = array_combine(
217
-            array_map(function ($e) {
217
+            array_map(function($e) {
218 218
                 return $e['source'];
219 219
             }, $results),
220
-            array_map(function ($e) {
220
+            array_map(function($e) {
221 221
                 return $e['value'];
222 222
             }, $results)
223 223
         );
224 224
 
225 225
         // Total created.
226
-        $pageCounts['created'] = $pageCounts['created-live'] + $pageCounts['created-deleted'];
226
+        $pageCounts['created'] = $pageCounts['created-live']+$pageCounts['created-deleted'];
227 227
 
228 228
         // Calculate the average number of edits per page.
229 229
         $pageCounts['edits_per_page'] = 0;
@@ -252,17 +252,17 @@  discard block
 block discarded – undo
252 252
         $resultQuery->execute();
253 253
         $results = $resultQuery->fetchAll();
254 254
         $logCounts = array_combine(
255
-            array_map(function ($e) {
255
+            array_map(function($e) {
256 256
                 return $e['source'];
257 257
             }, $results),
258
-            array_map(function ($e) {
258
+            array_map(function($e) {
259 259
                 return $e['value'];
260 260
             }, $results)
261 261
         );
262 262
 
263 263
         // Make sure there is some value for each of the wanted counts.
264 264
         $requiredCounts = [
265
-            'thanks-thank', 'review-approve', 'patrol-patrol','block-block', 'block-unblock',
265
+            'thanks-thank', 'review-approve', 'patrol-patrol', 'block-block', 'block-unblock',
266 266
             'protect-protect', 'protect-unprotect', 'delete-delete', 'delete-revision',
267 267
             'delete-restore', 'import-import', 'upload-upload', 'upload-overwrite',
268 268
         ];
@@ -273,9 +273,9 @@  discard block
 block discarded – undo
273 273
         }
274 274
 
275 275
         // Merge approvals together.
276
-        $logCounts['review-approve'] = $logCounts['review-approve'] +
277
-            (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0) +
278
-            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
276
+        $logCounts['review-approve'] = $logCounts['review-approve']+
277
+            (!empty($logCounts['review-approve-a']) ? $logCounts['review-approve-a'] : 0)+
278
+            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
279 279
             (!empty($logCounts['review-approve-ia']) ? $logCounts['review-approve-ia'] : 0);
280 280
 
281 281
         // Add Commons upload count, if applicable.
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
     {
302 302
         $userId = $this->getUserId($username);
303 303
         $sql = "SELECT page_namespace, count(rev_id) AS total
304
-            FROM ".$this->labsHelper->getTable('revision') ." r
304
+            FROM ".$this->labsHelper->getTable('revision')." r
305 305
                 JOIN ".$this->labsHelper->getTable('page')." p on r.rev_page = p.page_id
306 306
             WHERE r.rev_user = :id GROUP BY page_namespace";
307 307
         $resultQuery = $this->replicas->prepare($sql);
@@ -309,10 +309,10 @@  discard block
 block discarded – undo
309 309
         $resultQuery->execute();
310 310
         $results = $resultQuery->fetchAll();
311 311
         $namespaceTotals = array_combine(
312
-            array_map(function ($e) {
312
+            array_map(function($e) {
313 313
                 return $e['page_namespace'];
314 314
             }, $results),
315
-            array_map(function ($e) {
315
+            array_map(function($e) {
316 316
                 return $e['total'];
317 317
             }, $results)
318 318
         );
@@ -337,8 +337,8 @@  discard block
 block discarded – undo
337 337
                 $sql =
338 338
                     "SELECT rev_id, rev_comment, rev_timestamp, rev_minor_edit, rev_deleted, "
339 339
                     . "     rev_len, rev_parent_id, page_title "
340
-                    . " FROM " . $this->labsHelper->getTable('revision', $project['dbName'])
341
-                    . "    JOIN " . $this->labsHelper->getTable('page', $project['dbName'])
340
+                    . " FROM ".$this->labsHelper->getTable('revision', $project['dbName'])
341
+                    . "    JOIN ".$this->labsHelper->getTable('page', $project['dbName'])
342 342
                     . "    ON (rev_page = page_id)"
343 343
                     . " WHERE rev_timestamp > NOW() - INTERVAL $days DAY AND rev_user_text LIKE :username"
344 344
                     . " ORDER BY rev_timestamp DESC"
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
                 continue;
354 354
             }
355 355
             $revsWithProject = array_map(
356
-                function (&$item) use ($project) {
356
+                function(&$item) use ($project) {
357 357
                     $item['project_name'] = $project['name'];
358 358
                     $item['project_url'] = $project['url'];
359 359
                     $item['project_db_name'] = $project['dbName'];
@@ -363,8 +363,8 @@  discard block
 block discarded – undo
363 363
             );
364 364
             $allRevisions = array_merge($allRevisions, $revsWithProject);
365 365
         }
366
-        usort($allRevisions, function ($a, $b) {
367
-            return $b['rev_timestamp'] - $a['rev_timestamp'];
366
+        usort($allRevisions, function($a, $b) {
367
+            return $b['rev_timestamp']-$a['rev_timestamp'];
368 368
         });
369 369
         return array_slice($allRevisions, 0, $contribCount);
370 370
     }
@@ -386,8 +386,8 @@  discard block
 block discarded – undo
386 386
             . "     MONTH(rev_timestamp) AS `month`,"
387 387
             . "     page_namespace,"
388 388
             . "     COUNT(rev_id) AS `count` "
389
-            . " FROM " . $this->labsHelper->getTable('revision')
390
-            . "    JOIN " . $this->labsHelper->getTable('page') . " ON (rev_page = page_id)"
389
+            . " FROM ".$this->labsHelper->getTable('revision')
390
+            . "    JOIN ".$this->labsHelper->getTable('page')." ON (rev_page = page_id)"
391 391
             . " WHERE rev_user_text = :username"
392 392
             . " GROUP BY YEAR(rev_timestamp), MONTH(rev_timestamp), page_namespace "
393 393
             . " ORDER BY rev_timestamp DESC";
@@ -443,10 +443,10 @@  discard block
 block discarded – undo
443 443
             . "     SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4) AS `year`,"
444 444
             . "     page_namespace,"
445 445
             . "     COUNT(rev_id) AS `count` "
446
-            . " FROM " . $this->labsHelper->getTable('revision')
447
-            . "    JOIN " . $this->labsHelper->getTable('page') . " ON (rev_page = page_id)" .
448
-            " WHERE rev_user_text = :username" .
449
-            " GROUP BY SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4), page_namespace " .
446
+            . " FROM ".$this->labsHelper->getTable('revision')
447
+            . "    JOIN ".$this->labsHelper->getTable('page')." ON (rev_page = page_id)".
448
+            " WHERE rev_user_text = :username".
449
+            " GROUP BY SUBSTR(CAST(rev_timestamp AS CHAR(4)), 1, 4), page_namespace ".
450 450
             " ORDER BY rev_timestamp DESC ";
451 451
         $resultQuery = $this->replicas->prepare($sql);
452 452
         $resultQuery->bindParam(":username", $username);
@@ -487,7 +487,7 @@  discard block
 block discarded – undo
487 487
             . "     DAYOFWEEK(rev_timestamp) AS `y`, "
488 488
             . "     $xCalc AS `x`, "
489 489
             . "     COUNT(rev_id) AS `r` "
490
-            . " FROM " . $this->labsHelper->getTable('revision')
490
+            . " FROM ".$this->labsHelper->getTable('revision')
491 491
             . " WHERE rev_user_text = :username"
492 492
             . " GROUP BY DAYOFWEEK(rev_timestamp), $xCalc "
493 493
             . " ";
Please login to merge, or discard this patch.