Completed
Pull Request — master (#15)
by Sam
02:42
created
web/app_dev.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
 // Feel free to remove this, extend it, or make something more sophisticated.
13 13
 if (isset($_SERVER['HTTP_CLIENT_IP'])
14 14
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
15
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || php_sapi_name() === 'cli-server' )
15
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || php_sapi_name() === 'cli-server')
16 16
 ) {
17 17
     header('HTTP/1.0 403 Forbidden');
18 18
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
xtools_utilities/nonautomated_edits_parse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -15,11 +15,11 @@
 block discarded – undo
15 15
 $data = json_decode($file, true);
16 16
 
17 17
 // Output the contents to the piped file
18
-print ( "parameters:
18
+print ("parameters:
19 19
   automated_tools:\r\n" );
20 20
 foreach ($data as $row) {
21
-    print "  - " . $row["name"] . ": '" . $row["regex"] . "'\r\n";
21
+    print "  - ".$row["name"].": '".$row["regex"]."'\r\n";
22 22
 }
23
-print ( "
23
+print ("
24 24
 
25
-  semi-automated edits source: $url" );
25
+  semi-automated edits source: $url");
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminScoreController.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -27,9 +27,9 @@  discard block
 block discarded – undo
27 27
         $username = $request->query->get('user');
28 28
 
29 29
         if ($projectQuery != "" && $username != "") {
30
-            return $this->redirectToRoute("AdminScoreResult", [ 'project'=>$projectQuery, 'username' => $username ]);
30
+            return $this->redirectToRoute("AdminScoreResult", ['project'=>$projectQuery, 'username' => $username]);
31 31
         } elseif ($projectQuery != "") {
32
-            return $this->redirectToRoute("AdminScoreProject", [ 'project'=>$projectQuery ]);
32
+            return $this->redirectToRoute("AdminScoreProject", ['project'=>$projectQuery]);
33 33
         }
34 34
 
35 35
         // Otherwise fall through.
@@ -67,20 +67,20 @@  discard block
 block discarded – undo
67 67
         $archiveTable = $lh->getTable("archive", $dbName);
68 68
 
69 69
         // MULTIPLIERS (to review)
70
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
71
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
72
-        $USER_PAGE_MULT = 0.1;     # 0 if =
70
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
71
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
72
+        $USER_PAGE_MULT = 0.1; # 0 if =
73 73
         $PATROLS_MULT = 1; # 0 if =
74
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
74
+        $BLOCKS_MULT = 1.4; # 0 if = 10
75 75
         $AFD_MULT = 1.15;
76
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
76
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
77 77
         $AIV_MULT = 1.15;
78
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
79
-        $NAMESPACES_MULT = 1.0;     # 0 if =
78
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
79
+        $NAMESPACES_MULT = 1.0; # 0 if =
80 80
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
81 81
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
82
-        $RPP_MULT = 1.15;     # 0 if =
83
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
82
+        $RPP_MULT = 1.15; # 0 if =
83
+        $USERRIGHTS_MULT = 0.75; # 0 if =
84 84
 
85 85
         // Grab the connection to the replica database (which is separate from the above)
86 86
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -154,15 +154,15 @@  discard block
 block discarded – undo
154 154
                 $now = new DateTime();
155 155
                 $date = new DateTime($value);
156 156
                 $diff = $date->diff($now);
157
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
157
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
158 158
                 $value = $formula-365;
159 159
             }
160 160
 
161 161
             if ($key == "id") {
162 162
                 $id = $value;
163 163
             } else {
164
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
165
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
164
+                $multiplierKey = strtoupper($row["source"]."_MULT");
165
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
166 166
                 $score = max(min($value * $multiplier, 100), -100);
167 167
                 $master[$key]["mult"] = $multiplier;
168 168
                 $master[$key]["value"] = $value;
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
         }
173 173
 
174 174
         if ($id == 0) {
175
-            $this->addFlash("notice", [ "noresult", $username ]);
176
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
175
+            $this->addFlash("notice", ["noresult", $username]);
176
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
177 177
         }
178 178
 
179 179
         // replace this example code with whatever you need
Please login to merge, or discard this patch.
src/AppBundle/Controller/SimpleEditCounterController.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -31,10 +31,10 @@  discard block
 block discarded – undo
31 31
         $username = $request->query->get('user');
32 32
 
33 33
         if ($projectQuery != "" && $username != "") {
34
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
34
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
35 35
             return $this->redirectToRoute("SimpleEditCounterResult", $routeParams);
36 36
         } elseif ($projectQuery != "") {
37
-            return $this->redirectToRoute("SimpleEditCounterProject", [ 'project'=>$projectQuery ]);
37
+            return $this->redirectToRoute("SimpleEditCounterProject", ['project'=>$projectQuery]);
38 38
         }
39 39
 
40 40
         // Otherwise fall through.
@@ -89,8 +89,8 @@  discard block
 block discarded – undo
89 89
         $resultQuery->execute();
90 90
 
91 91
         if ($resultQuery->errorCode() > 0) {
92
-            $this->addFlash("notice", [ "noresult", $username ]);
93
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
92
+            $this->addFlash("notice", ["noresult", $username]);
93
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
94 94
         }
95 95
 
96 96
         // Fetch the result data
@@ -114,16 +114,16 @@  discard block
 block discarded – undo
114 114
                 $rev = $row["value"];
115 115
             }
116 116
             if ($row["source"] == "groups") {
117
-                $groups .= $row["value"]. ", ";
117
+                $groups .= $row["value"].", ";
118 118
             }
119 119
         }
120 120
 
121 121
         // Unknown user - If the user is created the $results variable will have 3 entries.
122 122
         // This is a workaround to detect non-existent IPs.
123 123
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
124
-            $this->addFlash('notice', [ "noresult", $username ]);
124
+            $this->addFlash('notice', ["noresult", $username]);
125 125
 
126
-            return $this->redirectToRoute("SimpleEditCounterProject", [ "project"=>$project ]);
126
+            return $this->redirectToRoute("SimpleEditCounterProject", ["project"=>$project]);
127 127
         }
128 128
 
129 129
         // Remove the last comma and space
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             'project_url' => $url,
153 153
             'id' => $id,
154 154
             'arch' => $arch,
155
-            'rev' => $rev + $arch,
155
+            'rev' => $rev+$arch,
156 156
             'live' => $rev,
157 157
             'groups' => $groups,
158 158
             'globalGroups' => $globalGroups,
Please login to merge, or discard this patch.
src/AppBundle/Helper/PageviewsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -12,8 +12,8 @@  discard block
 block discarded – undo
12 12
         $title = str_replace(' ', '_', $title);
13 13
         $client = new GuzzleHttp\Client();
14 14
 
15
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
16
-            "$project/all-access/user/" . rawurlencode($title) . '/daily/' . $start . '/' . $end;
15
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
16
+            "$project/all-access/user/".rawurlencode($title).'/daily/'.$start.'/'.$end;
17 17
 
18 18
         $res = $client->request('GET', $url);
19 19
         return json_decode($res->getBody()->getContents());
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
         $data = $this->getLastDays($project, $title, $days);
33 33
 
34 34
         // FIXME: needs to handle gotchas
35
-        return array_sum(array_map(function ($item) {
35
+        return array_sum(array_map(function($item) {
36 36
             return $item->views;
37 37
         }, $data->items));
38 38
     }
Please login to merge, or discard this patch.
src/AppBundle/Twig/Extension.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
         }
46 46
 
47 47
         // Find the path, and complain if English doesn't exist.
48
-        $path = $this->container->getParameter("kernel.root_dir") . '/../i18n';
48
+        $path = $this->container->getParameter("kernel.root_dir").'/../i18n';
49 49
         if (!file_exists("$path/en.json")) {
50 50
             throw new Exception("Language directory doesn't exist: $path");
51 51
         }
Please login to merge, or discard this patch.
var/SymfonyRequirements.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@  discard block
 block discarded – undo
49 49
      */
50 50
     public function __construct($fulfilled, $testMessage, $helpHtml, $helpText = null, $optional = false)
51 51
     {
52
-        $this->fulfilled = (bool) $fulfilled;
53
-        $this->testMessage = (string) $testMessage;
54
-        $this->helpHtml = (string) $helpHtml;
55
-        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string) $helpText;
56
-        $this->optional = (bool) $optional;
52
+        $this->fulfilled = (bool)$fulfilled;
53
+        $this->testMessage = (string)$testMessage;
54
+        $this->helpHtml = (string)$helpHtml;
55
+        $this->helpText = null === $helpText ? strip_tags($this->helpHtml) : (string)$helpText;
56
+        $this->optional = (bool)$optional;
57 57
     }
58 58
 
59 59
     /**
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
             );
545 545
         }
546 546
 
547
-        $pcreVersion = defined('PCRE_VERSION') ? (float) PCRE_VERSION : null;
547
+        $pcreVersion = defined('PCRE_VERSION') ? (float)PCRE_VERSION : null;
548 548
 
549 549
         $this->addRequirement(
550 550
             null !== $pcreVersion,
@@ -783,7 +783,7 @@  discard block
 block discarded – undo
783 783
         $unit = '';
784 784
         if (!ctype_digit($size)) {
785 785
             $unit = strtolower(substr($size, -1, 1));
786
-            $size = (int) substr($size, 0, -1);
786
+            $size = (int)substr($size, 0, -1);
787 787
         }
788 788
         switch ($unit) {
789 789
             case 'g':
@@ -793,7 +793,7 @@  discard block
 block discarded – undo
793 793
             case 'k':
794 794
                 return $size * 1024;
795 795
             default:
796
-                return (int) $size;
796
+                return (int)$size;
797 797
         }
798 798
     }
799 799
 
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
                 continue;
816 816
             }
817 817
 
818
-            return (int) $package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
818
+            return (int)$package['version'][1] > 2 ? self::REQUIRED_PHP_VERSION : self::LEGACY_REQUIRED_PHP_VERSION;
819 819
         }
820 820
 
821 821
         return false;
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminStatsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -176,7 +176,7 @@
 block discarded – undo
176 176
 
177 177
         // Iterate over query results, loading each user id into the array
178 178
         while ($row = $res->fetch()) {
179
-            $adminIdArr[] = $row["user_id"] ;
179
+            $adminIdArr[] = $row["user_id"];
180 180
         }
181 181
 
182 182
         // Set the query results to be useful in a sql statement.
Please login to merge, or discard this patch.
src/AppBundle/Helper/LabsHelper.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
             // Create the query we're going to run against the meta database
62 62
             $wikiQuery = $this->client->createQueryBuilder();
63 63
             $wikiQuery
64
-                ->select([ 'dbName', 'name', 'url', 'lang' ])
64
+                ->select(['dbName', 'name', 'url', 'lang'])
65 65
                 ->from('wiki')
66 66
                 ->where($wikiQuery->expr()->eq('dbname', ':project'))
67 67
                 // The meta database will have the project's URL stored as https://en.wikipedia.org
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
         $this->dbName = $dbName;
101 101
         $this->url = $url;
102 102
 
103
-        return [ 'dbName' => $dbName, 'wikiName' => $wikiName, 'url' => $url, 'lang' => $lang ];
103
+        return ['dbName' => $dbName, 'wikiName' => $wikiName, 'url' => $url, 'lang' => $lang];
104 104
     }
105 105
 
106 106
     /**
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
     public function allProjects()
110 110
     {
111 111
         $wikiQuery = $this->client->createQueryBuilder();
112
-        $wikiQuery->select([ 'dbName', 'name', 'url' ])->from('wiki');
112
+        $wikiQuery->select(['dbName', 'name', 'url'])->from('wiki');
113 113
         $stmt = $wikiQuery->execute();
114 114
         $out = $stmt->fetchAll();
115 115
         return $out;
Please login to merge, or discard this patch.