Completed
Pull Request — master (#41)
by Sam
03:04
created
src/AppBundle/Controller/MetaController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@  discard block
 block discarded – undo
31 31
         $end = $request->query->get('end');
32 32
 
33 33
         if ($start != '' && $end != '') {
34
-            return $this->redirectToRoute('MetaResult', [ 'start' => $start, 'end' => $end ]);
34
+            return $this->redirectToRoute('MetaResult', ['start' => $start, 'end' => $end]);
35 35
         }
36 36
 
37 37
         return $this->render('meta/index.html.twig', [
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
         $timeline = [];
74 74
         $startObj = new DateTime($start);
75 75
         $endObj = new DateTime($end);
76
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
76
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
77 77
         $grandSum = 0;
78 78
 
79 79
         // Generate array of date labels
@@ -85,17 +85,17 @@  discard block
 block discarded – undo
85 85
 
86 86
         foreach ($data as $entry) {
87 87
             if (!isset($totals[$entry['tool']])) {
88
-                $totals[$entry['tool']] = (int) $entry['count'];
88
+                $totals[$entry['tool']] = (int)$entry['count'];
89 89
 
90 90
                 // Create arrays for each tool, filled with zeros for each date in the timeline
91 91
                 $timeline[$entry['tool']] = array_fill(0, $numDays, 0);
92 92
             } else {
93
-                $totals[$entry['tool']] += (int) $entry['count'];
93
+                $totals[$entry['tool']] += (int)$entry['count'];
94 94
             }
95 95
 
96 96
             $date = new DateTime($entry['date']);
97
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
98
-            $timeline[$entry['tool']][$dateIndex] = (int) $entry['count'];
97
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
98
+            $timeline[$entry['tool']][$dateIndex] = (int)$entry['count'];
99 99
 
100 100
             $grandSum += $entry['count'];
101 101
         }
Please login to merge, or discard this patch.
src/AppBundle/Twig/WikiExtension.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      */
31 31
     public function intuitionMessage($message = "", $vars = [])
32 32
     {
33
-        return $this->getIntuition()->msg($message, [ "domain" => "xtools", "variables" => $vars ]);
33
+        return $this->getIntuition()->msg($message, ["domain" => "xtools", "variables" => $vars]);
34 34
     }
35 35
 
36 36
     /*********************************** FUNCTIONS ***********************************/
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      */
42 42
     public function getFunctions()
43 43
     {
44
-        $options = [ 'is_safe' => [ 'html']];
44
+        $options = ['is_safe' => ['html']];
45 45
         return [];
46 46
     }
47 47
 
@@ -54,8 +54,8 @@  discard block
 block discarded – undo
54 54
     public function getFilters()
55 55
     {
56 56
         return [
57
-            new \Twig_SimpleFilter('diff_format', [ $this, 'diffFormat' ], [ 'is_safe' => [ 'html' ] ]),
58
-            new \Twig_SimpleFilter('wikify_comment', [ $this, 'wikifyComment' ], [ 'is_safe' => [ 'html' ] ]),
57
+            new \Twig_SimpleFilter('diff_format', [$this, 'diffFormat'], ['is_safe' => ['html']]),
58
+            new \Twig_SimpleFilter('wikify_comment', [$this, 'wikifyComment'], ['is_safe' => ['html']]),
59 59
         ];
60 60
     }
61 61
 
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
         if ($isSection) {
95 95
             $sectionTitle = $sectionMatch[1][0];
96 96
             $sectionTitleLink = str_replace(' ', '_', $sectionTitle);
97
-            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>" .
97
+            $sectionWikitext = "<a target='_blank' href='$projectUrl/wiki/$title#$sectionTitleLink'>&rarr;</a>".
98 98
                 "<em class='text-muted'>$sectionTitle:</em> ";
99 99
             $wikitext = str_replace($sectionMatch[0][0], $sectionWikitext, $wikitext);
100 100
         }
Please login to merge, or discard this patch.
src/AppBundle/Helper/ApiHelper.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     public function groups($project, $username)
66 66
     {
67 67
         $this->setUp($project);
68
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
68
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
69 69
         $query = new SimpleRequest('query', $params);
70 70
         $result = [];
71 71
 
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     public function globalGroups($project, $username)
92 92
     {
93 93
         $this->setUp($project);
94
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
94
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
95 95
         $query = new SimpleRequest('query', $params);
96 96
         $result = [];
97 97
 
@@ -141,7 +141,7 @@  discard block
 block discarded – undo
141 141
                 $groups[] = "B";
142 142
             }
143 143
             if (in_array("steward", $admin["groups"])) {
144
-                $groups[] = "S" ;
144
+                $groups[] = "S";
145 145
             }
146 146
             if (in_array("checkuser", $admin["groups"])) {
147 147
                 $groups[] = "CU";
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             if (in_array("bot", $admin["groups"])) {
153 153
                 $groups[] = "Bot";
154 154
             }
155
-            $result[ $admin["name"] ] = [
155
+            $result[$admin["name"]] = [
156 156
                 "groups" => implode('/', $groups)
157 157
             ];
158 158
         }
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
             $normalized = [];
228 228
             if (isset($result['query']['normalized'])) {
229 229
                 array_map(
230
-                    function ($e) use (&$normalized) {
230
+                    function($e) use (&$normalized) {
231 231
                         $normalized[$e['to']] = $e['from'];
232 232
                     },
233 233
                     $result['query']['normalized']
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
         $query = FluentRequest::factory()->setAction('query')->setParams($requestData);
313 313
         $innerPromise = $this->api->getRequestAsync($query);
314 314
 
315
-        $innerPromise->then(function ($result) use (&$data) {
315
+        $innerPromise->then(function($result) use (&$data) {
316 316
             // some failures come back as 200s, so we still resolve and let the outer function handle it
317 317
             if (isset($result['error']) || !isset($result['query'])) {
318 318
                 return $data['promise']->resolve($data);
Please login to merge, or discard this patch.
src/AppBundle/Controller/AdminScoreController.php 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -47,9 +47,9 @@  discard block
 block discarded – undo
47 47
         $username = $request->query->get('username', $request->query->get('user'));
48 48
 
49 49
         if ($projectQuery != '' && $username != '') {
50
-            return $this->redirectToRoute('AdminScoreResult', [ 'project' => $projectQuery, 'username' => $username ]);
50
+            return $this->redirectToRoute('AdminScoreResult', ['project' => $projectQuery, 'username' => $username]);
51 51
         } elseif ($projectQuery != '') {
52
-            return $this->redirectToRoute('AdminScoreProject', [ 'project' => $projectQuery ]);
52
+            return $this->redirectToRoute('AdminScoreProject', ['project' => $projectQuery]);
53 53
         }
54 54
 
55 55
         // Set default project so we can populate the namespace selector.
@@ -95,20 +95,20 @@  discard block
 block discarded – undo
95 95
         $archiveTable = $projectRepo->getTableName($dbName, 'archive');
96 96
 
97 97
         // MULTIPLIERS (to review)
98
-        $ACCT_AGE_MULT = 1.25;   # 0 if = 365 jours
99
-        $EDIT_COUNT_MULT = 1.25;     # 0 if = 10 000
100
-        $USER_PAGE_MULT = 0.1;     # 0 if =
98
+        $ACCT_AGE_MULT = 1.25; # 0 if = 365 jours
99
+        $EDIT_COUNT_MULT = 1.25; # 0 if = 10 000
100
+        $USER_PAGE_MULT = 0.1; # 0 if =
101 101
         $PATROLS_MULT = 1; # 0 if =
102
-        $BLOCKS_MULT = 1.4;     # 0 if = 10
102
+        $BLOCKS_MULT = 1.4; # 0 if = 10
103 103
         $AFD_MULT = 1.15;
104
-        $RECENT_ACTIVITY_MULT = 0.9;     # 0 if =
104
+        $RECENT_ACTIVITY_MULT = 0.9; # 0 if =
105 105
         $AIV_MULT = 1.15;
106
-        $EDIT_SUMMARIES_MULT = 0.8;   # 0 if =
107
-        $NAMESPACES_MULT = 1.0;     # 0 if =
106
+        $EDIT_SUMMARIES_MULT = 0.8; # 0 if =
107
+        $NAMESPACES_MULT = 1.0; # 0 if =
108 108
         $PAGES_CREATED_LIVE_MULT = 1.4; # 0 if =
109 109
         $PAGES_CREATED_ARCHIVE_MULT = 1.4; # 0 if =
110
-        $RPP_MULT = 1.15;     # 0 if =
111
-        $USERRIGHTS_MULT = 0.75;   # 0 if =
110
+        $RPP_MULT = 1.15; # 0 if =
111
+        $USERRIGHTS_MULT = 0.75; # 0 if =
112 112
 
113 113
         // Grab the connection to the replica database (which is separate from the above)
114 114
         $conn = $this->get('doctrine')->getManager("replicas")->getConnection();
@@ -186,15 +186,15 @@  discard block
 block discarded – undo
186 186
                 $now = new DateTime();
187 187
                 $date = new DateTime($value);
188 188
                 $diff = $date->diff($now);
189
-                $formula = 365*$diff->format("%y")+30*$diff->format("%m")+$diff->format("%d");
189
+                $formula = 365 * $diff->format("%y")+30 * $diff->format("%m")+$diff->format("%d");
190 190
                 $value = $formula-365;
191 191
             }
192 192
 
193 193
             if ($key == "id") {
194 194
                 $id = $value;
195 195
             } else {
196
-                $multiplierKey = strtoupper($row["source"] . "_MULT");
197
-                $multiplier = ( isset($$multiplierKey) ? $$multiplierKey : 1 );
196
+                $multiplierKey = strtoupper($row["source"]."_MULT");
197
+                $multiplier = (isset($$multiplierKey) ? $$multiplierKey : 1);
198 198
                 $score = max(min($value * $multiplier, 100), -100);
199 199
                 $master[$key]["mult"] = $multiplier;
200 200
                 $master[$key]["value"] = $value;
@@ -204,8 +204,8 @@  discard block
 block discarded – undo
204 204
         }
205 205
 
206 206
         if ($id == 0) {
207
-            $this->addFlash("notice", [ "no-result", $username ]);
208
-            return $this->redirectToRoute("AdminScore", [ "project"=>$project ]);
207
+            $this->addFlash("notice", ["no-result", $username]);
208
+            return $this->redirectToRoute("AdminScore", ["project"=>$project]);
209 209
         }
210 210
 
211 211
         return $this->render('adminscore/result.html.twig', [
Please login to merge, or discard this patch.
src/AppBundle/Controller/AutomatedEditsController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $archiveTable = $projectData->getRepository()->getTableName($dbName, 'archive');
169 169
 
170 170
         $condBegin = $start ? " AND rev_timestamp > :start " : null;
171
-        $condEnd = $end ? " AND rev_timestamp < :end ": null;
171
+        $condEnd = $end ? " AND rev_timestamp < :end " : null;
172 172
 
173 173
         $regexes = [];
174 174
 
@@ -262,8 +262,8 @@  discard block
 block discarded – undo
262 262
         }
263 263
 
264 264
         // Sort the array and do some simple math.
265
-        uasort($results, function ($a, $b) {
266
-            return $b['count'] - $a['count'];
265
+        uasort($results, function($a, $b) {
266
+            return $b['count']-$a['count'];
267 267
         });
268 268
 
269 269
         if ($total != 0) {
Please login to merge, or discard this patch.
src/AppBundle/Controller/SimpleEditCounterController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
         // If we've got a project and user, redirect to results.
50 50
         if ($projectName != '' && $username != '') {
51
-            $routeParams = [ 'project' => $projectName, 'username' => $username ];
51
+            $routeParams = ['project' => $projectName, 'username' => $username];
52 52
             return $this->redirectToRoute('SimpleEditCounterResult', $routeParams);
53 53
         }
54 54
 
@@ -120,8 +120,8 @@  discard block
 block discarded – undo
120 120
         $resultQuery->execute();
121 121
 
122 122
         if ($resultQuery->errorCode() > 0) {
123
-            $this->addFlash('notice', [ 'no-result', $username ]);
124
-            return $this->redirectToRoute('SimpleEditCounterProject', [ 'project' => $project->getDomain() ]);
123
+            $this->addFlash('notice', ['no-result', $username]);
124
+            return $this->redirectToRoute('SimpleEditCounterProject', ['project' => $project->getDomain()]);
125 125
         }
126 126
 
127 127
         // Fetch the result data
@@ -145,16 +145,16 @@  discard block
 block discarded – undo
145 145
                 $rev = $row['value'];
146 146
             }
147 147
             if ($row['source'] == 'groups') {
148
-                $groups .= $row['value']. ', ';
148
+                $groups .= $row['value'].', ';
149 149
             }
150 150
         }
151 151
 
152 152
         // Unknown user - If the user is created the $results variable will have 3 entries.
153 153
         // This is a workaround to detect non-existent IPs.
154 154
         if (count($results) < 3 && $arch == 0 && $rev == 0) {
155
-            $this->addFlash('notice', [ 'no-result', $username ]);
155
+            $this->addFlash('notice', ['no-result', $username]);
156 156
 
157
-            return $this->redirectToRoute('SimpleEditCounterProject', [ 'project' => $project->getDomain() ]);
157
+            return $this->redirectToRoute('SimpleEditCounterProject', ['project' => $project->getDomain()]);
158 158
         }
159 159
 
160 160
         // Remove the last comma and space
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
             'project' => $project,
184 184
             'id' => $id,
185 185
             'arch' => $arch,
186
-            'rev' => $rev + $arch,
186
+            'rev' => $rev+$arch,
187 187
             'live' => $rev,
188 188
             'groups' => $groups,
189 189
             'globalGroups' => $globalGroups,
Please login to merge, or discard this patch.
src/Xtools/Repository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -150,7 +150,7 @@
 block discarded – undo
150 150
         // $tableExtension in order to generate the new table name
151 151
         if ($this->isLabs() && $tableExtension !== null) {
152 152
             $mapped = true;
153
-            $tableName = $tableName . '_' . $tableExtension;
153
+            $tableName = $tableName.'_'.$tableExtension;
154 154
         } elseif ($this->container->hasParameter("app.table.$tableName")) {
155 155
             // Use the table specified in the table mapping configuration, if present.
156 156
             $mapped = true;
Please login to merge, or discard this patch.
src/AppBundle/Helper/AutomatedEditsHelper.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
         $revTable = $project->getRepository()->getTableName($project->getDatabaseName(), 'revision');
127 127
         $pageTable = $project->getRepository()->getTableName($project->getDatabaseName(), 'page');
128 128
 
129
-        $AEBTypes = array_map(function ($AEBType) {
129
+        $AEBTypes = array_map(function($AEBType) {
130 130
             return $AEBType['regex'];
131 131
         }, $this->container->getParameter('automated_tools'));
132 132
 
@@ -151,12 +151,12 @@  discard block
 block discarded – undo
151 151
         }
152 152
 
153 153
         // Get diff sizes, based on length of each parent revision
154
-        $parentRevIds = array_map(function ($edit) {
154
+        $parentRevIds = array_map(function($edit) {
155 155
             return $edit['rev_parent_id'];
156 156
         }, $editData);
157 157
         $query = "SELECT rev_len, rev_id
158 158
                   FROM revision
159
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
159
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
160 160
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
161 161
 
162 162
         // reformat with rev_id as the key, rev_len as the value
@@ -166,24 +166,24 @@  discard block
 block discarded – undo
166 166
         }
167 167
 
168 168
         // Build our array of nonautomated edits
169
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
169
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
170 170
             $pageTitle = $edit['page_title'];
171 171
 
172 172
             if ($edit['page_namespace'] !== '0') {
173
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
173
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
174 174
             }
175 175
 
176 176
             $diffSize = $edit['rev_len'];
177 177
             if ($edit['rev_parent_id'] > 0) {
178
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
178
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
179 179
             }
180 180
 
181 181
             return [
182 182
                 'page_title' => $pageTitle,
183
-                'namespace' => (int) $edit['page_namespace'],
184
-                'rev_id' => (int) $edit['rev_id'],
183
+                'namespace' => (int)$edit['page_namespace'],
184
+                'rev_id' => (int)$edit['rev_id'],
185 185
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
186
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
186
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
187 187
                 'summary' => $edit['rev_comment'],
188 188
                 'size' => $diffSize
189 189
             ];
Please login to merge, or discard this patch.
src/Xtools/EditCounterRepository.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
     public function getPairData(Project $project, User $user)
28 28
     {
29 29
         // Set up cache.
30
-        $cacheKey = 'pairdata.' . $project->getDatabaseName() . '.' . $user->getUsername();
30
+        $cacheKey = 'pairdata.'.$project->getDatabaseName().'.'.$user->getUsername();
31 31
         if ($this->cache->hasItem($cacheKey)) {
32 32
             return $this->cache->getItem($cacheKey)->get();
33 33
         }
@@ -153,10 +153,10 @@  discard block
 block discarded – undo
153 153
         $resultQuery->execute();
154 154
         $results = $resultQuery->fetchAll();
155 155
         $logCounts = array_combine(
156
-            array_map(function ($e) {
156
+            array_map(function($e) {
157 157
                 return $e['source'];
158 158
             }, $results),
159
-            array_map(function ($e) {
159
+            array_map(function($e) {
160 160
                 return $e['value'];
161 161
             }, $results)
162 162
         );
@@ -378,9 +378,9 @@  discard block
 block discarded – undo
378 378
         $resultQuery->bindParam(":id", $userId);
379 379
         $resultQuery->execute();
380 380
         $results = $resultQuery->fetchAll();
381
-        $namespaceTotals = array_combine(array_map(function ($e) {
381
+        $namespaceTotals = array_combine(array_map(function($e) {
382 382
             return $e['page_namespace'];
383
-        }, $results), array_map(function ($e) {
383
+        }, $results), array_map(function($e) {
384 384
             return $e['total'];
385 385
         }, $results));
386 386
 
@@ -439,7 +439,7 @@  discard block
 block discarded – undo
439 439
             }
440 440
             $queries[] = $sql;
441 441
         }
442
-        $sql = "(\n" . join("\n) UNION (\n", $queries) . ")\n";
442
+        $sql = "(\n".join("\n) UNION (\n", $queries).")\n";
443 443
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
444 444
         $resultQuery->bindParam(":username", $username);
445 445
         $resultQuery->execute();
Please login to merge, or discard this patch.