Passed
Push — symfony-upgrade ( d3a256...8f42b6 )
by MusikAnimal
04:15
created
src/Model/CategoryEdits.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the CategoryEdits class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
     ) {
47 47
         $this->project = $project;
48 48
         $this->user = $user;
49
-        $this->categories = array_map(function ($category) {
49
+        $this->categories = array_map(function($category) {
50 50
             return str_replace(' ', '_', $category);
51 51
         }, $categories);
52 52
         $this->start = $start;
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
      */
79 79
     public function getCategoriesNormalized(): array
80 80
     {
81
-        return array_map(function ($category) {
81
+        return array_map(function($category) {
82 82
             return str_replace('_', ' ', $category);
83 83
         }, $this->categories);
84 84
     }
Please login to merge, or discard this patch.
src/Model/AutoEdits.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AutoEdits class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
     public function getToolsTotal(): int
233 233
     {
234 234
         if (!is_int($this->toolsTotal)) {
235
-            $this->toolsTotal = array_reduce($this->getToolCounts(), function ($a, $b) {
236
-                return $a + $b['count'];
235
+            $this->toolsTotal = array_reduce($this->getToolCounts(), function($a, $b) {
236
+                return $a+$b['count'];
237 237
             });
238 238
         }
239 239
 
Please login to merge, or discard this patch.
src/Model/EditCounter.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the EditCounter class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 
145 145
         // Filter out unblocks unless requested.
146 146
         if ($blocksOnly) {
147
-            $blocks = array_filter($blocks, function ($block) {
147
+            $blocks = array_filter($blocks, function($block) {
148 148
                 return 'block' === $block['log_action'];
149 149
             });
150 150
         }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
      */
179 179
     public function countAllRevisions(): int
180 180
     {
181
-        return $this->countLiveRevisions() + $this->countDeletedRevisions();
181
+        return $this->countLiveRevisions()+$this->countDeletedRevisions();
182 182
     }
183 183
 
184 184
     /**
@@ -217,7 +217,7 @@  discard block
 block discarded – undo
217 217
      */
218 218
     public function countAllPagesEdited(): int
219 219
     {
220
-        return $this->countLivePagesEdited() + $this->countDeletedPagesEdited();
220
+        return $this->countLivePagesEdited()+$this->countDeletedPagesEdited();
221 221
     }
222 222
 
223 223
     /**
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
      */
228 228
     public function countPagesCreated(): int
229 229
     {
230
-        return $this->countCreatedPagesLive() + $this->countPagesCreatedDeleted();
230
+        return $this->countCreatedPagesLive()+$this->countPagesCreatedDeleted();
231 231
     }
232 232
 
233 233
     /**
@@ -367,7 +367,7 @@  discard block
 block discarded – undo
367 367
             } elseif ('unblock' === $block['log_action']) {
368 368
                 // The last block was lifted. So the duration will be the time from when the
369 369
                 // last block was set to the time of the unblock.
370
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
370
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
371 371
                 if ($timeSinceLastBlock > $this->longestBlockSeconds) {
372 372
                     $this->longestBlockSeconds = $timeSinceLastBlock;
373 373
 
@@ -378,8 +378,8 @@  discard block
 block discarded – undo
378 378
                 // The last block was modified. So we will adjust $lastBlock to include
379 379
                 // the difference of the duration of the new reblock, and time since the last block.
380 380
                 // $lastBlock is left unchanged if its duration was indefinite.
381
-                $timeSinceLastBlock = $timestamp - $lastBlock[0];
382
-                $lastBlock[1] = $timeSinceLastBlock + $duration;
381
+                $timeSinceLastBlock = $timestamp-$lastBlock[0];
382
+                $lastBlock[1] = $timeSinceLastBlock+$duration;
383 383
             }
384 384
         }
385 385
 
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
         }
390 390
 
391 391
         // Test if the last block is still active, and if so use the expiry as the duration.
392
-        $lastBlockExpiry = $lastBlock[0] + $lastBlock[1];
392
+        $lastBlockExpiry = $lastBlock[0]+$lastBlock[1];
393 393
         if ($lastBlockExpiry > time() && $lastBlockExpiry > $this->longestBlockSeconds) {
394 394
             $this->longestBlockSeconds = $lastBlock[1];
395 395
         // Otherwise, test if the duration of the last block is now the longest overall.
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
         // If invalid, $duration is left as null.
434 434
         if (strtotime($durationStr)) {
435 435
             $expiry = strtotime($durationStr, $timestamp);
436
-            $duration = $expiry - $timestamp;
436
+            $duration = $expiry-$timestamp;
437 437
         }
438 438
 
439 439
         return [$timestamp, $duration];
@@ -520,7 +520,7 @@  discard block
 block discarded – undo
520 520
         $import = isset($logCounts['import-import']) ? (int)$logCounts['import-import'] : 0;
521 521
         $interwiki = isset($logCounts['import-interwiki']) ? (int)$logCounts['import-interwiki'] : 0;
522 522
         $upload = isset($logCounts['import-upload']) ? (int)$logCounts['import-upload'] : 0;
523
-        return $import + $interwiki + $upload;
523
+        return $import+$interwiki+$upload;
524 524
     }
525 525
 
526 526
     /**
@@ -542,7 +542,7 @@  discard block
 block discarded – undo
542 542
         $logCounts = $this->getLogCounts();
543 543
         $new = isset($logCounts['contentmodel-new']) ? (int)$logCounts['contentmodel-new'] : 0;
544 544
         $modified = isset($logCounts['contentmodel-change']) ? (int)$logCounts['contentmodel-change'] : 0;
545
-        return $new + $modified;
545
+        return $new+$modified;
546 546
     }
547 547
 
548 548
     /**
@@ -674,9 +674,9 @@  discard block
 block discarded – undo
674 674
     public function approvals(): int
675 675
     {
676 676
         $logCounts = $this->getLogCounts();
677
-        $total = (!empty($logCounts['review-approve']) ? $logCounts['review-approve'] : 0) +
678
-            (!empty($logCounts['review-approve2']) ? $logCounts['review-approve2'] : 0) +
679
-            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0) +
677
+        $total = (!empty($logCounts['review-approve']) ? $logCounts['review-approve'] : 0)+
678
+            (!empty($logCounts['review-approve2']) ? $logCounts['review-approve2'] : 0)+
679
+            (!empty($logCounts['review-approve-i']) ? $logCounts['review-approve-i'] : 0)+
680 680
             (!empty($logCounts['review-approve2-i']) ? $logCounts['review2-approve-i'] : 0);
681 681
         return $total;
682 682
     }
@@ -700,7 +700,7 @@  discard block
 block discarded – undo
700 700
         $logCounts = $this->getLogCounts();
701 701
         $create2 = $logCounts['newusers-create2'] ?: 0;
702 702
         $byemail = $logCounts['newusers-byemail'] ?: 0;
703
-        return $create2 + $byemail;
703
+        return $create2+$byemail;
704 704
     }
705 705
 
706 706
     /**
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
802 802
 
803 803
         $totals = $this->getRepository()->getMonthCounts($this->project, $this->user);
804 804
         $out = [
805
-            'yearLabels' => [],  // labels for years
805
+            'yearLabels' => [], // labels for years
806 806
             'monthLabels' => [], // labels for months
807 807
             'totals' => [], // actual totals, grouped by namespace, year and then month
808 808
         ];
@@ -896,7 +896,7 @@  discard block
 block discarded – undo
896 896
                 $out['totals'][$ns][$total['year']] = [];
897 897
             }
898 898
 
899
-            $out['totals'][$ns][$total['year']][$total['month']] = (int) $total['count'];
899
+            $out['totals'][$ns][$total['year']][$total['month']] = (int)$total['count'];
900 900
         }
901 901
 
902 902
         return [$out, $firstEdit];
@@ -913,9 +913,9 @@  discard block
 block discarded – undo
913 913
     private function fillInMonthTotalsAndLabels(array $out, DatePeriod $dateRange): array
914 914
     {
915 915
         foreach ($dateRange as $monthObj) {
916
-            $year = (int) $monthObj->format('Y');
916
+            $year = (int)$monthObj->format('Y');
917 917
             $yearLabel = $this->i18n->dateFormat($monthObj, 'yyyy');
918
-            $month = (int) $monthObj->format('n');
918
+            $month = (int)$monthObj->format('n');
919 919
             $monthLabel = $this->i18n->dateFormat($monthObj, 'yyyy-MM');
920 920
 
921 921
             // Fill in labels
@@ -1059,7 +1059,7 @@  discard block
 block discarded – undo
1059 1059
     public function countSmallEdits(): int
1060 1060
     {
1061 1061
         $editSizeData = $this->getEditSizeData();
1062
-        return isset($editSizeData['small_edits']) ? (int) $editSizeData['small_edits'] : 0;
1062
+        return isset($editSizeData['small_edits']) ? (int)$editSizeData['small_edits'] : 0;
1063 1063
     }
1064 1064
 
1065 1065
     /**
@@ -1069,7 +1069,7 @@  discard block
 block discarded – undo
1069 1069
     public function countLargeEdits(): int
1070 1070
     {
1071 1071
         $editSizeData = $this->getEditSizeData();
1072
-        return isset($editSizeData['large_edits']) ? (int) $editSizeData['large_edits'] : 0;
1072
+        return isset($editSizeData['large_edits']) ? (int)$editSizeData['large_edits'] : 0;
1073 1073
     }
1074 1074
 
1075 1075
     /**
Please login to merge, or discard this patch.
src/Model/UserRights.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
  * This file contains only the UserRights class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
Please login to merge, or discard this patch.
src/Model/Edit.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Edit class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public static function getEditsFromRevs(Project $project, User $user, array $revs): array
88 88
     {
89
-        return array_map(function ($rev) use ($project, $user) {
89
+        return array_map(function($rev) use ($project, $user) {
90 90
             /** @var Page $page Page object to be passed to the Edit constructor. */
91 91
             $page = Page::newFromRow($project, $rev);
92 92
             $rev['user'] = $user;
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
309 309
 
310 310
         if ($isSection && isset($page)) {
311
-            $pageUrl = $project->getUrl(false) . str_replace(
311
+            $pageUrl = $project->getUrl(false).str_replace(
312 312
                 '$1',
313 313
                 $page->getTitle($useUnnormalizedPageTitle),
314 314
                 $project->getArticlePath()
@@ -318,8 +318,8 @@  discard block
 block discarded – undo
318 318
             // Must have underscores for the link to properly go to the section.
319 319
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
320 320
 
321
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
322
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
321
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
322
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
323 323
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
324 324
         }
325 325
 
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
             );
334 334
 
335 335
             // Use normalized page title (underscored, capitalized).
336
-            $pageUrl = $project->getUrl(false) . str_replace(
336
+            $pageUrl = $project->getUrl(false).str_replace(
337 337
                 '$1',
338 338
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
339 339
                 $project->getArticlePath()
@@ -371,8 +371,8 @@  discard block
 block discarded – undo
371 371
     public function getDiffUrl(): string
372 372
     {
373 373
         $project = $this->getProject();
374
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
375
-        return rtrim($project->getUrl(), '/') . $path;
374
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
375
+        return rtrim($project->getUrl(), '/').$path;
376 376
     }
377 377
 
378 378
     /**
@@ -382,8 +382,8 @@  discard block
 block discarded – undo
382 382
     public function getPermaUrl(): string
383 383
     {
384 384
         $project = $this->getProject();
385
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
386
-        return rtrim($project->getUrl(), '/') . $path;
385
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
386
+        return rtrim($project->getUrl(), '/').$path;
387 387
     }
388 388
 
389 389
     /**
@@ -466,10 +466,10 @@  discard block
 block discarded – undo
466 466
             $ret['reverted'] = $this->reverted;
467 467
         }
468 468
         if ($includeUsername) {
469
-            $ret = [ 'username' => $this->getUser()->getUsername() ] + $ret;
469
+            $ret = ['username' => $this->getUser()->getUsername()]+$ret;
470 470
         }
471 471
         if ($includeProject) {
472
-            $ret = [ 'project' => $this->getProject()->getDomain() ] + $ret;
472
+            $ret = ['project' => $this->getProject()->getDomain()]+$ret;
473 473
         }
474 474
 
475 475
         return $ret;
Please login to merge, or discard this patch.
src/Model/AdminStats.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AdminStats class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         $stats = $this->groupStatsByUsername($stats);
97 97
 
98 98
         // Resort, as for some reason the SQL doesn't do this properly.
99
-        uasort($stats, function ($a, $b) {
99
+        uasort($stats, function($a, $b) {
100 100
             if ($a['total'] === $b['total']) {
101 101
                 return 0;
102 102
             }
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         $this->usersAndGroups = $this->project->getUsersInGroups($groupUserGroups['local'], $groupUserGroups['global']);
128 128
 
129 129
         // Populate $this->usersInGroup with users who are in the relevant user group for $this->group.
130
-        $this->usersInGroup = array_keys(array_filter($this->usersAndGroups, function ($groups) {
130
+        $this->usersInGroup = array_keys(array_filter($this->usersAndGroups, function($groups) {
131 131
             return in_array($this->getRelevantUserGroup(), $groups);
132 132
         }));
133 133
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         }
151 151
 
152 152
         if ($wikiPath) {
153
-            $out = array_map(function ($url) {
153
+            $out = array_map(function($url) {
154 154
                 return str_replace('.svg.png', '.svg', preg_replace('/.*\/18px-/', '', $url));
155 155
             }, $out);
156 156
         }
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     public function numDays(): int
166 166
     {
167
-        return (int)(($this->end - $this->start) / 60 / 60 / 24) + 1;
167
+        return (int)(($this->end-$this->start) / 60 / 60 / 24)+1;
168 168
     }
169 169
 
170 170
     /**
@@ -254,6 +254,6 @@  discard block
 block discarded – undo
254 254
      */
255 255
     public function getNumWithActionsNotInGroup(): int
256 256
     {
257
-        return count($this->adminStats) - $this->numWithActions;
257
+        return count($this->adminStats)-$this->numWithActions;
258 258
     }
259 259
 }
Please login to merge, or discard this patch.
src/Model/ArticleInfo.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1319,10 +1319,10 @@
 block discarded – undo
1319 1319
         // Slice to the top 10.
1320 1320
         $topTenEditorsByAdded = array_keys(array_slice($topTenEditorsByAdded, 0, 10, true));
1321 1321
 
1322
-         // Get the sum of added text so that we can add in percentages.
1323
-         $topTenTotalAdded = array_sum(array_map(function ($editor) {
1324
-             return $this->editors[$editor]['added'];
1325
-         }, $topTenEditorsByAdded));
1322
+            // Get the sum of added text so that we can add in percentages.
1323
+            $topTenTotalAdded = array_sum(array_map(function ($editor) {
1324
+                return $this->editors[$editor]['added'];
1325
+            }, $topTenEditorsByAdded));
1326 1326
 
1327 1327
         // Then build a new array of top 10 editors by added text in the data structure needed for the chart.
1328 1328
         return array_map(function ($editor) use ($topTenTotalAdded) {
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfo class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -975,7 +975,7 @@  discard block
 block discarded – undo
975 975
 
976 976
             if ($info['all'] > 1) {
977 977
                 // Number of seconds/days between first and last edit.
978
-                $secs = $info['last']->getTimestamp() - $info['first']->getTimestamp();
978
+                $secs = $info['last']->getTimestamp()-$info['first']->getTimestamp();
979 979
                 $days = $secs / (60 * 60 * 24);
980 980
 
981 981
                 // Average time between edits (in days).
@@ -984,7 +984,7 @@  discard block
 block discarded – undo
984 984
         }
985 985
 
986 986
         // Loop through again and add percentages.
987
-        $this->topTenEditorsByEdits = array_map(function ($editor) use ($topTenCount) {
987
+        $this->topTenEditorsByEdits = array_map(function($editor) use ($topTenCount) {
988 988
             $editor['percentage'] = 100 * ($editor['value'] / $topTenCount);
989 989
             return $editor;
990 990
         }, $topTenEditorsByEdits);
@@ -1002,7 +1002,7 @@  discard block
 block discarded – undo
1002 1002
     {
1003 1003
         // First sort editors array by the amount of text they added.
1004 1004
         $topTenEditorsByAdded = $this->editors;
1005
-        uasort($topTenEditorsByAdded, function ($a, $b) {
1005
+        uasort($topTenEditorsByAdded, function($a, $b) {
1006 1006
             if ($a['added'] === $b['added']) {
1007 1007
                 return 0;
1008 1008
             }
@@ -1013,12 +1013,12 @@  discard block
 block discarded – undo
1013 1013
         $topTenEditorsByAdded = array_keys(array_slice($topTenEditorsByAdded, 0, 10, true));
1014 1014
 
1015 1015
          // Get the sum of added text so that we can add in percentages.
1016
-         $topTenTotalAdded = array_sum(array_map(function ($editor) {
1016
+         $topTenTotalAdded = array_sum(array_map(function($editor) {
1017 1017
              return $this->editors[$editor]['added'];
1018 1018
          }, $topTenEditorsByAdded));
1019 1019
 
1020 1020
         // Then build a new array of top 10 editors by added text in the data structure needed for the chart.
1021
-        return array_map(function ($editor) use ($topTenTotalAdded) {
1021
+        return array_map(function($editor) use ($topTenTotalAdded) {
1022 1022
             $added = $this->editors[$editor]['added'];
1023 1023
             return [
1024 1024
                 'label' => $editor,
Please login to merge, or discard this patch.
src/Model/SimpleEditCounter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the SimpleEditCounter class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function getTotalEditCount(): int
150 150
     {
151
-        return $this->data['total_edit_count'] ?? $this->data['deleted_edit_count'] + $this->data['live_edit_count'];
151
+        return $this->data['total_edit_count'] ?? $this->data['deleted_edit_count']+$this->data['live_edit_count'];
152 152
     }
153 153
 
154 154
     /**
Please login to merge, or discard this patch.
src/Model/EditSummary.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@
 block discarded – undo
3 3
  * This file contains only the EditSummary class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace App\Model;
9 9
 
Please login to merge, or discard this patch.