x-tools / xtools

src/Xtools/UserRepository.php

Spacing +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -96,7 +96,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.

src/AppBundle/Controller/PagesController.php

Unused Use Statements -1 removed lines

@@ -6,7 +6,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 
 class PagesController extends Controller

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // set default wiki so we can populate the namespace selector
@@ -183,7 +183,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? "GROUP BY rev_page" : "") . "
+            ".($hasPageAssessments ? "GROUP BY rev_page" : "")."
             )
 
             UNION
@@ -267,8 +267,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash("notice", [ "no-result", $username ]);
-            return $this->redirectToRoute("PagesProject", [ "project"=>$project ]);
+            $this->addFlash("notice", ["no-result", $username]);
+            return $this->redirectToRoute("PagesProject", ["project"=>$project]);
         }
 
         ksort($pagesByNamespaceByDate);

src/AppBundle/Helper/LabsHelper.php

Unused Use Statements -2 removed lines

@@ -2,10 +2,8 @@
 
 namespace AppBundle\Helper;
 
-use Symfony\Component\Config\Definition\Exception\Exception;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Symfony\Component\VarDumper\VarDumper;
 
 class LabsHelper
 {

Spacing +3 added lines, -3 removed lines

@@ -78,7 +78,7 @@ 
         // Create the query we're going to run against the meta database
         $wikiQuery = $this->client->createQueryBuilder();
         $wikiQuery
-            ->select([ 'dbname', 'name', 'url', 'lang' ])
+            ->select(['dbname', 'name', 'url', 'lang'])
             ->from('wiki')
             ->where($wikiQuery->expr()->eq('dbname', ':project'))
             // The meta database will have the project's URL stored as https://en.wikipedia.org
@@ -129,7 +129,7 @@ 
     public function allProjects()
     {
         $wikiQuery = $this->client->createQueryBuilder();
-        $wikiQuery->select([ 'dbName', 'name', 'url' ])->from('wiki');
+        $wikiQuery->select(['dbName', 'name', 'url'])->from('wiki');
         $stmt = $wikiQuery->execute();
         $out = $stmt->fetchAll();
         return $out;
@@ -152,7 +152,7 @@ 
         // as required by Labs.  We combine $table with
         // $table_extension in order to generate the new table name
         if ($this->isLabs() && $table_extension !== null) {
-            $table = $table . "_" . $table_extension;
+            $table = $table."_".$table_extension;
         }
 
         // Use the table specified in the table mapping configuration, if present.

tests/AppBundle/Controller/ApiControllerTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $this->assertEquals(200, $client->getResponse()->getStatusCode());
 
             // Check that a correct namespace value was returned
-            $namespaces = (array) json_decode($client->getResponse()->getContent());
+            $namespaces = (array)json_decode($client->getResponse()->getContent());
             $this->assertEquals('Utilisateur', array_values($namespaces)[2]); // User in French
         }
     }

app/autoload.php

Spacing +1 added lines, -1 removed lines

@@ -8,6 +8,6 @@
  */
 $loader = require __DIR__.'/../vendor/autoload.php';
 
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
 
 return $loader;

app/AppKernel.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
             new AppBundle\AppBundle(),
         ];
 
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +9 added lines, -9 removed lines

@@ -123,7 +123,7 @@ 
         $revTable = $lh->getTable('revision', $project->getDatabaseName());
         $pageTable = $lh->getTable('page', $project->getDatabaseName());
 
-        $AEBTypes = array_map(function ($AEBType) {
+        $AEBTypes = array_map(function($AEBType) {
             return $AEBType['regex'];
         }, $this->container->getParameter('automated_tools'));
 
@@ -148,12 +148,12 @@ 
         }
 
         // Get diff sizes, based on length of each parent revision
-        $parentRevIds = array_map(function ($edit) {
+        $parentRevIds = array_map(function($edit) {
             return $edit['rev_parent_id'];
         }, $editData);
         $query = "SELECT rev_len, rev_id
                   FROM revision
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
 
         // reformat with rev_id as the key, rev_len as the value
@@ -163,24 +163,24 @@ 
         }
 
         // Build our array of nonautomated edits
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
             $pageTitle = $edit['page_title'];
 
             if ($edit['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
             }
 
             $diffSize = $edit['rev_len'];
             if ($edit['rev_parent_id'] > 0) {
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
             }
 
             return [
                 'page_title' => $pageTitle,
-                'namespace' => (int) $edit['page_namespace'],
-                'rev_id' => (int) $edit['rev_id'],
+                'namespace' => (int)$edit['page_namespace'],
+                'rev_id' => (int)$edit['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
                 'summary' => $edit['rev_comment'],
                 'size' => $diffSize
             ];

src/AppBundle/Controller/AutomatedEditsController.php

Spacing +3 added lines, -3 removed lines

@@ -154,7 +154,7 @@ 
         $archiveTable = $lh->getTable('archive', $dbName);
 
         $condBegin = $start ? " AND rev_timestamp > :start " : null;
-        $condEnd = $end ? " AND rev_timestamp < :end ": null;
+        $condEnd = $end ? " AND rev_timestamp < :end " : null;
 
         $regexes = [];
 
@@ -248,8 +248,8 @@ 
         }
 
         // Sort the array and do some simple math.
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         if ($total != 0) {

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\User;
 

src/Xtools/EditCounterRepository.php

Spacing +9 added lines, -9 removed lines

@@ -19,7 +19,7 @@ 
     public function getRevisionCounts(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisioncounts.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisioncounts.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -80,7 +80,7 @@ 
     public function getRevisionDates(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisiondates.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisiondates.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -152,10 +152,10 @@ 
         $results = $resultQuery->fetchAll();
 
         $pageCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -186,7 +186,7 @@ 
 
         // Query.
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
-            FROM " . $this->getTableName($project->getDatabaseName(), 'logging') . "
+            FROM " . $this->getTableName($project->getDatabaseName(), 'logging')."
             WHERE log_user = :userId
             GROUP BY log_type, log_action";
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
@@ -195,10 +195,10 @@ 
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
         $logCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -355,9 +355,9 @@ 
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
             return $e['total'];
         }, $results));