Test Failed
Push — master ( 4f5fad...8200e7 )
by MusikAnimal
15:47
created
src/AppBundle/Repository/ArticleInfoRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfoRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $sql = "SELECT log_action, log_type, log_timestamp AS 'timestamp'
86 86
                 FROM $loggingTable
87
-                WHERE log_namespace = '" . $page->getNamespace() . "'
87
+                WHERE log_namespace = '".$page->getNamespace()."'
88 88
                 AND log_title = :title AND log_timestamp > 1 $datesConditions
89 89
                 AND log_type IN ('delete', 'move', 'protect', 'stable')";
90 90
         $title = str_replace(' ', '_', $page->getTitle());
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         $time2 = time();
266 266
 
267 267
         // If it took over 5 seconds, cache the result for 20 minutes.
268
-        if ($time2 - $time1 > 5) {
268
+        if ($time2-$time1 > 5) {
269 269
             $this->setCache($cacheKey, $result, 'PT20M');
270 270
         }
271 271
 
Please login to merge, or discard this patch.
src/AppBundle/Model/ArticleInfo.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfo class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     public function getMaxRevisions(): int
174 174
     {
175 175
         if (!isset($this->maxRevisions)) {
176
-            $this->maxRevisions = (int) $this->container->getParameter('app.max_page_revisions');
176
+            $this->maxRevisions = (int)$this->container->getParameter('app.max_page_revisions');
177 177
         }
178 178
         return $this->maxRevisions;
179 179
     }
@@ -792,7 +792,7 @@  discard block
 block discarded – undo
792 792
         $this->yearMonthCounts[$editYear]['all']++;
793 793
         $this->yearMonthCounts[$editYear]['months'][$editMonth]['all']++;
794 794
         // This will ultimately be the size of the page by the end of the year
795
-        $this->yearMonthCounts[$editYear]['size'] = (int) $edit->getLength();
795
+        $this->yearMonthCounts[$editYear]['size'] = (int)$edit->getLength();
796 796
 
797 797
         // Keep track of which month had the most edits
798 798
         $editsThisMonth = $this->yearMonthCounts[$editYear]['months'][$editMonth]['all'];
@@ -1003,7 +1003,7 @@  discard block
 block discarded – undo
1003 1003
 
1004 1004
             if ($info['all'] > 1) {
1005 1005
                 // Number of seconds/days between first and last edit.
1006
-                $secs = $info['last']->getTimestamp() - $info['first']->getTimestamp();
1006
+                $secs = $info['last']->getTimestamp()-$info['first']->getTimestamp();
1007 1007
                 $days = $secs / (60 * 60 * 24);
1008 1008
 
1009 1009
                 // Average time between edits (in days).
@@ -1012,7 +1012,7 @@  discard block
 block discarded – undo
1012 1012
         }
1013 1013
 
1014 1014
         // Loop through again and add percentages.
1015
-        $this->topTenEditorsByEdits = array_map(function ($editor) use ($topTenCount) {
1015
+        $this->topTenEditorsByEdits = array_map(function($editor) use ($topTenCount) {
1016 1016
             $editor['percentage'] = 100 * ($editor['value'] / $topTenCount);
1017 1017
             return $editor;
1018 1018
         }, $topTenEditorsByEdits);
@@ -1030,7 +1030,7 @@  discard block
 block discarded – undo
1030 1030
     {
1031 1031
         // First sort editors array by the amount of text they added.
1032 1032
         $topTenEditorsByAdded = $this->editors;
1033
-        uasort($topTenEditorsByAdded, function ($a, $b) {
1033
+        uasort($topTenEditorsByAdded, function($a, $b) {
1034 1034
             if ($a['added'] === $b['added']) {
1035 1035
                 return 0;
1036 1036
             }
@@ -1041,12 +1041,12 @@  discard block
 block discarded – undo
1041 1041
         $topTenEditorsByAdded = array_keys(array_slice($topTenEditorsByAdded, 0, 10, true));
1042 1042
 
1043 1043
          // Get the sum of added text so that we can add in percentages.
1044
-         $topTenTotalAdded = array_sum(array_map(function ($editor) {
1044
+         $topTenTotalAdded = array_sum(array_map(function($editor) {
1045 1045
              return $this->editors[$editor]['added'];
1046 1046
          }, $topTenEditorsByAdded));
1047 1047
 
1048 1048
         // Then build a new array of top 10 editors by added text in the data structure needed for the chart.
1049
-        return array_map(function ($editor) use ($topTenTotalAdded) {
1049
+        return array_map(function($editor) use ($topTenTotalAdded) {
1050 1050
             $added = $this->editors[$editor]['added'];
1051 1051
             return [
1052 1052
                 'label' => $editor,
Please login to merge, or discard this patch.
src/AppBundle/Controller/TopEditsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
         // Send all to the template.
167 167
         return $this->getFormattedResponse('topedits/result_article', [
168 168
             'xtPage' => 'TopEdits',
169
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->page->getTitle(),
169
+            'xtTitle' => $this->user->getUsername().' - '.$this->page->getTitle(),
170 170
             'te' => $topEdits,
171 171
         ]);
172 172
     }
Please login to merge, or discard this patch.
src/AppBundle/EventSubscriber/RateLimitSubscriber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the RateLimitSubscriber class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\EventSubscriber;
9 9
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $cacheItem = $this->cache->getItem($cacheKey);
125 125
 
126 126
         // If increment value already in cache, or start with 1.
127
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
127
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
128 128
 
129 129
         // Check if limit has been exceeded, and if so, throw an error.
130 130
         if ($count > $this->rateLimit) {
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $cacheItem = $this->cache->getItem($cacheKey);
165 165
 
166 166
         // If increment value already in cache, or start with 1.
167
-        $count = $cacheItem->isHit() ? (int)$cacheItem->get() + 1 : 1;
167
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
168 168
 
169 169
         // Check if limit has been exceeded, and if so, add a log entry.
170 170
         if ($count > 3) {
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
         $message = $this->i18n->msg('error-rate-limit', [
240 240
             $this->rateDuration,
241 241
             "<a href='/login'>".$this->i18n->msg('error-rate-limit-login')."</a>",
242
-            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>" .
243
-                $this->i18n->msg('api') .
242
+            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>".
243
+                $this->i18n->msg('api').
244 244
             "</a>",
245 245
         ]);
246 246
 
Please login to merge, or discard this patch.
src/AppBundle/Controller/ArticleInfoController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
             $rendered = str_replace('"', '\"', trim($rendered));
104 104
 
105 105
             // Uglify temporary file.
106
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
106
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
107 107
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
108 108
             $script .= $this->get('kernel')->getProjectDir().
109
-                "/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
109
+                "/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
110 110
                 "&& rm $tmpFile >/dev/null";
111 111
             $process = new Process([$script]);
112 112
             $process->run();
@@ -124,10 +124,10 @@  discard block
 block discarded – undo
124 124
             $rendered = str_replace('\"', '"', trim($rendered));
125 125
 
126 126
             // Add comment after uglifying since it removes comments.
127
-            $rendered = "/**\n * This code was automatically generated and should not " .
128
-                "be manually edited.\n * For updates, please copy and paste from " .
129
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
130
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
127
+            $rendered = "/**\n * This code was automatically generated and should not ".
128
+                "be manually edited.\n * For updates, please copy and paste from ".
129
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
130
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
131 131
         }
132 132
 
133 133
         $response = new Response($rendered);
Please login to merge, or discard this patch.
src/AppBundle/Model/Edit.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Edit class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public static function getEditsFromRevs(Project $project, User $user, array $revs): array
88 88
     {
89
-        return array_map(function ($rev) use ($project, $user) {
89
+        return array_map(function($rev) use ($project, $user) {
90 90
             /** @var Page $page Page object to be passed to the Edit constructor. */
91 91
             $page = Page::newFromRev($project, $rev);
92 92
             $rev['user'] = $user;
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
300 300
 
301 301
         if ($isSection && isset($page)) {
302
-            $pageUrl = $project->getUrl(false) . str_replace(
302
+            $pageUrl = $project->getUrl(false).str_replace(
303 303
                 '$1',
304 304
                 $page->getTitle($useUnnormalizedPageTitle),
305 305
                 $project->getArticlePath()
@@ -309,8 +309,8 @@  discard block
 block discarded – undo
309 309
             // Must have underscores for the link to properly go to the section.
310 310
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
311 311
 
312
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
313
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
312
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
313
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
314 314
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
315 315
         }
316 316
 
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
             );
325 325
 
326 326
             // Use normalized page title (underscored, capitalized).
327
-            $pageUrl = $project->getUrl(false) . str_replace(
327
+            $pageUrl = $project->getUrl(false).str_replace(
328 328
                 '$1',
329 329
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
330 330
                 $project->getArticlePath()
@@ -362,8 +362,8 @@  discard block
 block discarded – undo
362 362
     public function getDiffUrl(): string
363 363
     {
364 364
         $project = $this->getProject();
365
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
366
-        return rtrim($project->getUrl(), '/') . $path;
365
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
366
+        return rtrim($project->getUrl(), '/').$path;
367 367
     }
368 368
 
369 369
     /**
@@ -373,8 +373,8 @@  discard block
 block discarded – undo
373 373
     public function getPermaUrl(): string
374 374
     {
375 375
         $project = $this->getProject();
376
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
377
-        return rtrim($project->getUrl(), '/') . $path;
376
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
377
+        return rtrim($project->getUrl(), '/').$path;
378 378
     }
379 379
 
380 380
     /**
Please login to merge, or discard this patch.
src/AppBundle/Model/AutoEdits.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AutoEdits class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -225,8 +225,8 @@  discard block
 block discarded – undo
225 225
     public function getToolsTotal(): int
226 226
     {
227 227
         if (!is_int($this->toolsTotal)) {
228
-            $this->toolsTotal = array_reduce($this->getToolCounts(), function ($a, $b) {
229
-                return $a + $b['count'];
228
+            $this->toolsTotal = array_reduce($this->getToolCounts(), function($a, $b) {
229
+                return $a+$b['count'];
230 230
             });
231 231
         }
232 232
 
Please login to merge, or discard this patch.
src/AppBundle/Twig/AppExtension.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AppExtension class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Twig;
9 9
 
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     public function requestTime(): float
113 113
     {
114 114
         if (!isset($this->requestTime)) {
115
-            $this->requestTime = microtime(true) - $this->getRequest()->server->get('REQUEST_TIME_FLOAT');
115
+            $this->requestTime = microtime(true)-$this->getRequest()->server->get('REQUEST_TIME_FLOAT');
116 116
         }
117 117
 
118 118
         return $this->requestTime;
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
         }
552 552
 
553 553
         $sizeMessage = $this->numberFormat(
554
-            pow(1024, $base - floor($base)),
554
+            pow(1024, $base-floor($base)),
555 555
             $precision
556 556
         );
557 557
 
@@ -708,15 +708,15 @@  discard block
 block discarded – undo
708 708
 
709 709
         if ($seconds >= 86400) {
710 710
             // Over a day
711
-            $val = (int) floor($seconds / 86400);
711
+            $val = (int)floor($seconds / 86400);
712 712
             $key = 'days';
713 713
         } elseif ($seconds >= 3600) {
714 714
             // Over an hour, less than a day
715
-            $val = (int) floor($seconds / 3600);
715
+            $val = (int)floor($seconds / 3600);
716 716
             $key = 'hours';
717 717
         } elseif ($seconds >= 60) {
718 718
             // Over a minute, less than an hour
719
-            $val = (int) floor($seconds / 60);
719
+            $val = (int)floor($seconds / 60);
720 720
             $key = 'minutes';
721 721
         }
722 722
 
Please login to merge, or discard this patch.
src/AppBundle/Model/Page.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Page class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $title = $info['title'] ?? $this->unnormalizedPageName;
114 114
         $nsName = $this->getNamespaceName();
115 115
         return $nsName
116
-            ? str_replace($nsName . ':', '', $title)
116
+            ? str_replace($nsName.':', '', $title)
117 117
             : $title;
118 118
     }
119 119
 
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
     {
313 313
         $content = $this->getRepository()->getPagesWikitext(
314 314
             $this->getProject(),
315
-            [ $this->getTitle() ]
315
+            [$this->getTitle()]
316 316
         );
317 317
 
318 318
         return $content[$this->getTitle()] ?? null;
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
380 380
 
381
-        $terms = array_map(function ($entry) {
381
+        $terms = array_map(function($entry) {
382 382
             return $entry['term'];
383 383
         }, $wikidataInfo);
384 384
 
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
                 'prio' => 2,
390 390
                 'name' => 'Wikidata',
391 391
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
392
-                'explanation' => "See: <a target='_blank' " .
392
+                'explanation' => "See: <a target='_blank' ".
393 393
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
394 394
             ];
395 395
         }
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
                 'prio' => 3,
400 400
                 'name' => 'Wikidata',
401 401
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
402
-                'explanation' => "See: <a target='_blank' " .
402
+                'explanation' => "See: <a target='_blank' ".
403 403
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
404 404
             ];
405 405
         }
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
             return 0;
478 478
         }
479 479
 
480
-        return array_sum(array_map(function ($item) {
480
+        return array_sum(array_map(function($item) {
481 481
             return (int)$item['views'];
482 482
         }, $pageviews['items']));
483 483
     }
Please login to merge, or discard this patch.