Test Failed
Pull Request — master (#378)
by MusikAnimal
08:42
created
src/AppBundle/Model/Page.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Page class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
         $title = $info['title'] ?? $this->unnormalizedPageName;
114 114
         $nsName = $this->getNamespaceName();
115 115
         return $nsName
116
-            ? str_replace($nsName . ':', '', $title)
116
+            ? str_replace($nsName.':', '', $title)
117 117
             : $title;
118 118
     }
119 119
 
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
     {
313 313
         $content = $this->getRepository()->getPagesWikitext(
314 314
             $this->getProject(),
315
-            [ $this->getTitle() ]
315
+            [$this->getTitle()]
316 316
         );
317 317
 
318 318
         return $content[$this->getTitle()] ?? null;
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
378 378
 
379 379
         $wikidataInfo = $this->getRepository()->getWikidataInfo($this);
380 380
 
381
-        $terms = array_map(function ($entry) {
381
+        $terms = array_map(function($entry) {
382 382
             return $entry['term'];
383 383
         }, $wikidataInfo);
384 384
 
@@ -389,7 +389,7 @@  discard block
 block discarded – undo
389 389
                 'prio' => 2,
390 390
                 'name' => 'Wikidata',
391 391
                 'notice' => "Label for language <em>$lang</em> is missing", // FIXME: i18n
392
-                'explanation' => "See: <a target='_blank' " .
392
+                'explanation' => "See: <a target='_blank' ".
393 393
                     "href='//www.wikidata.org/wiki/Help:Label'>Help:Label</a>",
394 394
             ];
395 395
         }
@@ -399,7 +399,7 @@  discard block
 block discarded – undo
399 399
                 'prio' => 3,
400 400
                 'name' => 'Wikidata',
401 401
                 'notice' => "Description for language <em>$lang</em> is missing", // FIXME: i18n
402
-                'explanation' => "See: <a target='_blank' " .
402
+                'explanation' => "See: <a target='_blank' ".
403 403
                     "href='//www.wikidata.org/wiki/Help:Description'>Help:Description</a>",
404 404
             ];
405 405
         }
@@ -477,7 +477,7 @@  discard block
 block discarded – undo
477 477
             return 0;
478 478
         }
479 479
 
480
-        return array_sum(array_map(function ($item) {
480
+        return array_sum(array_map(function($item) {
481 481
             return (int)$item['views'];
482 482
         }, $pageviews['items']));
483 483
     }
Please login to merge, or discard this patch.
src/AppBundle/Helper/AutomatedEditsHelper.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AutomatedEditsHelper class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Helper;
9 9
 
@@ -85,8 +85,8 @@  discard block
 block discarded – undo
85 85
         }
86 86
 
87 87
         $session = $this->container->get('session');
88
-        $uri = 'https://meta.wikimedia.org/w/index.php?action=raw&ctype=application/json&title=' .
89
-            'MediaWiki:XTools-AutoEdits.json' . ($useSandbox ? '/sandbox' : '');
88
+        $uri = 'https://meta.wikimedia.org/w/index.php?action=raw&ctype=application/json&title='.
89
+            'MediaWiki:XTools-AutoEdits.json'.($useSandbox ? '/sandbox' : '');
90 90
 
91 91
         if ($useSandbox && $session->get('logged_in_user')) {
92 92
             // Request via OAuth to get around server-side caching.
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 
150 150
         // Once last walk through for some tidying up and validation.
151 151
         $invalid = [];
152
-        array_walk($this->tools[$projectDomain], function (&$data, $tool) use (&$invalid): void {
152
+        array_walk($this->tools[$projectDomain], function(&$data, $tool) use (&$invalid): void {
153 153
             // Populate the 'label' with the tool name, if a label doesn't already exist.
154 154
             $data['label'] = $data['label'] ?? $tool;
155 155
 
@@ -233,14 +233,14 @@  discard block
 block discarded – undo
233 233
 
234 234
         $revertEntries = array_filter(
235 235
             $this->getTools($project),
236
-            function ($tool) {
236
+            function($tool) {
237 237
                 return isset($tool['revert']) && isset($tool['regex']);
238 238
             }
239 239
         );
240 240
 
241 241
         // If 'revert' is set to `true`, then use 'regex' as the regular expression,
242 242
         //  otherwise 'revert' is assumed to be the regex string.
243
-        $this->revertTools[$projectDomain] = array_map(function ($revertTool) {
243
+        $this->revertTools[$projectDomain] = array_map(function($revertTool) {
244 244
             return [
245 245
                 'link' => $revertTool['link'],
246 246
                 'regex' => true === $revertTool['revert'] ? $revertTool['regex'] : $revertTool['revert'],
Please login to merge, or discard this patch.
public/app_dev.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 use Symfony\Component\ErrorHandler\Debug;
5 5
 use Symfony\Component\HttpFoundation\Request;
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 // Feel free to remove this, extend it, or make something more sophisticated.
14 14
 if (isset($_SERVER['HTTP_CLIENT_IP'])
15 15
     || isset($_SERVER['HTTP_X_FORWARDED_FOR'])
16
-    || !( in_array(@$_SERVER['REMOTE_ADDR'], [ '127.0.0.1', 'fe80::1', '::1' ]) || 'cli-server' === php_sapi_name() )
16
+    || !(in_array(@$_SERVER['REMOTE_ADDR'], ['127.0.0.1', 'fe80::1', '::1']) || 'cli-server' === php_sapi_name())
17 17
 ) {
18 18
     header('HTTP/1.0 403 Forbidden');
19 19
     exit('You are not allowed to access this file. Check '.basename(__FILE__).' for more information.');
Please login to merge, or discard this patch.
src/AppBundle/Model/ArticleInfoApi.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Model;
5 5
 
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 
167 167
         $refs = $crawler->filter('#mw-content-text .reference');
168 168
         $refContent = [];
169
-        $refs->each(function ($ref) use (&$refContent): void {
169
+        $refs->each(function($ref) use (&$refContent): void {
170 170
             $refContent[] = $ref->text();
171 171
         });
172 172
         $uniqueRefs = count(array_unique($refContent));
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
         $totalChars = 0;
195 195
         $totalWords = 0;
196 196
         $paragraphs = $crawler->filter($selector);
197
-        $paragraphs->each(function ($node) use (&$totalChars, &$totalWords): void {
197
+        $paragraphs->each(function($node) use (&$totalChars, &$totalWords): void {
198 198
             /** @var Crawler $node */
199 199
             $text = preg_replace('/\[\d+]/', '', trim($node->text(null, true)));
200 200
             $totalChars += strlen($text);
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
         $data = [
259 259
             'project' => $project->getDomain(),
260 260
             'page' => $page->getTitle(),
261
-            'watchers' => (int) $page->getWatchers(),
261
+            'watchers' => (int)$page->getWatchers(),
262 262
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
263 263
             'pageviews_offset' => $pageviewsOffset,
264 264
         ];
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
         if (false !== $info) {
284 284
             $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
285 285
             $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
286
-            $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
286
+            $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
287 287
 
288 288
             // Some wikis (such foundation.wikimedia.org) may be missing the creation date.
289 289
             $creationDateTime = false === $creationDateTime
@@ -295,16 +295,16 @@  discard block
 block discarded – undo
295 295
                 ->getAssessment($page);
296 296
 
297 297
             $data = array_merge($data, [
298
-                'revisions' => (int) $info['num_edits'],
299
-                'editors' => (int) $info['num_editors'],
300
-                'minor_edits' => (int) $info['minor_edits'],
298
+                'revisions' => (int)$info['num_edits'],
299
+                'editors' => (int)$info['num_editors'],
300
+                'minor_edits' => (int)$info['minor_edits'],
301 301
                 'author' => $info['author'],
302
-                'author_editcount' => (int) $info['author_editcount'],
302
+                'author_editcount' => (int)$info['author_editcount'],
303 303
                 'created_at' => $creationDateTime,
304 304
                 'created_rev_id' => $info['created_rev_id'],
305 305
                 'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
306 306
                 'secs_since_last_edit' => $secsSinceLastEdit,
307
-                'last_edit_id' => (int) $info['modified_rev_id'],
307
+                'last_edit_id' => (int)$info['modified_rev_id'],
308 308
                 'assessment' => $assessment,
309 309
             ]);
310 310
         }
@@ -454,8 +454,8 @@  discard block
 block discarded – undo
454 454
         }
455 455
 
456 456
         // Sort by edit count.
457
-        uasort($this->bots, function ($a, $b) {
458
-            return $b['count'] - $a['count'];
457
+        uasort($this->bots, function($a, $b) {
458
+            return $b['count']-$a['count'];
459 459
         });
460 460
 
461 461
         return $this->bots;
Please login to merge, or discard this patch.
src/AppBundle/Repository/EditCounterRepository.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the EditCounterRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -119,10 +119,10 @@  discard block
 block discarded – undo
119 119
         ])->fetchAll();
120 120
 
121 121
         $logCounts = array_combine(
122
-            array_map(function ($e) {
122
+            array_map(function($e) {
123 123
                 return $e['source'];
124 124
             }, $results),
125
-            array_map(function ($e) {
125
+            array_map(function($e) {
126 126
                 return (int)$e['value'];
127 127
             }, $results)
128 128
         );
@@ -200,10 +200,10 @@  discard block
 block discarded – undo
200 200
         }
201 201
 
202 202
         $counts = array_combine(
203
-            array_map(function ($e) {
203
+            array_map(function($e) {
204 204
                 return $e['key'];
205 205
             }, $results),
206
-            array_map(function ($e) {
206
+            array_map(function($e) {
207 207
                 return (int)$e['val'];
208 208
             }, $results)
209 209
         );
@@ -335,9 +335,9 @@  discard block
 block discarded – undo
335 335
             'actorId' => $user->getActorId($project),
336 336
         ])->fetchAll();
337 337
 
338
-        $namespaceTotals = array_combine(array_map(function ($e) {
338
+        $namespaceTotals = array_combine(array_map(function($e) {
339 339
             return $e['page_namespace'];
340
-        }, $results), array_map(function ($e) {
340
+        }, $results), array_map(function($e) {
341 341
             return (int)$e['total'];
342 342
         }, $results));
343 343
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/AutoEditsRepository.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AutoEditsRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
         if ('all' !== $namespace) {
55 55
             // Limit by namespace.
56
-            return array_filter($this->aeTools, function (array $tool) use ($namespace) {
56
+            return array_filter($this->aeTools, function(array $tool) use ($namespace) {
57 57
                 return empty($tool['namespaces']) ||
58 58
                     in_array((int)$namespace, $tool['namespaces']) ||
59 59
                     (
@@ -134,7 +134,7 @@  discard block
 block discarded – undo
134 134
             $tagJoin = "LEFT OUTER JOIN $tagTable ON ct_rev_id = rev_id";
135 135
             $condTools[] = "ct_tag_id IN ($tagIds)";
136 136
         }
137
-        $condTool = 'AND (' . implode(' OR ', $condTools) . ')';
137
+        $condTool = 'AND ('.implode(' OR ', $condTools).')';
138 138
 
139 139
         $sql = "SELECT COUNT(DISTINCT(rev_id))
140 140
                 FROM $revisionTable
@@ -349,8 +349,8 @@  discard block
 block discarded – undo
349 349
         }
350 350
 
351 351
         // Sort the array by count
352
-        uasort($results, function ($a, $b) {
353
-            return $b['count'] - $a['count'];
352
+        uasort($results, function($a, $b) {
353
+            return $b['count']-$a['count'];
354 354
         });
355 355
 
356 356
         // Cache and return.
@@ -526,7 +526,7 @@  discard block
 block discarded – undo
526 526
             if (isset($values['tags'])) {
527 527
                 $tags = array_merge(
528 528
                     $tags,
529
-                    array_map(function ($tag) use ($conn) {
529
+                    array_map(function($tag) use ($conn) {
530 530
                         return $conn->quote($tag, PDO::PARAM_STR);
531 531
                     }, $values['tags'])
532 532
                 );
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
 
563 563
         if ($tagExcludes && 1 === count($tagIds)) {
564 564
             // Get tag IDs, filtering out those for which no ID exists (meaning there is no local tag for that tool).
565
-            $excludesList = implode(',', array_filter(array_map(function ($tagName) use ($project) {
565
+            $excludesList = implode(',', array_filter(array_map(function($tagName) use ($project) {
566 566
                 return $this->getTags($project)[$tagName] ?? null;
567 567
             }, $tagExcludes)));
568 568
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/UserRightsRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the UserRightsRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
             return $this->cache->getItem($cacheKey)->get();
118 118
         }
119 119
 
120
-        $rightsPaths = array_map(function ($right) {
120
+        $rightsPaths = array_map(function($right) {
121 121
             return "Group-$right-member";
122 122
         }, $this->getRawRightsNames($project));
123 123
 
@@ -260,7 +260,7 @@  discard block
 block discarded – undo
260 260
                 FROM $revisionTable
261 261
                 WHERE rev_actor = :actorId
262 262
                 AND rev_timestamp >= $offset
263
-                LIMIT 1 OFFSET ".($edits - 1);
263
+                LIMIT 1 OFFSET ".($edits-1);
264 264
 
265 265
         $ret = $this->executeProjectsQuery($project, $sql, [
266 266
             'actorId' => $user->getActorId($project),
Please login to merge, or discard this patch.
src/AppBundle/Repository/GlobalContribsRepository.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Repository;
5 5
 
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
             $slice = $this->getDbList()[$dbName];
166 166
             // actor_revision table only includes users who have made at least one edit.
167 167
             $actorTable = $this->getTableName($dbName, 'actor', 'revision');
168
-            $queriesBySlice[$slice][] = "SELECT '$dbName' AS `dbName`, actor_id " .
168
+            $queriesBySlice[$slice][] = "SELECT '$dbName' AS `dbName`, actor_id ".
169 169
                 "FROM $actorTable WHERE actor_name = :actor";
170 170
         }
171 171
 
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
         // Re-assemble into UNIONed queries, executing as many per slice as possible.
263 263
         $revisions = [];
264 264
         foreach ($queriesBySlice as $slice => $queries) {
265
-            $sql = "SELECT * FROM ((\n" . join("\n) UNION (\n", $queries) . ")) a ORDER BY timestamp DESC LIMIT $limit";
265
+            $sql = "SELECT * FROM ((\n".join("\n) UNION (\n", $queries).")) a ORDER BY timestamp DESC LIMIT $limit";
266 266
             $revisions = array_merge($revisions, $this->executeProjectsQuery($slice, $sql)->fetchAll());
267 267
         }
268 268
 
269 269
         // If there are more than $limit results, re-sort by timestamp.
270 270
         if (count($revisions) > $limit) {
271
-            usort($revisions, function ($a, $b) {
271
+            usort($revisions, function($a, $b) {
272 272
                 if ($a['unix_timestamp'] === $b['unix_timestamp']) {
273 273
                     return 0;
274 274
                 }
Please login to merge, or discard this patch.
src/AppBundle/Model/GlobalContribs.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Model;
5 5
 
@@ -102,8 +102,8 @@  discard block
 block discarded – undo
102 102
 
103 103
         if ($sorted) {
104 104
             // Sort.
105
-            uasort($this->globalEditCounts, function ($a, $b) {
106
-                return $b['total'] - $a['total'];
105
+            uasort($this->globalEditCounts, function($a, $b) {
106
+                return $b['total']-$a['total'];
107 107
             });
108 108
         }
109 109
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
             $this->namespace,
141 141
             $this->start,
142 142
             $this->end,
143
-            self::PAGE_SIZE + 1,
143
+            self::PAGE_SIZE+1,
144 144
             $this->offset
145 145
         );
146 146
         $globalEdits = [];
Please login to merge, or discard this patch.