Test Failed
Pull Request — master (#378)
by MusikAnimal
08:42
created
src/AppBundle/Model/Blame.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Model;
5 5
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/PageRepository.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the PageRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
 
307 307
         $wikidataId = ltrim($page->getWikidataId(), 'Q');
308 308
 
309
-        $sql = "SELECT " . ($count ? 'COUNT(*) AS count' : '*') . "
309
+        $sql = "SELECT ".($count ? 'COUNT(*) AS count' : '*')."
310 310
                 FROM wikidatawiki_p.wb_items_per_site
311 311
                 WHERE ips_item_id = :wikidataId";
312 312
 
@@ -314,7 +314,7 @@  discard block
 block discarded – undo
314 314
             'wikidataId' => $wikidataId,
315 315
         ])->fetchAll();
316 316
 
317
-        return $count ? (int) $result[0]['count'] : $result;
317
+        return $count ? (int)$result[0]['count'] : $result;
318 318
     }
319 319
 
320 320
     /**
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
 
353 353
         // Transform to associative array by 'type'
354 354
         foreach ($res as $row) {
355
-            $data[$row['type'] . '_count'] = (int)$row['value'];
355
+            $data[$row['type'].'_count'] = (int)$row['value'];
356 356
         }
357 357
 
358 358
         return $data;
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 
397 397
         $project = $page->getProject()->getDomain();
398 398
 
399
-        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/' .
399
+        $url = 'https://wikimedia.org/api/rest_v1/metrics/pageviews/per-article/'.
400 400
             "$project/all-access/user/$title/daily/$start/$end";
401 401
 
402 402
         $res = $client->request('GET', $url);
@@ -471,7 +471,7 @@  discard block
 block discarded – undo
471 471
             $normalized = [];
472 472
             if (isset($result['query']['normalized'])) {
473 473
                 array_map(
474
-                    function ($e) use (&$normalized): void {
474
+                    function($e) use (&$normalized): void {
475 475
                         $normalized[$e['to']] = $e['from'];
476 476
                     },
477 477
                     $result['query']['normalized']
Please login to merge, or discard this patch.
src/AppBundle/Repository/ArticleInfoRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the ArticleInfoRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $sql = "SELECT log_action, log_type, log_timestamp AS 'timestamp'
86 86
                 FROM $loggingTable
87
-                WHERE log_namespace = '" . $page->getNamespace() . "'
87
+                WHERE log_namespace = '".$page->getNamespace()."'
88 88
                 AND log_title = :title AND log_timestamp > 1 $datesConditions
89 89
                 AND log_type IN ('delete', 'move', 'protect', 'stable')";
90 90
         $title = str_replace(' ', '_', $page->getTitle());
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         $time2 = time();
266 266
 
267 267
         // If it took over 5 seconds, cache the result for 20 minutes.
268
-        if ($time2 - $time1 > 5) {
268
+        if ($time2-$time1 > 5) {
269 269
             $this->setCache($cacheKey, $result, 'PT20M');
270 270
         }
271 271
 
Please login to merge, or discard this patch.
src/AppBundle/Controller/TopEditsController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -166,7 +166,7 @@
 block discarded – undo
166 166
         // Send all to the template.
167 167
         return $this->getFormattedResponse('topedits/result_article', [
168 168
             'xtPage' => 'TopEdits',
169
-            'xtTitle' => $this->user->getUsername() . ' - ' . $this->page->getTitle(),
169
+            'xtTitle' => $this->user->getUsername().' - '.$this->page->getTitle(),
170 170
             'te' => $topEdits,
171 171
         ]);
172 172
     }
Please login to merge, or discard this patch.
src/AppBundle/EventSubscriber/RateLimitSubscriber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the RateLimitSubscriber class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\EventSubscriber;
9 9
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $cacheItem = $this->cache->getItem($cacheKey);
125 125
 
126 126
         // If increment value already in cache, or start with 1.
127
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
127
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
128 128
 
129 129
         // Check if limit has been exceeded, and if so, throw an error.
130 130
         if ($count > $this->rateLimit) {
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
         $cacheItem = $this->cache->getItem($cacheKey);
165 165
 
166 166
         // If increment value already in cache, or start with 1.
167
-        $count = $cacheItem->isHit() ? (int)$cacheItem->get() + 1 : 1;
167
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
168 168
 
169 169
         // Check if limit has been exceeded, and if so, add a log entry.
170 170
         if ($count > 3) {
@@ -239,8 +239,8 @@  discard block
 block discarded – undo
239 239
         $message = $this->i18n->msg('error-rate-limit', [
240 240
             $this->rateDuration,
241 241
             "<a href='/login'>".$this->i18n->msg('error-rate-limit-login')."</a>",
242
-            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>" .
243
-                $this->i18n->msg('api') .
242
+            "<a href='https://xtools.readthedocs.io/en/stable/api' target='_blank'>".
243
+                $this->i18n->msg('api').
244 244
             "</a>",
245 245
         ]);
246 246
 
Please login to merge, or discard this patch.
src/AppBundle/Controller/ArticleInfoController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -103,10 +103,10 @@  discard block
 block discarded – undo
103 103
             $rendered = str_replace('"', '\"', trim($rendered));
104 104
 
105 105
             // Uglify temporary file.
106
-            $tmpFile = sys_get_temp_dir() . '/xtools_articleinfo_gadget.js';
106
+            $tmpFile = sys_get_temp_dir().'/xtools_articleinfo_gadget.js';
107 107
             $script = "echo \"$rendered\" | tee $tmpFile >/dev/null && ";
108 108
             $script .= $this->get('kernel')->getProjectDir().
109
-                "/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle " .
109
+                "/node_modules/uglify-es/bin/uglifyjs $tmpFile --mangle ".
110 110
                 "&& rm $tmpFile >/dev/null";
111 111
             $process = new Process([$script]);
112 112
             $process->run();
@@ -124,10 +124,10 @@  discard block
 block discarded – undo
124 124
             $rendered = str_replace('\"', '"', trim($rendered));
125 125
 
126 126
             // Add comment after uglifying since it removes comments.
127
-            $rendered = "/**\n * This code was automatically generated and should not " .
128
-                "be manually edited.\n * For updates, please copy and paste from " .
129
-                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL) .
130
-                "\n * Released under GPL v3 license.\n */\n" . $rendered;
127
+            $rendered = "/**\n * This code was automatically generated and should not ".
128
+                "be manually edited.\n * For updates, please copy and paste from ".
129
+                $this->generateUrl('ArticleInfoGadget', ['uglify' => 1], UrlGeneratorInterface::ABSOLUTE_URL).
130
+                "\n * Released under GPL v3 license.\n */\n".$rendered;
131 131
         }
132 132
 
133 133
         $response = new Response($rendered);
Please login to merge, or discard this patch.
src/AppBundle/Model/Edit.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the Edit class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public static function getEditsFromRevs(Project $project, User $user, array $revs): array
88 88
     {
89
-        return array_map(function ($rev) use ($project, $user) {
89
+        return array_map(function($rev) use ($project, $user) {
90 90
             /** @var Page $page Page object to be passed to the Edit constructor. */
91 91
             $page = Page::newFromRev($project, $rev);
92 92
             $rev['user'] = $user;
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
         $isSection = preg_match_all("/^\/\* (.*?) \*\//", $summary, $sectionMatch);
300 300
 
301 301
         if ($isSection && isset($page)) {
302
-            $pageUrl = $project->getUrl(false) . str_replace(
302
+            $pageUrl = $project->getUrl(false).str_replace(
303 303
                 '$1',
304 304
                 $page->getTitle($useUnnormalizedPageTitle),
305 305
                 $project->getArticlePath()
@@ -309,8 +309,8 @@  discard block
 block discarded – undo
309 309
             // Must have underscores for the link to properly go to the section.
310 310
             $sectionTitleLink = htmlspecialchars(str_replace(' ', '_', $sectionTitle));
311 311
 
312
-            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>" .
313
-                "<em class='text-muted'>" . htmlspecialchars($sectionTitle) . ":</em> ";
312
+            $sectionWikitext = "<a target='_blank' href='$pageUrl#$sectionTitleLink'>&rarr;</a>".
313
+                "<em class='text-muted'>".htmlspecialchars($sectionTitle).":</em> ";
314 314
             $summary = str_replace($sectionMatch[0][0], $sectionWikitext, $summary);
315 315
         }
316 316
 
@@ -324,7 +324,7 @@  discard block
 block discarded – undo
324 324
             );
325 325
 
326 326
             // Use normalized page title (underscored, capitalized).
327
-            $pageUrl = $project->getUrl(false) . str_replace(
327
+            $pageUrl = $project->getUrl(false).str_replace(
328 328
                 '$1',
329 329
                 ucfirst(str_replace(' ', '_', $wikiLinkPath)),
330 330
                 $project->getArticlePath()
@@ -362,8 +362,8 @@  discard block
 block discarded – undo
362 362
     public function getDiffUrl(): string
363 363
     {
364 364
         $project = $this->getProject();
365
-        $path = str_replace('$1', 'Special:Diff/' . $this->id, $project->getArticlePath());
366
-        return rtrim($project->getUrl(), '/') . $path;
365
+        $path = str_replace('$1', 'Special:Diff/'.$this->id, $project->getArticlePath());
366
+        return rtrim($project->getUrl(), '/').$path;
367 367
     }
368 368
 
369 369
     /**
@@ -373,8 +373,8 @@  discard block
 block discarded – undo
373 373
     public function getPermaUrl(): string
374 374
     {
375 375
         $project = $this->getProject();
376
-        $path = str_replace('$1', 'Special:PermaLink/' . $this->id, $project->getArticlePath());
377
-        return rtrim($project->getUrl(), '/') . $path;
376
+        $path = str_replace('$1', 'Special:PermaLink/'.$this->id, $project->getArticlePath());
377
+        return rtrim($project->getUrl(), '/').$path;
378 378
     }
379 379
 
380 380
     /**
Please login to merge, or discard this patch.
src/AppBundle/Model/AdminStats.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AdminStats class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
         $stats = $this->groupStatsByUsername($stats);
97 97
 
98 98
         // Resort, as for some reason the SQL doesn't do this properly.
99
-        uasort($stats, function ($a, $b) {
99
+        uasort($stats, function($a, $b) {
100 100
             if ($a['total'] === $b['total']) {
101 101
                 return 0;
102 102
             }
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
         $this->usersAndGroups = $this->project->getUsersInGroups($groupUserGroups['local'], $groupUserGroups['global']);
128 128
 
129 129
         // Populate $this->usersInGroup with users who are in the relevant user group for $this->group.
130
-        $this->usersInGroup = array_keys(array_filter($this->usersAndGroups, function ($groups) {
130
+        $this->usersInGroup = array_keys(array_filter($this->usersAndGroups, function($groups) {
131 131
             return in_array($this->getRelevantUserGroup(), $groups);
132 132
         }));
133 133
 
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         }
151 151
 
152 152
         if ($wikiPath) {
153
-            $out = array_map(function ($url) {
153
+            $out = array_map(function($url) {
154 154
                 return str_replace('.svg.png', '.svg', preg_replace('/.*\/18px-/', '', $url));
155 155
             }, $out);
156 156
         }
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     public function numDays(): int
166 166
     {
167
-        return (int)(($this->end - $this->start) / 60 / 60 / 24);
167
+        return (int)(($this->end-$this->start) / 60 / 60 / 24);
168 168
     }
169 169
 
170 170
     /**
@@ -254,6 +254,6 @@  discard block
 block discarded – undo
254 254
      */
255 255
     public function getNumWithActionsNotInGroup(): int
256 256
     {
257
-        return count($this->adminStats) - $this->numWithActions;
257
+        return count($this->adminStats)-$this->numWithActions;
258 258
     }
259 259
 }
Please login to merge, or discard this patch.
src/AppBundle/Model/AutoEdits.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the AutoEdits class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -225,8 +225,8 @@  discard block
 block discarded – undo
225 225
     public function getToolsTotal(): int
226 226
     {
227 227
         if (!is_int($this->toolsTotal)) {
228
-            $this->toolsTotal = array_reduce($this->getToolCounts(), function ($a, $b) {
229
-                return $a + $b['count'];
228
+            $this->toolsTotal = array_reduce($this->getToolCounts(), function($a, $b) {
229
+                return $a+$b['count'];
230 230
             });
231 231
         }
232 232
 
Please login to merge, or discard this patch.