x-tools / xtools

src/AppBundle/Controller/PagesController.php

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
                 'username' => $username,
             ]);
         } elseif ($projectQuery != "") {
-            return $this->redirectToRoute("PagesProject", [ 'project'=>$projectQuery ]);
+            return $this->redirectToRoute("PagesProject", ['project'=>$projectQuery]);
         }
 
         // set default wiki so we can populate the namespace selector
@@ -183,7 +183,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? "GROUP BY rev_page" : "") . "
+            ".($hasPageAssessments ? "GROUP BY rev_page" : "")."
             )
 
             UNION
@@ -267,8 +267,8 @@ 
         }
 
         if ($total < 1) {
-            $this->addFlash("notice", [ "no-result", $username ]);
-            return $this->redirectToRoute("PagesProject", [ "project"=>$project ]);
+            $this->addFlash("notice", ["no-result", $username]);
+            return $this->redirectToRoute("PagesProject", ["project"=>$project]);
         }
 
         ksort($pagesByNamespaceByDate);

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Symfony\Component\HttpFoundation\RedirectResponse;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 
 /**

tests/AppBundle/Controller/ApiControllerTest.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
             $this->assertEquals(200, $client->getResponse()->getStatusCode());
 
             // Check that a correct namespace value was returned
-            $namespaces = (array) json_decode($client->getResponse()->getContent());
+            $namespaces = (array)json_decode($client->getResponse()->getContent());
             $this->assertEquals('Utilisateur', array_values($namespaces)[2]); // User in French
         }
     }

app/autoload.php

Spacing +1 added lines, -1 removed lines

@@ -8,6 +8,6 @@
  */
 $loader = require __DIR__.'/../vendor/autoload.php';
 
-AnnotationRegistry::registerLoader([ $loader, 'loadClass' ]);
+AnnotationRegistry::registerLoader([$loader, 'loadClass']);
 
 return $loader;

app/AppKernel.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
             new AppBundle\AppBundle(),
         ];
 
-        if (in_array($this->getEnvironment(), [ 'dev', 'test' ], true)) {
+        if (in_array($this->getEnvironment(), ['dev', 'test'], true)) {
             $bundles[] = new Symfony\Bundle\DebugBundle\DebugBundle();
             $bundles[] = new Symfony\Bundle\WebProfilerBundle\WebProfilerBundle();
             $bundles[] = new Sensio\Bundle\DistributionBundle\SensioDistributionBundle();

src/AppBundle/Helper/AutomatedEditsHelper.php

Spacing +9 added lines, -9 removed lines

@@ -123,7 +123,7 @@ 
         $revTable = $lh->getTable('revision', $project->getDatabaseName());
         $pageTable = $lh->getTable('page', $project->getDatabaseName());
 
-        $AEBTypes = array_map(function ($AEBType) {
+        $AEBTypes = array_map(function($AEBType) {
             return $AEBType['regex'];
         }, $this->container->getParameter('automated_tools'));
 
@@ -148,12 +148,12 @@ 
         }
 
         // Get diff sizes, based on length of each parent revision
-        $parentRevIds = array_map(function ($edit) {
+        $parentRevIds = array_map(function($edit) {
             return $edit['rev_parent_id'];
         }, $editData);
         $query = "SELECT rev_len, rev_id
                   FROM revision
-                  WHERE rev_id IN (" . implode(',', $parentRevIds) . ")";
+                  WHERE rev_id IN (" . implode(',', $parentRevIds).")";
         $diffSizeData = $conn->executeQuery($query)->fetchAll();
 
         // reformat with rev_id as the key, rev_len as the value
@@ -163,24 +163,24 @@ 
         }
 
         // Build our array of nonautomated edits
-        $editData = array_map(function ($edit) use ($namespaces, $diffSizes) {
+        $editData = array_map(function($edit) use ($namespaces, $diffSizes) {
             $pageTitle = $edit['page_title'];
 
             if ($edit['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$edit['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$edit['page_namespace']].":$pageTitle";
             }
 
             $diffSize = $edit['rev_len'];
             if ($edit['rev_parent_id'] > 0) {
-                $diffSize = $edit['rev_len'] - $diffSizes[$edit['rev_parent_id']];
+                $diffSize = $edit['rev_len']-$diffSizes[$edit['rev_parent_id']];
             }
 
             return [
                 'page_title' => $pageTitle,
-                'namespace' => (int) $edit['page_namespace'],
-                'rev_id' => (int) $edit['rev_id'],
+                'namespace' => (int)$edit['page_namespace'],
+                'rev_id' => (int)$edit['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $edit['rev_timestamp']),
-                'minor_edit' => (bool) $edit['rev_minor_edit'],
+                'minor_edit' => (bool)$edit['rev_minor_edit'],
                 'summary' => $edit['rev_comment'],
                 'size' => $diffSize
             ];

src/AppBundle/Controller/AutomatedEditsController.php

Spacing +3 added lines, -3 removed lines

@@ -154,7 +154,7 @@ 
         $archiveTable = $lh->getTable('archive', $dbName);
 
         $condBegin = $start ? " AND rev_timestamp > :start " : null;
-        $condEnd = $end ? " AND rev_timestamp < :end ": null;
+        $condEnd = $end ? " AND rev_timestamp < :end " : null;
 
         $regexes = [];
 
@@ -248,8 +248,8 @@ 
         }
 
         // Sort the array and do some simple math.
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         if ($total != 0) {

src/Xtools/EditCounterRepository.php

Spacing +9 added lines, -9 removed lines

@@ -19,7 +19,7 @@ 
     public function getRevisionCounts(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisioncounts.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisioncounts.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -80,7 +80,7 @@ 
     public function getRevisionDates(Project $project, User $user)
     {
         // Set up cache.
-        $cacheKey = 'revisiondates.' . $project->getDatabaseName() . '.' . $user->getUsername();
+        $cacheKey = 'revisiondates.'.$project->getDatabaseName().'.'.$user->getUsername();
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -152,10 +152,10 @@ 
         $results = $resultQuery->fetchAll();
 
         $pageCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -186,7 +186,7 @@ 
 
         // Query.
         $sql = "SELECT CONCAT(log_type, '-', log_action) AS source, COUNT(log_id) AS value
-            FROM " . $this->getTableName($project->getDatabaseName(), 'logging') . "
+            FROM " . $this->getTableName($project->getDatabaseName(), 'logging')."
             WHERE log_user = :userId
             GROUP BY log_type, log_action";
         $resultQuery = $this->getProjectsConnection()->prepare($sql);
@@ -195,10 +195,10 @@ 
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
         $logCounts = array_combine(
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['source'];
             }, $results),
-            array_map(function ($e) {
+            array_map(function($e) {
                 return $e['value'];
             }, $results)
         );
@@ -355,9 +355,9 @@ 
         $resultQuery->bindParam(":id", $userId);
         $resultQuery->execute();
         $results = $resultQuery->fetchAll();
-        $namespaceTotals = array_combine(array_map(function ($e) {
+        $namespaceTotals = array_combine(array_map(function($e) {
             return $e['page_namespace'];
-        }, $results), array_map(function ($e) {
+        }, $results), array_map(function($e) {
             return $e['total'];
         }, $results));
 

src/AppBundle/Controller/MetaController.php

Spacing +4 added lines, -4 removed lines

@@ -21,7 +21,7 @@ 
         $end = $request->query->get('end');
 
         if ($start != '' && $end != '') {
-            return $this->redirectToRoute('MetaResult', [ 'start' => $start, 'end' => $end ]);
+            return $this->redirectToRoute('MetaResult', ['start' => $start, 'end' => $end]);
         }
 
         return $this->render('meta/index.html.twig', [
@@ -45,7 +45,7 @@ 
             ->getConnection();
 
         $query = $this->client->createQueryBuilder();
-        $query->select([ 'date', 'tool', 'count' ])
+        $query->select(['date', 'tool', 'count'])
             ->where($query->expr()->gte('date', ':start'))
             ->where($query->expr()->lte('date', ':end'))
             ->where($query->expr()->neq('tool', '""'))
@@ -61,7 +61,7 @@ 
         $timeline = [];
         $startObj = new DateTime($start);
         $endObj = new DateTime($end);
-        $numDays = (int) $endObj->diff($startObj)->format("%a");
+        $numDays = (int)$endObj->diff($startObj)->format("%a");
         $grandSum = 0;
 
         foreach ($data as $entry) {
@@ -76,7 +76,7 @@ 
             }
 
             $date = new DateTime($entry['date']);
-            $dateIndex = (int) $date->diff($startObj)->format("%a");
+            $dateIndex = (int)$date->diff($startObj)->format("%a");
             $timeline[$entry['tool']][$dateIndex] = $entry['count'];
 
             $grandSum += $entry['count'];

src/Xtools/Project.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Xtools;
 
 use Mediawiki\Api\MediawikiApi;
-use Symfony\Component\VarDumper\VarDumper;
 
 /**
  * A Project is a single wiki that Xtools is querying.

Spacing +5 added lines, -5 removed lines

@@ -79,7 +79,7 @@ 
      */
     public function getUrl($withTrailingSlash = true)
     {
-        return rtrim($this->getMetadata()['url'], '/') . ($withTrailingSlash ? '/' : '');
+        return rtrim($this->getMetadata()['url'], '/').($withTrailingSlash ? '/' : '');
     }
 
     /**
@@ -136,7 +136,7 @@ 
         $metadata = $this->getRepository()->getMetadata($this->getUrl());
         return isset($metadata['general']['script'])
             ? $metadata['general']['script']
-            : $this->getScriptPath() . '/index.php';
+            : $this->getScriptPath().'/index.php';
     }
 
     /**
@@ -146,7 +146,7 @@ 
      */
     public function getApiUrl()
     {
-        return rtrim($this->getUrl(), '/') . $this->getRepository()->getApiPath();
+        return rtrim($this->getUrl(), '/').$this->getRepository()->getApiPath();
     }
 
     /**
@@ -178,7 +178,7 @@ 
      */
     public function userOptInPage(User $user)
     {
-        $localPageName = 'User:' . $user->getUsername() . '/EditCounterOptIn.js';
+        $localPageName = 'User:'.$user->getUsername().'/EditCounterOptIn.js';
         return $localPageName;
     }
 
@@ -207,7 +207,7 @@ 
         }
 
         // 3. Lastly, see if they've opted in globally on the default project or Meta.
-        $globalPageName = $user->getUsername() . '/EditCounterGlobalOptIn.js';
+        $globalPageName = $user->getUsername().'/EditCounterGlobalOptIn.js';
         $globalProject = $this->getRepository()->getGlobalProject();
         if ($globalProject instanceof Project) {
             $globalExists = $globalProject->getRepository()