x-tools / xtools

src/AppBundle/Helper/AutomatedEditsHelper.php

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 
 namespace AppBundle\Helper;
 
-use DateTime;
 use Symfony\Component\DependencyInjection\ContainerInterface;
-use Xtools\ProjectRepository;
 
 /**
  * Helper class for getting information about semi-automated edits.

src/Xtools/UserRepository.php

Spacing +25 added lines, -25 removed lines

@@ -77,7 +77,7 @@ 
 
         $this->stopwatch->start($cacheKey, 'XTools');
         $api = $this->getMediawikiApi($project);
-        $params = [ "list"=>"users", "ususers"=>$username, "usprop"=>"groups" ];
+        $params = ["list"=>"users", "ususers"=>$username, "usprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
         $result = [];
         $res = $api->getRequest($query);
@@ -112,7 +112,7 @@ 
 
         // Create the API query.
         $api = $this->getMediawikiApi($project);
-        $params = [ "meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups" ];
+        $params = ["meta"=>"globaluserinfo", "guiuser"=>$username, "guiprop"=>"groups"];
         $query = new SimpleRequest('query', $params);
 
         // Get the result.
@@ -156,8 +156,8 @@ 
     {
         $username = $user->getUsername();
 
-        $cacheKey = 'pages.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $redirects;
+        $cacheKey = 'pages.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$redirects;
         if ($this->cache->hasItem($cacheKey)) {
             return $this->cache->getItem($cacheKey)->get();
         }
@@ -215,7 +215,7 @@ 
             JOIN $revisionTable ON page_id = rev_page
             $paJoin
             WHERE $whereRev AND rev_parent_id = '0' $namespaceConditionRev $redirectCondition
-            " . ($hasPageAssessments ? 'GROUP BY rev_page' : '') . "
+            ".($hasPageAssessments ? 'GROUP BY rev_page' : '')."
             )
 
             UNION
@@ -262,21 +262,21 @@ 
      */
     public function countEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'editcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'editcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -335,21 +335,21 @@ 
      */
     public function countAutomatedEdits(Project $project, User $user, $namespace = 'all', $start = '', $end = '')
     {
-        $cacheKey = 'autoeditcount.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autoeditcount.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -363,7 +363,7 @@ 
 
         $conn = $this->getProjectsConnection();
         $tools = $this->container->getParameter('automated_tools');
-        $toolRegexes = array_map(function ($tool) {
+        $toolRegexes = array_map(function($tool) {
             return $tool['regex'];
         }, $tools);
         $regex = $conn->quote(implode('|', $toolRegexes), \PDO::PARAM_STR);
@@ -425,21 +425,21 @@ 
         $end = '',
         $offset = 0
     ) {
-        $cacheKey = 'nonautoedits.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace . '.' . $offset;
+        $cacheKey = 'nonautoedits.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace.'.'.$offset;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND revs.rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -455,7 +455,7 @@ 
 
         // Build regex for all semi-automated tools
         $tools = $this->container->getParameter('automated_tools');
-        $toolRegexes = array_map(function ($tool) {
+        $toolRegexes = array_map(function($tool) {
             return $tool['regex'];
         }, $tools);
         $regex = $conn->quote(implode('|', $toolRegexes), \PDO::PARAM_STR);
@@ -532,21 +532,21 @@ 
         $start = '',
         $end = ''
     ) {
-        $cacheKey = 'autotoolcounts.' . $project->getDatabaseName() . '.'
-            . $user->getCacheKey() . '.' . $namespace;
+        $cacheKey = 'autotoolcounts.'.$project->getDatabaseName().'.'
+            . $user->getCacheKey().'.'.$namespace;
 
         $condBegin = '';
         $condEnd = '';
 
         if (!empty($start)) {
-            $cacheKey .= '.' . $start;
+            $cacheKey .= '.'.$start;
 
             // For the query
             $start = date('Ymd000000', strtotime($start));
             $condBegin = 'AND rev_timestamp >= :start ';
         }
         if (!empty($end)) {
-            $cacheKey .= '.' . $end;
+            $cacheKey .= '.'.$end;
 
             // For the query
             $end = date('Ymd235959', strtotime($end));
@@ -624,8 +624,8 @@ 
         }
 
         // Sort the array by count
-        uasort($results, function ($a, $b) {
-            return $b['count'] - $a['count'];
+        uasort($results, function($a, $b) {
+            return $b['count']-$a['count'];
         });
 
         // Cache for 10 minutes, and return.

src/Xtools/User.php

Spacing +7 added lines, -7 removed lines

@@ -206,21 +206,21 @@
 
         $namespaces = $project->getNamespaces();
 
-        return array_map(function ($rev) use ($namespaces) {
+        return array_map(function($rev) use ($namespaces) {
             $pageTitle = $rev['page_title'];
 
             if ($rev['page_namespace'] !== '0') {
-                $pageTitle = $namespaces[$rev['page_namespace']] . ":$pageTitle";
+                $pageTitle = $namespaces[$rev['page_namespace']].":$pageTitle";
             }
 
             return [
                 'page_title' => $pageTitle,
-                'page_namespace' => (int) $rev['page_namespace'],
-                'rev_id' => (int) $rev['rev_id'],
+                'page_namespace' => (int)$rev['page_namespace'],
+                'rev_id' => (int)$rev['rev_id'],
                 'timestamp' => DateTime::createFromFormat('YmdHis', $rev['timestamp']),
-                'minor' => (bool) $rev['minor'],
-                'length' => (int) $rev['length'],
-                'length_change' => (int) $rev['length_change'],
+                'minor' => (bool)$rev['minor'],
+                'length' => (int)$rev['length'],
+                'length_change' => (int)$rev['length_change'],
                 'comment' => $rev['comment'],
             ];
         }, $revs);

src/AppBundle/Controller/ApiController.php

Unused Use Statements -5 removed lines

@@ -5,18 +5,13 @@
 
 namespace AppBundle\Controller;
 
-use Exception;
-use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\Debug\Exception\FatalErrorException;
 use FOS\RestBundle\Controller\Annotations as Rest;
 use FOS\RestBundle\Controller\FOSRestController;
 use FOS\RestBundle\View\View;
 use Xtools\ProjectRepository;
 use Xtools\UserRepository;
-use Xtools\Page;
 use Xtools\Edit;
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -105,13 +105,13 @@ 
         $data = $user->getNonautomatedEdits($project, $namespace, $start, $end, $offset);
 
         if ($format === 'html') {
-            $edits = array_map(function ($attrs) use ($project, $username) {
+            $edits = array_map(function($attrs) use ($project, $username) {
                 $nsName = '';
                 if ($attrs['page_namespace']) {
                     $nsName = $project->getNamespaces()[$attrs['page_namespace']];
                 }
                 $page = $project->getRepository()
-                    ->getPage($project, $nsName . ':' . $attrs['page_title']);
+                    ->getPage($project, $nsName.':'.$attrs['page_title']);
                 $attrs['id'] = $attrs['rev_id'];
                 $attrs['username'] = $username;
                 return new Edit($page, $attrs);
@@ -160,7 +160,7 @@ 
         }
 
         $conn = $this->getDoctrine()->getManager('default')->getConnection();
-        $date =  date('Y-m-d');
+        $date = date('Y-m-d');
 
         // Increment count in timeline
         $existsSql = "SELECT 1 FROM usage_timeline

src/AppBundle/Controller/RfXAnalysisController.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
 use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Xtools\ProjectRepository;
 use Xtools\RFA;
 

Spacing +1 added lines, -1 removed lines

@@ -172,7 +172,7 @@
         $end = $rfa->get_enddate();
 
         $percent = (sizeof($support) /
-            (sizeof($support) + sizeof($oppose) + sizeof($neutral)));
+            (sizeof($support)+sizeof($oppose)+sizeof($neutral)));
 
         $percent = $percent * 100;
 

src/AppBundle/Controller/RfXVoteCalculatorController.php

Unused Use Statements -2 removed lines

@@ -3,8 +3,6 @@
 namespace AppBundle\Controller;
 
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-use Symfony\Component\CssSelector\Exception\InternalErrorException;
-use Symfony\Component\Debug\Exception\ContextErrorException;
 use Symfony\Component\HttpFoundation\Request;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Xtools\ProjectRepository;

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
         $username = $request->query->get('username');
 
         if ($projectQuery != "" && $username != "") {
-            $routeParams = [ 'project'=>$projectQuery, 'username' => $username ];
+            $routeParams = ['project'=>$projectQuery, 'username' => $username];
             return $this->redirectToRoute(
                 "rfapResult",
                 $routeParams
@@ -135,8 +135,8 @@ 
             $titles = [];
 
             while ($row = $sth->fetch()) {
-                $titles[] = $namespaces[$row["page_namespace"]] .
-                    ":" .$row["page_title"];
+                $titles[] = $namespaces[$row["page_namespace"]].
+                    ":".$row["page_title"];
             }
 
             // Chunking... it's possible to make a URI too long

src/Xtools/RFA.php

Doc Comments +4 added lines, -1 removed lines

@@ -20,7 +20,7 @@ 
      * Returns matches.
      *
      * @param $input
-     * @param $matches
+     * @param string[] $matches
      *
      * @return int
      */
@@ -85,6 +85,9 @@ 
         return $this->userSectionFound;
     }
 
+    /**
+     * @param string $sectionName
+     */
     public function getSection($sectionName) {
         $sectionName = strtolower($sectionName);
         if (!isset($this->data[$sectionName])) {

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *
      * @return int
      */
-    protected function findSig( $input, &$matches ) {
+    protected function findSig($input, &$matches) {
         //Supports User: and User talk: wikilinks, {{fullurl}}, unsubsted {{unsigned}}, unsubsted {{unsigned2}}, anything that looks like a custom sig template
         // TODO: Cross-wiki this sucker
         return preg_match_all(

Braces +1 added lines, -2 removed lines

@@ -89,8 +89,7 @@
         $sectionName = strtolower($sectionName);
         if (!isset($this->data[$sectionName])) {
             return [];
-        }
-        else {
+        } else {
             return $this->data[$sectionName];
         }
     }

tests/Xtools/EditTest.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
         ]);
 
         $this->assertEquals(
-            "<script>alert("XSS baby")</script> " .
+            "<script>alert("XSS baby")</script> ".
                 "<a target='_blank' href='/wiki/Test_page'>test page</a>",
             $edit->getWikifiedSummary()
         );