Test Failed
Push — limit-refactor ( 7ca574...b49df6 )
by MusikAnimal
05:47
created
src/AppBundle/Controller/DefaultController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
     public function loginAction(Request $request, SessionInterface $session): RedirectResponse
95 95
     {
96 96
         try {
97
-            [ $next, $token ] = $this->getOauthClient($request)->initiate();
97
+            [$next, $token] = $this->getOauthClient($request)->initiate();
98 98
         } catch (Exception $oauthException) {
99 99
             throw $oauthException;
100 100
             // @TODO Make this work.
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
                     . '?title=Special:OAuth';
176 176
         $conf = new ClientConfig($endpoint);
177 177
         $consumerKey = $this->getParameter('oauth_key');
178
-        $consumerSecret =  $this->getParameter('oauth_secret');
178
+        $consumerSecret = $this->getParameter('oauth_secret');
179 179
         $conf->setConsumer(new Consumer($consumerKey, $consumerSecret));
180 180
         $this->oauthClient = new Client($conf);
181 181
 
Please login to merge, or discard this patch.
src/AppBundle/EventSubscriber/RateLimitSubscriber.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the RateLimitSubscriber class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\EventSubscriber;
9 9
 
@@ -137,7 +137,7 @@  discard block
 block discarded – undo
137 137
         $cacheItem = $this->cache->getItem($cacheKey);
138 138
 
139 139
         // If increment value already in cache, or start with 1.
140
-        $count = $cacheItem->isHit() ? (int) $cacheItem->get() + 1 : 1;
140
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
141 141
 
142 142
         // Check if limit has been exceeded, and if so, throw an error.
143 143
         if ($count > $this->rateLimit) {
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
         $cacheItem = $this->cache->getItem($cacheKey);
178 178
 
179 179
         // If increment value already in cache, or start with 1.
180
-        $count = $cacheItem->isHit() ? (int)$cacheItem->get() + 1 : 1;
180
+        $count = $cacheItem->isHit() ? (int)$cacheItem->get()+1 : 1;
181 181
 
182 182
         // Check if limit has been exceeded, and if so, add a log entry.
183 183
         if ($count > 3) {
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
         $message = $this->i18n->msg('error-rate-limit', [
253 253
             $this->rateDuration,
254 254
             "<a href='/login'>".$this->i18n->msg('error-rate-limit-login')."</a>",
255
-            "<a href='https://www.mediawiki.org/wiki/Special:MyLanguage/XTools/API' target='_blank'>" .
256
-                $this->i18n->msg('api') .
255
+            "<a href='https://www.mediawiki.org/wiki/Special:MyLanguage/XTools/API' target='_blank'>".
256
+                $this->i18n->msg('api').
257 257
             "</a>",
258 258
         ]);
259 259
 
Please login to merge, or discard this patch.
src/AppBundle/Controller/XtoolsController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
             throw new XtoolsHttpException(
203 203
                 $this->i18n->msg('not-opted-in', [
204 204
                     $this->getOptedInPage()->getTitle(),
205
-                    $this->i18n->msg('not-opted-in-link') .
205
+                    $this->i18n->msg('not-opted-in-link').
206 206
                         ' <https://www.mediawiki.org/wiki/XTools/Edit_Counter#restricted_stats>',
207 207
                     $this->i18n->msg('not-opted-in-login'),
208 208
                 ]),
@@ -642,7 +642,7 @@  discard block
 block discarded – undo
642 642
         $params = $this->convertLegacyParams($params);
643 643
 
644 644
         // Remove blank values.
645
-        return array_filter($params, function ($param) {
645
+        return array_filter($params, function($param) {
646 646
             // 'namespace' or 'username' could be '0'.
647 647
             return null !== $param && '' !== $param;
648 648
         });
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
         }
844 844
 
845 845
         $elapsedTime = round(
846
-            microtime(true) - $this->request->server->get('REQUEST_TIME_FLOAT'),
846
+            microtime(true)-$this->request->server->get('REQUEST_TIME_FLOAT'),
847 847
             3
848 848
         );
849 849
 
@@ -886,7 +886,7 @@  discard block
 block discarded – undo
886 886
         $conn = $this->container->get('doctrine')
887 887
             ->getManager('default')
888 888
             ->getConnection();
889
-        $date =  date('Y-m-d');
889
+        $date = date('Y-m-d');
890 890
 
891 891
         // Increment count in timeline
892 892
         $existsSql = "SELECT 1 FROM usage_api_timeline
Please login to merge, or discard this patch.
src/AppBundle/Repository/SimpleEditCounterRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the SimpleEditCounterRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
         $revDateConditions = $this->getDateConditions($start, $end, false, "$ipcTable.", 'ipc_rev_timestamp');
124 124
         [$startHex, $endHex] = IPUtils::parseRange($user->getUsername());
125 125
 
126
-        $revNamespaceJoinSql = 'all' === $namespace ? '' : "JOIN $revTable ON rev_id = ipc_rev_id " .
126
+        $revNamespaceJoinSql = 'all' === $namespace ? '' : "JOIN $revTable ON rev_id = ipc_rev_id ".
127 127
             "JOIN $pageTable ON rev_page = page_id";
128 128
         $revNamespaceWhereSql = 'all' === $namespace ? '' : "AND page_namespace = $namespace";
129 129
 
Please login to merge, or discard this patch.
src/AppBundle/Repository/EditCounterRepository.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the EditCounterRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -140,10 +140,10 @@  discard block
 block discarded – undo
140 140
         ])->fetchAll();
141 141
 
142 142
         $logCounts = array_combine(
143
-            array_map(function ($e) {
143
+            array_map(function($e) {
144 144
                 return $e['source'];
145 145
             }, $results),
146
-            array_map(function ($e) {
146
+            array_map(function($e) {
147 147
                 return (int)$e['value'];
148 148
             }, $results)
149 149
         );
@@ -221,10 +221,10 @@  discard block
 block discarded – undo
221 221
         }
222 222
 
223 223
         $counts = array_combine(
224
-            array_map(function ($e) {
224
+            array_map(function($e) {
225 225
                 return $e['key'];
226 226
             }, $results),
227
-            array_map(function ($e) {
227
+            array_map(function($e) {
228 228
                 return (int)$e['val'];
229 229
             }, $results)
230 230
         );
@@ -380,9 +380,9 @@  discard block
 block discarded – undo
380 380
 
381 381
         $results = $this->executeProjectsQuery($project, $sql, $params)->fetchAll();
382 382
 
383
-        $namespaceTotals = array_combine(array_map(function ($e) {
383
+        $namespaceTotals = array_combine(array_map(function($e) {
384 384
             return $e['page_namespace'];
385
-        }, $results), array_map(function ($e) {
385
+        }, $results), array_map(function($e) {
386 386
             return (int)$e['total'];
387 387
         }, $results));
388 388
 
Please login to merge, or discard this patch.
src/AppBundle/Model/User.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the User class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Model;
9 9
 
@@ -127,14 +127,14 @@  discard block
 block discarded – undo
127 127
             $firstAddrUnpacked = unpack('H*', $firstAddrBin);
128 128
             $firstAddrHex = reset($firstAddrUnpacked);
129 129
             $range[0] = inet_ntop($firstAddrBin);
130
-            $flexBits = 128 - $prefixLen;
130
+            $flexBits = 128-$prefixLen;
131 131
             $lastAddrHex = $firstAddrHex;
132 132
 
133 133
             $pos = 31;
134 134
             while ($flexBits > 0) {
135 135
                 $orig = substr($lastAddrHex, $pos, 1);
136 136
                 $origVal = hexdec($orig);
137
-                $newVal = $origVal | (pow(2, min(4, $flexBits)) - 1);
137
+                $newVal = $origVal | (pow(2, min(4, $flexBits))-1);
138 138
                 $new = dechex($newVal);
139 139
                 $lastAddrHex = substr_replace($lastAddrHex, $new, $pos, 1);
140 140
                 $flexBits -= 4;
@@ -145,8 +145,8 @@  discard block
 block discarded – undo
145 145
             $range[1] = inet_ntop($lastAddrBin);
146 146
         } else {
147 147
             $cidr = explode('/', $this->username);
148
-            $range[0] = long2ip(ip2long($cidr[0]) & -1 << (32 - (int)$cidr[1]));
149
-            $range[1] = long2ip(ip2long($range[0]) + pow(2, (32 - (int)$cidr[1])) - 1);
148
+            $range[0] = long2ip(ip2long($cidr[0]) & -1 << (32-(int)$cidr[1]));
149
+            $range[1] = long2ip(ip2long($range[0])+pow(2, (32-(int)$cidr[1]))-1);
150 150
         }
151 151
 
152 152
         // Find the leftmost common characters between the two addresses.
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
      */
355 355
     public function countEdits(Project $project, $namespace = 'all', $start = false, $end = false): int
356 356
     {
357
-        return (int) $this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
357
+        return (int)$this->getRepository()->countEdits($project, $this, $namespace, $start, $end);
358 358
     }
359 359
 
360 360
     /**
Please login to merge, or discard this patch.
src/AppBundle/Repository/GlobalContribsRepository.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Repository;
5 5
 
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
             $slice = $this->getDbList()[$dbName];
175 175
             // actor_revision table only includes users who have made at least one edit.
176 176
             $actorTable = $this->getTableName($dbName, 'actor', 'revision');
177
-            $queriesBySlice[$slice][] = "SELECT '$dbName' AS `dbName`, actor_id " .
177
+            $queriesBySlice[$slice][] = "SELECT '$dbName' AS `dbName`, actor_id ".
178 178
                 "FROM $actorTable WHERE $whereClause";
179 179
         }
180 180
 
@@ -293,13 +293,13 @@  discard block
 block discarded – undo
293 293
         // Re-assemble into UNIONed queries, executing as many per slice as possible.
294 294
         $revisions = [];
295 295
         foreach ($queriesBySlice as $slice => $queries) {
296
-            $sql = "SELECT * FROM ((\n" . join("\n) UNION (\n", $queries) . ")) a ORDER BY timestamp DESC LIMIT $limit";
296
+            $sql = "SELECT * FROM ((\n".join("\n) UNION (\n", $queries).")) a ORDER BY timestamp DESC LIMIT $limit";
297 297
             $revisions = array_merge($revisions, $this->executeProjectsQuery($slice, $sql)->fetchAll());
298 298
         }
299 299
 
300 300
         // If there are more than $limit results, re-sort by timestamp.
301 301
         if (count($revisions) > $limit) {
302
-            usort($revisions, function ($a, $b) {
302
+            usort($revisions, function($a, $b) {
303 303
                 if ($a['unix_timestamp'] === $b['unix_timestamp']) {
304 304
                     return 0;
305 305
                 }
Please login to merge, or discard this patch.
src/AppBundle/Repository/TopEditsRepository.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -3,7 +3,7 @@  discard block
 block discarded – undo
3 3
  * This file contains only the TopEditsRepository class.
4 4
  */
5 5
 
6
-declare(strict_types = 1);
6
+declare(strict_types=1);
7 7
 
8 8
 namespace AppBundle\Repository;
9 9
 
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments() && 0 === $namespace;
66 66
         $paTable = $project->getTableName('page_assessments');
67 67
         $paSelect = $hasPageAssessments
68
-            ?  ", (
68
+            ? ", (
69 69
                     SELECT pa_class
70 70
                     FROM $paTable
71 71
                     WHERE pa_page_id = page_id
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         $hasPageAssessments = $this->isLabs() && $project->hasPageAssessments();
180 180
         $pageAssessmentsTable = $this->getTableName($project->getDatabaseName(), 'page_assessments');
181 181
         $paSelect = $hasPageAssessments
182
-            ?  ", (
182
+            ? ", (
183 183
                     SELECT pa_class
184 184
                     FROM $pageAssessmentsTable
185 185
                     WHERE pa_page_id = e.page_id
Please login to merge, or discard this patch.
src/AppBundle/Model/ArticleInfoApi.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@  discard block
 block discarded – undo
1 1
 <?php
2
-declare(strict_types = 1);
2
+declare(strict_types=1);
3 3
 
4 4
 namespace AppBundle\Model;
5 5
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
 
149 149
         $refs = $crawler->filter('#mw-content-text .reference');
150 150
         $refContent = [];
151
-        $refs->each(function ($ref) use (&$refContent): void {
151
+        $refs->each(function($ref) use (&$refContent): void {
152 152
             $refContent[] = $ref->text();
153 153
         });
154 154
         $uniqueRefs = count(array_unique($refContent));
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
         $totalChars = 0;
177 177
         $totalWords = 0;
178 178
         $paragraphs = $crawler->filter($selector);
179
-        $paragraphs->each(function ($node) use (&$totalChars, &$totalWords): void {
179
+        $paragraphs->each(function($node) use (&$totalChars, &$totalWords): void {
180 180
             /** @var Crawler $node */
181 181
             $text = preg_replace('/\[\d+]/', '', trim($node->text(null, true)));
182 182
             $totalChars += strlen($text);
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
         $data = [
241 241
             'project' => $project->getDomain(),
242 242
             'page' => $page->getTitle(),
243
-            'watchers' => (int) $page->getWatchers(),
243
+            'watchers' => (int)$page->getWatchers(),
244 244
             'pageviews' => $page->getLastPageviews($pageviewsOffset),
245 245
             'pageviews_offset' => $pageviewsOffset,
246 246
         ];
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         if (false !== $info) {
266 266
             $creationDateTime = DateTime::createFromFormat('YmdHis', $info['created_at']);
267 267
             $modifiedDateTime = DateTime::createFromFormat('YmdHis', $info['modified_at']);
268
-            $secsSinceLastEdit = (new DateTime)->getTimestamp() - $modifiedDateTime->getTimestamp();
268
+            $secsSinceLastEdit = (new DateTime)->getTimestamp()-$modifiedDateTime->getTimestamp();
269 269
 
270 270
             // Some wikis (such foundation.wikimedia.org) may be missing the creation date.
271 271
             $creationDateTime = false === $creationDateTime
@@ -277,16 +277,16 @@  discard block
 block discarded – undo
277 277
                 ->getAssessment($page);
278 278
 
279 279
             $data = array_merge($data, [
280
-                'revisions' => (int) $info['num_edits'],
281
-                'editors' => (int) $info['num_editors'],
282
-                'minor_edits' => (int) $info['minor_edits'],
280
+                'revisions' => (int)$info['num_edits'],
281
+                'editors' => (int)$info['num_editors'],
282
+                'minor_edits' => (int)$info['minor_edits'],
283 283
                 'author' => $info['author'],
284
-                'author_editcount' => null === $info['author_editcount'] ? null : (int) $info['author_editcount'],
284
+                'author_editcount' => null === $info['author_editcount'] ? null : (int)$info['author_editcount'],
285 285
                 'created_at' => $creationDateTime,
286 286
                 'created_rev_id' => $info['created_rev_id'],
287 287
                 'modified_at' => $modifiedDateTime->format('Y-m-d H:i'),
288 288
                 'secs_since_last_edit' => $secsSinceLastEdit,
289
-                'last_edit_id' => (int) $info['modified_rev_id'],
289
+                'last_edit_id' => (int)$info['modified_rev_id'],
290 290
                 'assessment' => $assessment,
291 291
             ]);
292 292
         }
@@ -436,8 +436,8 @@  discard block
 block discarded – undo
436 436
         }
437 437
 
438 438
         // Sort by edit count.
439
-        uasort($this->bots, function ($a, $b) {
440
-            return $b['count'] - $a['count'];
439
+        uasort($this->bots, function($a, $b) {
440
+            return $b['count']-$a['count'];
441 441
         });
442 442
 
443 443
         return $this->bots;
Please login to merge, or discard this patch.