Project - Code Metrics - Inspection of "Add Project::exists() method and test, and update..." - x-tools/xtools - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7afccb...b2e486 )

by Sam

created 2017-05-28 18:32 UTC

Project A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	114
Duplicated Lines	12.28 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	15
lcom	1
cbo	1
dl	14
loc	114
rs	10
c	0
b	0
f	0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getMetadata()	0	7	2
A	exists()	0	4	1
A	getDomain()	0	5	2
A	getDatabaseName()	0	4	2
A	getUrl()	0	4	1
A	getArticlePath()	7	7	2
A	getScriptPath()	7	7	2
A	getTitle()	0	5	1
A	getNamespaces()	0	5	1

How to fix Duplicated Code

<?php

namespace Xtools;

/**
 * A Project is a single wiki that Xtools is querying.
 */
class Project extends Model
{

    /** @var string The project name as supplied by the user. */
    protected $nameUnnormalized;

    /** @var string[] Basic metadata about the project */
    protected $metadata;

    public function __construct($nameOrUrl)
    {
        $this->nameUnnormalized = $nameOrUrl;
    }

    protected function getMetadata()
    {
        if (!$this->metadata) {

            $this->metadata = $this->getRepository()->getOne($this->nameUnnormalized);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        }
        return $this->metadata;
    }

    /**
     * Does this project exist?
     * @return bool
     */
    public function exists()
    {
        return !empty($this->getDomain());
    }

    /**
     * The unique domain name of this project, without protocol or path components.
     * This should be used as the canonical project identifier.
     *
     * @return string
     */
    public function getDomain()
    {
        $url = isset($this->getMetadata()['url']) ? $this->getMetadata()['url'] : '';
        return parse_url($url, PHP_URL_HOST);
    }

    /**
     * The name of the database for this project.
     *
     * @return string
     */
    public function getDatabaseName()
    {
        return isset($this->getMetadata()['dbname']) ? $this->getMetadata()['dbname'] : '';
    }

    /**
     * The project URL is the fully-qualified domain name, with protocol and trailing slash.
     *
     * @return string
     */
    public function getUrl()
    {
        return rtrim($this->getMetadata()['url'], '/') . '/';
    }

    /**
     * The base URL path of this project (that page titles are appended to).
     *
     * @link https://www.mediawiki.org/wiki/Manual:$wgArticlePath
     *
     * @return string
     */
    public function getArticlePath()

    {
        $metadata = $this->getRepository()->getMetadata($this->getUrl());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return isset($metadata['general']['articlePath'])
            ? $metadata['general']['articlePath']
            : '/wiki/';
    }

    /**
     * The URL path to index.php
     *
     * @link https://www.mediawiki.org/wiki/Manual:$wgScriptPath
     *
     * @return string
     */
    public function getScriptPath()

    {
        $metadata = $this->getRepository()->getMetadata($this->getUrl());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return isset($metadata['general']['scriptPath'])
            ? $metadata['general']['scriptPath']
            : '/w/index.php';
    }

    /**
     * Get this project's title, the human-language full title of the wiki (e.g. "English
     * Wikipedia" or
     */
    public function getTitle()
    {
        $metadata = $this->getRepository()->getMetadata($this->getUrl());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $metadata['general']['wikiName'].' ('.$this->getDomain().')';
    }

    /**
     * Get an array of this project's namespaces and their IDs.
     *
     * @return string[] Keys are IDs, values are names.
     */
    public function getNamespaces()
    {
        $metadata = $this->getRepository()->getMetadata($this->getUrl());
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        return $metadata['namespaces'];
    }
}


1		<?php
2
3		namespace Xtools;
4
5		/**
6		* A Project is a single wiki that Xtools is querying.
7		*/
8		class Project extends Model
9		{
10
11		/** @var string The project name as supplied by the user. */
12		protected $nameUnnormalized;
13
14		/** @var string[] Basic metadata about the project */
15		protected $metadata;
16
17		public function __construct($nameOrUrl)
18		{
19		$this->nameUnnormalized = $nameOrUrl;
20		}
21
22		protected function getMetadata()
23		{
24		if (!$this->metadata) {
		0 ignored issues – show Bug Best Practice introduced 2017-05-01 09:11 UTC by Report Bug Copy Issue Report The expression `$this->metadata` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
25		$this->metadata = $this->getRepository()->getOne($this->nameUnnormalized);
		1 ignored issue – show Bug introduced 2017-05-02 01:55 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getOne()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\ProjectRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
26		}
27		return $this->metadata;
28		}
29
30		/**
31		* Does this project exist?
32		* @return bool
33		*/
34		public function exists()
35		{
36		return !empty($this->getDomain());
37		}
38
39		/**
40		* The unique domain name of this project, without protocol or path components.
41		* This should be used as the canonical project identifier.
42		*
43		* @return string
44		*/
45		public function getDomain()
46		{
47		$url = isset($this->getMetadata()['url']) ? $this->getMetadata()['url'] : '';
48		return parse_url($url, PHP_URL_HOST);
49		}
50
51		/**
52		* The name of the database for this project.
53		*
54		* @return string
55		*/
56		public function getDatabaseName()
57		{
58		return isset($this->getMetadata()['dbname']) ? $this->getMetadata()['dbname'] : '';
59		}
60
61		/**
62		* The project URL is the fully-qualified domain name, with protocol and trailing slash.
63		*
64		* @return string
65		*/
66		public function getUrl()
67		{
68		return rtrim($this->getMetadata()['url'], '/') . '/';
69		}
70
71		/**
72		* The base URL path of this project (that page titles are appended to).
73		*
74		* @link https://www.mediawiki.org/wiki/Manual:$wgArticlePath
75		*
76		* @return string
77		*/
78	View Code Duplication	public function getArticlePath()
		0 ignored issues – show Duplication introduced 2017-05-02 07:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
79		{
80		$metadata = $this->getRepository()->getMetadata($this->getUrl());
		1 ignored issue – show Bug introduced 2017-05-02 02:38 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getMetadata()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\ProjectRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
81		return isset($metadata['general']['articlePath'])
82		? $metadata['general']['articlePath']
83		: '/wiki/';
84		}
85
86		/**
87		* The URL path to index.php
88		*
89		* @link https://www.mediawiki.org/wiki/Manual:$wgScriptPath
90		*
91		* @return string
92		*/
93	View Code Duplication	public function getScriptPath()
		0 ignored issues – show Duplication introduced 2017-05-02 07:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		$metadata = $this->getRepository()->getMetadata($this->getUrl());
		1 ignored issue – show Bug introduced 2017-05-02 07:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getMetadata()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\ProjectRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
96		return isset($metadata['general']['scriptPath'])
97		? $metadata['general']['scriptPath']
98		: '/w/index.php';
99		}
100
101		/**
102		* Get this project's title, the human-language full title of the wiki (e.g. "English
103		* Wikipedia" or
104		*/
105		public function getTitle()
106		{
107		$metadata = $this->getRepository()->getMetadata($this->getUrl());
		1 ignored issue – show Bug introduced 2017-05-02 07:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getMetadata()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\ProjectRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
108		return $metadata['general']['wikiName'].' ('.$this->getDomain().')';
109		}
110
111		/**
112		* Get an array of this project's namespaces and their IDs.
113		*
114		* @return string[] Keys are IDs, values are names.
115		*/
116		public function getNamespaces()
117		{
118		$metadata = $this->getRepository()->getMetadata($this->getUrl());
		1 ignored issue – show Bug introduced 2017-05-02 07:27 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Xtools\Repository` as the method `getMetadata()` does only exist in the following sub-classes of `Xtools\Repository`: `Xtools\ProjectRepository`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
119		return $metadata['namespaces'];
120		}
121		}
122

x-tools / xtools

Push — master ( 7afccb...b2e486 )

Project A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like