Epesi\Core\System\User\Access\AccessSettings::showEditPermissions()

Complexity

Conditions	2
Paths	2

Size

Total Lines	61
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	protected function showEditPermissions()
	{
		$permissionsData = Permission::all(['id', 'name'])->map(function($permission){
			$permission['name'] = trans(ucwords($permission['name']));
			
			return $permission;
		})->toArray();

		$table = $this->columns()->addColumn()->add(['Table', 'selectable'])->addStyle('cursor', 'pointer');

The method addColumn() does not exist on atk4\ui\View. It seems like you code against a sub-type of atk4\ui\View such as atk4\ui\Columns or atk4\ui\Grid or atk4\ui\Table.

		$table->setModel($this->getModel($permissionsData), false);
		
		$table->addColumn('name', 'Text', ['caption' => __('Permissions')]);
		
		$table->addColumn(null, new Template([['i', 'class' => 'indicator arrow circle right icon']]), ['caption' => 'Test'])->setAttr('class', ['right aligned']);

array(array('i', 'class' => 'indicator arrow circle right icon')) of type array<integer,string[]> is incompatible with the type string expected by parameter $template of atk4\ui\TableColumn\Template::__construct().

		
		eval_css('
		table.selectable tr:not(.active) .indicator {
			display: none;
		}');
		
		$table->on('click', 'tr', $this->reload(new jsExpression('$(this).data("id")')));
		
		if ($permissionId = $this->permissionId()) {
			$permission = Permission::findById($permissionId);

It seems like $permissionId can also be of type string; however, parameter $id of Spatie\Permission\Models\Permission::findById() does only seem to accept integer, maybe add an additional type check?

			
			$this->putModuleVariable('permission', $permissionId);
			
			$table->js(true)->find("tr[data-id=$permission->id]")->addClass('active');

Accessing id on the interface Spatie\Permission\Contracts\Permission suggest that you code against a concrete implementation. How about adding an instanceof check?

			
			$rolesData = $permission->roles()->get()->map(function($role) {
				$role['name'] = trans($role['name']);
				
				return $role;
			})->toArray();

			$column = $this->columns()->addColumn();
			$rolesTable = $column->add('Table');
			$rolesTable->setModel($this->getModel($rolesData), false);
			
			$rolesTable->addColumn('name', 'Text', ['caption' => __('Roles allowed to :permission', ['permission' => $permission->name])]);

Accessing name on the interface Spatie\Permission\Contracts\Permission suggest that you code against a concrete implementation. How about adding an instanceof check?

			
			$roleActions = $rolesTable->addColumn(null, 'Actions');
			$roleActions->addAction($this->deleteButton(), function($jQuery, $roleId) use ($permission) {
				Role::findById($roleId)->revokePermissionTo($permission);
				
				return $this->reload();
			}, __('Revoke permission to role?'));
				
			$usersData = $permission->users()->get()->toArray();

			$usersTable = $column->add('Table');
			$usersTable->setModel($this->getModel($usersData), false);
				
			$usersTable->addColumn('name', 'Text', ['caption' => __('Users allowed to :permission', ['permission' => $permission->name])]);
				
			$userActions = $usersTable->addColumn(null, 'Actions');
			$userActions->addAction($this->deleteButton(), function($jQuery, $userId) use ($permission) {
				User::find($userId)->revokePermissionTo($permission);
					
				return $this->reload();
			}, __('Revoke permission to user?'));
		}