Epesi\Core\Console\DatabaseCreateCommand

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	3	1
A	connection()	0	23	3

<?php

namespace Epesi\Core\Console;

use Illuminate\Console\Command;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\App;

class DatabaseCreateCommand extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'epesi:database-create {name : The name of the database.} 
													{--connection=mysql DB connection settings}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Create database for the epesi application';
    
    protected $connection;

    /**
     * Execute the console command.
     */
    public function handle()
    {
    	DB::connection($this->connection())->statement('CREATE DATABASE `' . $this->argument('name') . '`');

Are you sure $this->argument('name') of type null|string|string[] can be used in concatenation?

Are you sure the usage of $this->connection() targeting Epesi\Core\Console\DatabaseCreateCommand::connection() seems to always return null.

$this->connection() of type void is incompatible with the type string expected by parameter $name of Illuminate\Support\Facades\DB::connection().

    }
    
    /**
     * Creates the configuration for the connection and returns the key
     * 
     * @return void
     */
    protected function connection()
    {
    	$connection = $this->option('connection');
    	
    	// Just get access to the config.
    	$config = App::make('config');
    	
    	// Will contain the array of connections that appear in our database config file.
    	$connections = $config->get('database.connections');
    	
    	$driver = is_string($connection)? $connection: $connection['driver'];

The condition is_string($connection) is always true.

    	$defaultConnection = $connections[$driver]?? $connections[$config->get('database.default')];
    	
    	$newConnection = array_merge($defaultConnection, is_string($connection)? []: $connection);

The condition is_string($connection) is always true.

    	// Do not select database
    	$newConnection['database'] = '';

    	// This will add our new connection to the run-time configuration for the duration of the request.
    	$config->set('database.connections.create-db', $newConnection);

    	return 'create-db';

The expression return 'create-db' returns the type string which is incompatible with the documented return type void.

    }
}