Passed
Push — master ( a37889...b0889b )
by Georgi
03:24
created
src/CommonData/Database/Models/CommonData.php 1 patch
Spacing   +22 added lines, -22 removed lines patch added patch discarded remove patch
@@ -24,11 +24,11 @@  discard block
 block discarded – undo
24 24
     public static function getId($path, $clearCache = false)
25 25
     {
26 26
     	$parentId = null;
27
-    	foreach(explode('/', trim($path,'/')) as $nodeKey) {
27
+    	foreach (explode('/', trim($path, '/')) as $nodeKey) {
28 28
     		if ($nodeKey === '') continue; //ignore empty paths
29 29
     		
30 30
     		if ($clearCache || empty(self::$cache['id'][$parentId][$nodeKey])) {
31
-    			if (! $node = self::where('parent_id', $parentId)->where('key', $nodeKey)->first()) {
31
+    			if (!$node = self::where('parent_id', $parentId)->where('key', $nodeKey)->first()) {
32 32
     				return false;
33 33
     			}
34 34
 
@@ -43,19 +43,19 @@  discard block
 block discarded – undo
43 43
    
44 44
     public static function newId($path, $readonly = false)
45 45
     {
46
-    	if (! $path = trim($path,'/')) return false;
46
+    	if (!$path = trim($path, '/')) return false;
47 47
 
48 48
     	$id = $parentId = null;
49
-    	foreach(explode('/', $path) as $nodeKey) {
49
+    	foreach (explode('/', $path) as $nodeKey) {
50 50
     		if ($nodeKey === '') continue;
51 51
 
52
-    		if (! $node = self::where('parent_id', $parentId)->where('key', $nodeKey)->first()) {
52
+    		if (!$node = self::where('parent_id', $parentId)->where('key', $nodeKey)->first()) {
53 53
     			$node = self::create([
54 54
     					'parent_id' => $parentId,
55 55
     					'key' => $nodeKey,
56 56
     					'readonly' => $readonly,
57 57
     					'position' => self::where('parent_id', $parentId)->count()
58
-    			], $parentId? self::find($parentId): null);
58
+    			], $parentId ? self::find($parentId) : null);
59 59
     		}
60 60
     		
61 61
     		$parentId = $id = $node->id;
@@ -66,10 +66,10 @@  discard block
 block discarded – undo
66 66
     
67 67
     public static function setValue($path, $value, $overwrite = true, $readonly = false)
68 68
     {
69
-    	if (! $id = self::getId($path)) {
70
-    		if (! $id = self::newId($path, $readonly)) return false;
69
+    	if (!$id = self::getId($path)) {
70
+    		if (!$id = self::newId($path, $readonly)) return false;
71 71
     	} else {
72
-    		if (! $overwrite) return false;
72
+    		if (!$overwrite) return false;
73 73
     	}
74 74
 
75 75
     	self::findOrFail($id)->update(compact('value', 'readonly'));
@@ -88,13 +88,13 @@  discard block
 block discarded – undo
88 88
     {
89 89
     	$key = md5(serialize($path));
90 90
     	
91
-    	if (! isset(self::$cache['value'][$key])) {
92
-    		if(! $id = self::getId($path)) return false;
91
+    	if (!isset(self::$cache['value'][$key])) {
92
+    		if (!$id = self::getId($path)) return false;
93 93
 
94 94
     		self::$cache['value'][$key] = self::find($id)->value;
95 95
 	    }
96 96
 	    
97
-	    return $translate? __(self::$cache['value'][$key]): self::$cache['value'][$key];
97
+	    return $translate ? __(self::$cache['value'][$key]) : self::$cache['value'][$key];
98 98
     }
99 99
         
100 100
     /**
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     	$path = trim($path, '/');
113 113
     	
114 114
 		if ($id = self::getId($path)) {
115
-    		if (! $overwrite) {
115
+    		if (!$overwrite) {
116 116
     			self::extendArray($path, $array);
117 117
     			return true;
118 118
     		}
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     		self::find($id)->delete();
121 121
     	}
122 122
     			
123
-    	if(! $id = self::newId($path, $readonly)) return false;
123
+    	if (!$id = self::newId($path, $readonly)) return false;
124 124
     			
125 125
     	if ($overwrite) {
126 126
     		self::find($id)->update(compact('readonly'));
@@ -140,13 +140,13 @@  discard block
 block discarded – undo
140 140
      * @param $array array values to insert
141 141
      * @param $overwrite bool whether method should overwrite data if array key already exists, otherwise the data will be preserved
142 142
      */
143
-    public static function extendArray($path, $array, $overwrite=false, $readonly=false)
143
+    public static function extendArray($path, $array, $overwrite = false, $readonly = false)
144 144
     {
145 145
     	self::validateArrayKeys($array);
146 146
     	
147 147
     	$path = trim($path, '/');
148 148
     			
149
-    	if (! self::getId($path)){
149
+    	if (!self::getId($path)) {
150 150
     		return self::newArray($path, $array, $overwrite, $readonly);
151 151
     	}
152 152
 
@@ -172,8 +172,8 @@  discard block
 block discarded – undo
172 172
      * @param $path string
173 173
      * @return true on success, false otherwise
174 174
      */
175
-    public static function deleteArray($path){
176
-    	if (! $id = self::getId($path, true)) return false;
175
+    public static function deleteArray($path) {
176
+    	if (!$id = self::getId($path, true)) return false;
177 177
     	
178 178
     	self::find($id)->delete();
179 179
     	
@@ -188,11 +188,11 @@  discard block
 block discarded – undo
188 188
      */
189 189
     public static function getCollection($path, $silent = false)
190 190
     {
191
-    	if(isset(self::$cache['array'][$path])) {
191
+    	if (isset(self::$cache['array'][$path])) {
192 192
     		return self::$cache['array'][$path];
193 193
     	}
194 194
     	
195
-    	if (! $id = self::getId($path)) {
195
+    	if (!$id = self::getId($path)) {
196 196
     		if ($silent) return collect();
197 197
     		
198 198
     		throw new CommonDataNotFound('Invalid CommonData::getArray() request: ' . $path);
@@ -203,10 +203,10 @@  discard block
 block discarded – undo
203 203
     
204 204
     protected static function validateArrayKeys($array)
205 205
     {
206
-    	foreach($array as $key => $value) {
206
+    	foreach ($array as $key => $value) {
207 207
     		if (strpos($key, '/') === false) continue;
208 208
     		
209
-    		\Exception('Invalid common data key: '. $key);
209
+    		\Exception('Invalid common data key: ' . $key);
210 210
     	}
211 211
     }
212 212
 }
213 213
\ No newline at end of file
Please login to merge, or discard this patch.
src/CommonData/CommonDataSettings.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
 	{
31 31
 		ActionBar::addButton('back')->link(url('view/system'));
32 32
 		
33
-		$this->parentId = $this->stickyGet('parentId')?: null;
33
+		$this->parentId = $this->stickyGet('parentId') ?: null;
34 34
 		
35 35
 		$this->displayBreadCrumb();
36 36
 		
@@ -75,14 +75,14 @@  discard block
 block discarded – undo
75 75
 
76 76
 		$this->grid->setModel($model = $this->getModel());
77 77
 		
78
-		if ($model->action('count')->getOne() ) {
78
+		if ($model->action('count')->getOne()) {
79 79
 			$this->grid->on('click', 'td', new jsExpression(
80 80
 					'document.location=\'?parentId=\'+[]',
81 81
 					[(new jQuery())->closest('tr')->data('id')]
82 82
 			));
83 83
 		}
84 84
 		
85
-		$this->grid->addDragHandler()->onReorder(function ($order) {
85
+		$this->grid->addDragHandler()->onReorder(function($order) {
86 86
 			$result = true;
87 87
 			foreach ($this->nodes()->get() as $node) {
88 88
 				$node->position = array_search($node->id, $order);
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
 				$result &= $node->save();
91 91
 			}
92 92
 			
93
-			$notifier = $result? $this->notify(__('Items reordered!')): $this->notifyError(__('Error saving order!'));
93
+			$notifier = $result ? $this->notify(__('Items reordered!')) : $this->notifyError(__('Error saving order!'));
94 94
 			
95 95
 			return $this->grid->jsSave($notifier);
96 96
 		});
97 97
 		
98 98
 		$this->addContolButton('update', $this->getUpdateModal(), 'edit');
99 99
 			
100
-		$this->addContolButton('delete', function ($jschain, $id) {
100
+		$this->addContolButton('delete', function($jschain, $id) {
101 101
 			CommonData::find($id)->delete();
102 102
 				
103 103
 			return $jschain->closest('tr')->transition('fade left');
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
 			$ret .= $button->getHtml();
120 120
 		}
121 121
 		
122
-		return $ret;;
122
+		return $ret; ;
123 123
 	}
124 124
 	
125 125
 	public function getUpdateModal()
@@ -128,9 +128,9 @@  discard block
 block discarded – undo
128 128
 		
129 129
 		$grid->pageUpdate = $grid->add($grid->pageUpdate ?: $grid->pageDefault, ['short_name'=>'edit']);
130 130
 		
131
-		$modal = new jsModal(__('Edit'), $grid->pageUpdate, [$grid->name => $grid->jsRow()->data('id'), $grid->name.'_sort' => $grid->getSortBy()]);
131
+		$modal = new jsModal(__('Edit'), $grid->pageUpdate, [$grid->name => $grid->jsRow()->data('id'), $grid->name . '_sort' => $grid->getSortBy()]);
132 132
 		
133
-		$grid->pageUpdate->set(function () {
133
+		$grid->pageUpdate->set(function() {
134 134
 			$grid = $this->grid;
135 135
 			
136 136
 			$grid->model->load($grid->app->stickyGet($grid->name));
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 			// set save handler with reload trigger
150 150
 			// adds default submit hook if it is not already set for this form
151 151
 			if (!$grid->formUpdate->hookHasCallbacks('submit')) {
152
-				$grid->formUpdate->onSubmit(function ($form) {
152
+				$grid->formUpdate->onSubmit(function($form) {
153 153
 					$form->model->save();
154 154
 					
155 155
 					return $this->grid->jsSaveUpdate();
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
 		
167 167
 		$this->grid->on('click', ".$class", $callback, [$this->grid->table->jsRow()->data('id')]);
168 168
 		
169
-		$this->buttons[$name] = new \atk4\ui\Button($icon? compact('icon'): $name);
169
+		$this->buttons[$name] = new \atk4\ui\Button($icon ? compact('icon') : $name);
170 170
 		
171 171
 		$this->buttons[$name]->app = $this->app;
172 172
 		
@@ -193,7 +193,7 @@  discard block
 block discarded – undo
193 193
 		
194 194
 		$rowsEmpty = [];
195 195
 		
196
-		$model = new \atk4\data\Model($rows? new \atk4\data\Persistence_Static($rows): new \atk4\data\Persistence_Array($rowsEmpty));
196
+		$model = new \atk4\data\Model($rows ? new \atk4\data\Persistence_Static($rows) : new \atk4\data\Persistence_Array($rowsEmpty));
197 197
 		
198 198
 		$captions = [
199 199
 				'position' => __('Position'),
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 		];
204 204
 		
205 205
 		foreach ($captions as $key => $caption) {
206
-			$field = $rows? $model->hasField($key): $model->addField($key);
206
+			$field = $rows ? $model->hasField($key) : $model->addField($key);
207 207
 			
208 208
 			if ($key === 'readonly') {
209 209
 				$field->setDefaults(['ui' => ['visible' => false]]);
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
 	
220 220
 	public function getNodeForm()
221 221
 	{
222
-		if (! $this->form) {
222
+		if (!$this->form) {
223 223
 			$this->form = new Form(['buttonSave' => ['Button', __('Save'), 'primary']]);
224 224
 			
225 225
 			$this->form->addHook('submit', function($form) {
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
 				
234 234
 				CommonData::create(array_merge($values, [
235 235
 						'position' => $this->nodes()->max('position') + 1
236
-				]), $this->parentId? CommonData::find($this->parentId): null);
236
+				]), $this->parentId ? CommonData::find($this->parentId) : null);
237 237
 				
238 238
 				return $this->grid->jsSaveCreate();
239 239
 			});
Please login to merge, or discard this patch.