Form::addElements() - Code Metrics - Inspection of "[UPDATE] reorganize module structure" - x-systems/epesi-base - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 5ca280...347b45 )

by Georgi

created 2019-10-29 12:16 UTC

Form::addElements() B

↳ Parent: Form

Complexity

Conditions	11
Paths	14

Size

Total Lines	58
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	34
nc	14
nop	2
dl	0
loc	58
rs	7.3166
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Epesi\Base\Layout;

use atk4\ui\Form as BaseForm;
use atk4\ui\jsExpression;
use atk4\ui\jsFunction;
use Epesi\Core\Integration\Concerns\Notifies;
filter:
    dependency_paths: ["lib/*"]

class Form extends BaseForm
{
	use Notifies;
	
	public $buttonSave = null;
	
	protected $fieldRules = [];
	protected $validationRules = [];
	
	public function addElements($elements, $parent = null) {
		$parent = $parent?: $this;
		
		foreach ($elements as $name => $desc) {
			$name = $desc['name']?? $name;
			
			$this->addFieldRules($name, $desc['rules']?? []);
			
			switch ($desc['type']?? 'field') {
				case 'field':
					$desc = is_string($desc)? [
					'decorator' => [$desc]
					]: $desc;
					
					$field = $parent->addField($name, $desc['decorator']?? [], $desc['options']?? []);
					
					if ($default = $desc['default']) {
						$field->set($default);
					}
					
					if ($desc['display']?? false) {
						$this->addFieldsDisplayRules([$name => $desc['display']]);
					}
					break;
					
				case 'group':
					$seed = $desc['seed']?? [$name];
					
					$group = $parent->addGroup($seed);
					
					$this->addElements($desc['elements'], $group);
					
					if ($desc['display']?? false) {
						$this->addGroupDisplayRules([$name => $desc['display']]);
					}
					break;
					
				case 'header':
					$seed = $desc['seed']?? [$name];
					
					$parent->addHeader($seed);
					$parent->addHeader(/** @scrutinizer ignore-type */ $seed);
					break;
					
				case 'view':
					$seed = $desc['seed']?? ['Label', $name];
					
					$region = $desc['region']?? null;
					
					$this->add($seed, $region);
					break;
					
				default:
					;
					break;
			}
		}
		
		return $this;
	}
	
	public function addFieldsDisplayRules($fieldsDisplayRules) {
		$this->setFieldsDisplayRules(array_merge($this->fieldsDisplayRules?: [], $fieldsDisplayRules));
	}
	
	public function addGroupDisplayRules($groupDisplayRules) {
		$fieldsDisplayRules = $this->fieldsDisplayRules;
		
		$this->setGroupDisplayRules($groupDisplayRules);
		
		$this->addFieldsDisplayRules($fieldsDisplayRules);
	}
	
	public function addFieldRules($field, $rules = []) {
		if (! $rules) return;
		
		$this->fieldRules[$field] = $rules['rules']?? [
				'identifier' => $field,
				'rules' => $rules
		];
		
		return $this;
	}
	
	public function setValues($values)
	{
		foreach ($values?: [] as $name => $value) {
			if (! $field = $this->fields[$name]?? null) continue;
			
			$field->set($value);
		}
		
		return $this;
	}
	
	public function getValues()
	{
		return $this->model->get();
	}
	
	public function validate($callback)
	{
		$this->setApiConfig([
				'beforeSend' => new jsFunction(['settings'], [new jsExpression('return $(this).form("is valid")')]),
		]);
		
		$this->setFormConfig([
				'fields' => $this->fieldRules
		]);
		
		$this->onSubmit(function ($form) use ($callback) {
			$errors = [];
			foreach ($this->validationRules?: [] as $ruleCallback) {
				if (! is_callable($ruleCallback)) continue;
				
				$ruleErrors = $ruleCallback($form);
				
				$errors = array_merge($errors, $ruleErrors?: []);
			}
			
			return $errors?: $callback($this);
		});
			
			return $this;
	}
	
	public function submit()
	{
		return $this->js()->form('submit');
	}
	
	public function confirmLeave($confirm = true)
	{
		$this->canLeave = ! $confirm;
		
		return $this;
	}
}

x-systems / epesi-base

Push — master ( 5ca280...347b45 )

Form::addElements() B

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like