AbstractXML::getXMLWriter() - Code Metrics - Inspection of "Improve test, some fixes and code formatting" - wszetko/sitemap - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7fe6b0...d8a5ea )

by Paweł

created 2019-09-13 11:37 UTC

AbstractXML::getXMLWriter() A

↳ Parent: AbstractXML

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

/**
 * This file is part of Wszetko Sitemap.
 *
 * (c) Paweł Kłopotek-Główczewski <[email protected]>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Wszetko\Sitemap\Drivers\XML;

use Wszetko\Sitemap\Interfaces\XML;
use Wszetko\Sitemap\Traits\Domain;
use Wszetko\Sitemap\Traits\IsAssoc;

/**
 * Class AbstractXML.
 *
 * @package Wszetko\Sitemap\Drivers\XML
 */
abstract class AbstractXML implements XML
{
    use IsAssoc;
    use Domain;

    /**
     * @var mixed
     */
    protected $XMLWriter;

    /**
     * @var string
     */
    private $currentSitemap;

    /**
     * @var null|string
     */
    private $workDir;

    /**
     * @return string
     */
    public function getCurrentSitemap(): string
    {
        return $this->currentSitemap;
    }

    /**
     * @param string $currentSitemap
     */
    public function setCurrentSitemap(string $currentSitemap): void
    {
        $this->currentSitemap = $currentSitemap;
    }

    /**
     * @return string
     */
    public function getWorkDir(): string
    {
        return $this->workDir;

    }

    /**
     * @param string $dir
     */
    public function setWorkDir(string $dir): void
    {
        $this->workDir = $dir;
    }

    /**
     * @return mixed
     */
    protected function getXMLWriter()
    {
        return $this->XMLWriter;
    }

    /**
     * @return string
     */
    protected function getSitemapFileFullPath(): string
    {
        return $this->getWorkDir() . DIRECTORY_SEPARATOR . $this->currentSitemap;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/**
6		* This file is part of Wszetko Sitemap.
7		*
8		* (c) Paweł Kłopotek-Główczewski <[email protected]>
9		*
10		* This source file is subject to the MIT license that is bundled
11		* with this source code in the file LICENSE.
12		*/
13
14		namespace Wszetko\Sitemap\Drivers\XML;
15
16		use Wszetko\Sitemap\Interfaces\XML;
17		use Wszetko\Sitemap\Traits\Domain;
18		use Wszetko\Sitemap\Traits\IsAssoc;
19
20		/**
21		* Class AbstractXML.
22		*
23		* @package Wszetko\Sitemap\Drivers\XML
24		*/
25		abstract class AbstractXML implements XML
26		{
27		use IsAssoc;
28		use Domain;
29
30		/**
31		* @var mixed
32		*/
33		protected $XMLWriter;
34
35		/**
36		* @var string
37		*/
38		private $currentSitemap;
39
40		/**
41		* @var null\|string
42		*/
43		private $workDir;
44
45		/**
46		* @return string
47		*/
48	2	public function getCurrentSitemap(): string
49		{
50	2	return $this->currentSitemap;
51		}
52
53		/**
54		* @param string $currentSitemap
55		*/
56	8	public function setCurrentSitemap(string $currentSitemap): void
57		{
58	8	$this->currentSitemap = $currentSitemap;
59	8	}
60
61		/**
62		* @return string
63		*/
64	8	public function getWorkDir(): string
65		{
66	8	return $this->workDir;
		0 ignored issues – show Bug Best Practice introduced 2019-09-12 11:57 UTC by Report Bug Copy Issue Report The expression `return $this->workDir` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
67		}
68
69		/**
70		* @param string $dir
71		*/
72	8	public function setWorkDir(string $dir): void
73		{
74	8	$this->workDir = $dir;
75	8	}
76
77		/**
78		* @return mixed
79		*/
80	6	protected function getXMLWriter()
81		{
82	6	return $this->XMLWriter;
83		}
84
85		/**
86		* @return string
87		*/
88	6	protected function getSitemapFileFullPath(): string
89		{
90	6	return $this->getWorkDir() . DIRECTORY_SEPARATOR . $this->currentSitemap;
91		}
92		}
93

wszetko / sitemap

Push — master ( 7fe6b0...d8a5ea )

AbstractXML::getXMLWriter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like