Wszetko\Sitemap\Items\DataTypes\URLType

Complexity

Total Complexity

7

Size/Duplication

Total Lines	45
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getValue()	0	24	6
A	isExternal()	0	4	1

<?php
declare(strict_types=1);

namespace Wszetko\Sitemap\Items\DataTypes;

use Wszetko\Sitemap\Helpers\Url;
use Wszetko\Sitemap\Traits\Domain;

/**
 * Class URLType
 *
 * @package Wszetko\Sitemap\Items\DataTypes
 */
class URLType extends StringType
{
    /**
     * Determine if URL CAN be external
     *
     * @var bool
     */
    protected $external = false;

    /**
     * @return mixed|string|null
     */
    public function getValue()
    {
        if ($this->isExternal() && Url::normalizeUrl($this->value)) {

It seems like $this->value can also be of type array or null; however, Wszetko\Sitemap\Helpers\Url::normalizeUrl() does only seem to accept string, maybe add an additional type check?

The expression \Wszetko\Sitemap\Helpers\Url::normalizeUrl($this->value) of type false|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            $value = $this->value;
        } else {
            $value = str_replace($this->getDomain(), '', $this->value);

            if (!empty($value)) {
                $value = $this->getDomain() . '/' . ltrim($value, '/');
            } else {
                $value = null;
            }
        }

        if (!empty($value)) {
            $attributes = $this->getAttributes();

            if (!empty($attributes)) {
                return [$value => $attributes];
            } else {
                return $value;
            }
        }
    }

    /**
     * @return bool
     */
    public function isExternal(): bool
    {
        return $this->external;
    }
}