WShafer\SwooleExpressive\Bridge\SwooleResponseEmitter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	toSwoole()	0	8	1
A	populateHeaders()	0	17	3
A	sendResponse()	0	8	1

<?php
declare(strict_types=1);

namespace WShafer\SwooleExpressive\Bridge;

use Psr\Http\Message\ResponseInterface;
use Swoole\Http\Response as SwooleResponse;
use Zend\HttpHandlerRunner\Emitter\SapiEmitterTrait;

class SwooleResponseEmitter
{
    use SapiEmitterTrait;

    public function toSwoole(
        ResponseInterface $psr7Response,
        SwooleResponse $swooleResponse = null
    ) {
        $swooleResponse->status($psr7Response->getStatusCode());
        $this->populateHeaders($psr7Response, $swooleResponse);

It seems like $swooleResponse defined by parameter $swooleResponse on line 16 can be null; however, WShafer\SwooleExpressive\Bridge\SwooleResponseEmitter::populateHeaders() does not accept null, maybe add an additional type check?

        $this->sendResponse($psr7Response, $swooleResponse);

It seems like $swooleResponse defined by parameter $swooleResponse on line 16 can be null; however, WShafer\SwooleExpressive\Bridge\SwooleResponseEmitter::sendResponse() does not accept null, maybe add an additional type check?

    }

    protected function populateHeaders(
        ResponseInterface $psr7Response,
        SwooleResponse $swooleResponse
    ) {
        $headers = $psr7Response->getHeaders();

        foreach ($headers as $name => $values) {
            $name  = $this->filterHeader($name);

            if ($name === 'Set-Cookie') {
                $swooleResponse->header($name, end($values));
                continue;
            }

            $swooleResponse->header($name, implode(', ', $values));
        }
    }

    protected function sendResponse(
        ResponseInterface $psr7Response,
        SwooleResponse $swooleResponse
    ) {
        $content = $psr7Response->getBody();
        $content->rewind();
        $swooleResponse->end($content->getContents());
    }
}