AbstractServiceManager::has() - Code Metrics - Inspection of "Added services and modified config classes" - wshafer/psr11-monolog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d1d70...5b3b49 )

by Westin

created 2017-07-19 20:26 UTC

AbstractServiceManager::has() B

↳ Parent: AbstractServiceManager

Complexity

Conditions	6
Paths	4

Size

Total Lines	22
Code Lines	11

Duplication

Lines	5
Ratio	22.73 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
dl	5
loc	22
ccs	0
cts	7
cp	0
rs	8.6737
c	0
b	0
f	0
cc	6
eloc	11
nc	4
nop	1
crap	42

<?php

namespace WShafer\PSR11MonoLog\Service;

use Psr\Container\ContainerInterface;
use WShafer\PSR11MonoLog\Config\MainConfig;
use WShafer\PSR11MonoLog\ConfigInterface;
use WShafer\PSR11MonoLog\Exception\UnknownServiceException;
use WShafer\PSR11MonoLog\FactoryInterface;
use WShafer\PSR11MonoLog\MapperInterface;

abstract class AbstractServiceManager implements ContainerInterface
{
    /** @var MainConfig */
    protected $config;

    /** @var MapperInterface */
    protected $mapper;

    /** @var ContainerInterface */
    protected $container;

    /** @var array */
    protected $services;
    
    const INTERFACE = '';

    public function __construct(
        MainConfig $config,
        MapperInterface $mapper,
        ContainerInterface $container
    ) {
        $this->config    = $config;
        $this->mapper    = $mapper;
        $this->container = $container;
    }

    abstract protected function getServiceConfig($id) : ConfigInterface;

    public function get($id)
    {
        $interface = self::INTERFACE;
        
        if (key_exists($id, $this->services)

            && $this->services[$id] instanceof $interface
        ) {
            return $this->services[$id];
        }

        // Make sure we have one of these
        if (!$this->has($id)) {
            throw new UnknownServiceException(
                'Unable to locate service '.$id.'.  Please check your configuration.'
            );
        }

        // Check the main container for this service id.
        if ($this->container->has($id)) {
            $this->services[$id] = $this->container->get($id);
            return $this->services[$id];
        }

        // Check for class and class implements of Monolog Interface
        if (class_exists($id)
            && in_array($interface, class_implements($id))
        ) {
            $this->services[$id] = new $id;
            return $this->services[$id];
        }

        $this->services[$id] = $this->getInstanceFromFactory($id);
        return $this->services[$id];
    }

    public function has($id)
    {
        $interface = self::INTERFACE;

        if (key_exists($id, $this->services)

            && $this->services[$id] instanceof $interface
        ) {
            return true;
        }

        if ($this->container->has($id)) {
            return true;
        }

        if (class_exists($id)
            && in_array($interface, class_implements($id))
        ) {
            return true;
        }

        return $this->config->hasHandlerConfig($id);
    }

    protected function getInstanceFromFactory($id)
    {
        $class   = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $config  = $this->getServiceConfig($id);
        $type    = $config->getType();
        $options = $config->getOptions();

        $class = $type;

        // Check for class and class implements of Monolog Formatter Interface
        if (!class_exists($class)
            || !in_array(FactoryInterface::class, class_implements($class))
        ) {
            $class = $this->mapper->map($type);
        }

        if (!class_exists($class)
            || !in_array(FactoryInterface::class, class_implements($class))
        ) {
            throw new UnknownServiceException(
                'Unable to locate service '.$id.'.  Please check your configuration.'
            );
        }

        /** @var FactoryInterface $factory */
        $factory = new $class;
        return $factory($options);
    }
}


1		<?php
2
3		namespace WShafer\PSR11MonoLog\Service;
4
5		use Psr\Container\ContainerInterface;
6		use WShafer\PSR11MonoLog\Config\MainConfig;
7		use WShafer\PSR11MonoLog\ConfigInterface;
8		use WShafer\PSR11MonoLog\Exception\UnknownServiceException;
9		use WShafer\PSR11MonoLog\FactoryInterface;
10		use WShafer\PSR11MonoLog\MapperInterface;
11
12		abstract class AbstractServiceManager implements ContainerInterface
13		{
14		/** @var MainConfig */
15		protected $config;
16
17		/** @var MapperInterface */
18		protected $mapper;
19
20		/** @var ContainerInterface */
21		protected $container;
22
23		/** @var array */
24		protected $services;
25
26		const INTERFACE = '';
27
28		public function __construct(
29		MainConfig $config,
30		MapperInterface $mapper,
31		ContainerInterface $container
32		) {
33		$this->config = $config;
34		$this->mapper = $mapper;
35		$this->container = $container;
36		}
37
38		abstract protected function getServiceConfig($id) : ConfigInterface;
39
40		public function get($id)
41		{
42		$interface = self::INTERFACE;
43
44	View Code Duplication	if (key_exists($id, $this->services)
		0 ignored issues – show Duplication introduced 2017-07-19 20:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		&& $this->services[$id] instanceof $interface
46		) {
47		return $this->services[$id];
48		}
49
50		// Make sure we have one of these
51		if (!$this->has($id)) {
52		throw new UnknownServiceException(
53		'Unable to locate service '.$id.'. Please check your configuration.'
54		);
55		}
56
57		// Check the main container for this service id.
58		if ($this->container->has($id)) {
59		$this->services[$id] = $this->container->get($id);
60		return $this->services[$id];
61		}
62
63		// Check for class and class implements of Monolog Interface
64		if (class_exists($id)
65		&& in_array($interface, class_implements($id))
66		) {
67		$this->services[$id] = new $id;
68		return $this->services[$id];
69		}
70
71		$this->services[$id] = $this->getInstanceFromFactory($id);
72		return $this->services[$id];
73		}
74
75		public function has($id)
76		{
77		$interface = self::INTERFACE;
78
79	View Code Duplication	if (key_exists($id, $this->services)
		0 ignored issues – show Duplication introduced 2017-07-19 20:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
80		&& $this->services[$id] instanceof $interface
81		) {
82		return true;
83		}
84
85		if ($this->container->has($id)) {
86		return true;
87		}
88
89		if (class_exists($id)
90		&& in_array($interface, class_implements($id))
91		) {
92		return true;
93		}
94
95		return $this->config->hasHandlerConfig($id);
96		}
97
98		protected function getInstanceFromFactory($id)
99		{
100		$class = null;
		0 ignored issues – show Unused Code introduced 2017-07-19 20:28 UTC by Report Bug Copy Issue Report `$class` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
101
102		$config = $this->getServiceConfig($id);
103		$type = $config->getType();
104		$options = $config->getOptions();
105
106		$class = $type;
107
108		// Check for class and class implements of Monolog Formatter Interface
109		if (!class_exists($class)
110		\|\| !in_array(FactoryInterface::class, class_implements($class))
111		) {
112		$class = $this->mapper->map($type);
113		}
114
115		if (!class_exists($class)
116		\|\| !in_array(FactoryInterface::class, class_implements($class))
117		) {
118		throw new UnknownServiceException(
119		'Unable to locate service '.$id.'. Please check your configuration.'
120		);
121		}
122
123		/** @var FactoryInterface $factory */
124		$factory = new $class;
125		return $factory($options);
126		}
127		}
128

wshafer / psr11-monolog

Push — master ( 6d1d70...5b3b49 )

AbstractServiceManager::has() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like