FingersCrossedHandlerFactory::getActivationStrategy() - Code Metrics - Inspection of "Spiecial handlers" - wshafer/psr11-monolog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Westin

created 2017-08-28 22:45 UTC

getActivationStrategy() A

↳ Parent: FingersCrossedHandlerFactory

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	14
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	7
nc	3
nop	1
crap	3

<?php
declare(strict_types=1);

namespace WShafer\PSR11MonoLog\Handler;

use Monolog\Handler\FingersCrossedHandler;
use WShafer\PSR11MonoLog\HandlerManagerAwareInterface;
use WShafer\PSR11MonoLog\HandlerManagerTrait;
use WShafer\PSR11MonoLog\ContainerAwareInterface;
use WShafer\PSR11MonoLog\ContainerTrait;
use WShafer\PSR11MonoLog\FactoryInterface;

class FingersCrossedHandlerFactory implements FactoryInterface, HandlerManagerAwareInterface, ContainerAwareInterface
{
    use ContainerTrait;
    use HandlerManagerTrait;

    public function __invoke(array $options)
    {
        $handler            = $this->getHandlerManager()->get($options['handler']);
        $activationStrategy = $this->getActivationStrategy($options);
        $bufferSize         = (int)     ($options['bufferSize']    ?? 0);
        $bubble             = (boolean) ($options['bubble']        ?? true);
        $stopBuffering      = (boolean) ($options['stopBuffering'] ?? true);
        $passthruLevel      =            $options['passthruLevel'] ?? null;

        return new FingersCrossedHandler(
            $handler,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $activationStrategy,
            $bufferSize,
            $bubble,
            $stopBuffering,
            $passthruLevel
        );
    }

    protected function getActivationStrategy($options)
    {
        $activationStrategy = $options['activationStrategy'] ?? null;

        if (!$activationStrategy) {
            return null;
        }

        if ($this->getContainer()->has($activationStrategy)) {
            return $this->getContainer()->get($activationStrategy);
        }

        return $activationStrategy;
    }
}


1		<?php
2		declare(strict_types=1);
3
4		namespace WShafer\PSR11MonoLog\Handler;
5
6		use Monolog\Handler\FingersCrossedHandler;
7		use WShafer\PSR11MonoLog\HandlerManagerAwareInterface;
8		use WShafer\PSR11MonoLog\HandlerManagerTrait;
9		use WShafer\PSR11MonoLog\ContainerAwareInterface;
10		use WShafer\PSR11MonoLog\ContainerTrait;
11		use WShafer\PSR11MonoLog\FactoryInterface;
12
13		class FingersCrossedHandlerFactory implements FactoryInterface, HandlerManagerAwareInterface, ContainerAwareInterface
14		{
15		use ContainerTrait;
16		use HandlerManagerTrait;
17
18	3	public function __invoke(array $options)
19		{
20	3	$handler = $this->getHandlerManager()->get($options['handler']);
21	3	$activationStrategy = $this->getActivationStrategy($options);
22	3	$bufferSize = (int) ($options['bufferSize'] ?? 0);
23	3	$bubble = (boolean) ($options['bubble'] ?? true);
24	3	$stopBuffering = (boolean) ($options['stopBuffering'] ?? true);
25	3	$passthruLevel = $options['passthruLevel'] ?? null;
26
27	3	return new FingersCrossedHandler(
28	3	$handler,
		0 ignored issues – show Documentation introduced 2017-08-28 22:46 UTC by Report Bug Copy Issue Report `$handler` is of type `*`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29	3	$activationStrategy,
30	3	$bufferSize,
31	3	$bubble,
32	3	$stopBuffering,
33	3	$passthruLevel
34		);
35		}
36
37	3	protected function getActivationStrategy($options)
38		{
39	3	$activationStrategy = $options['activationStrategy'] ?? null;
40
41	3	if (!$activationStrategy) {
42	1	return null;
43		}
44
45	2	if ($this->getContainer()->has($activationStrategy)) {
46	1	return $this->getContainer()->get($activationStrategy);
47		}
48
49	1	return $activationStrategy;
50		}
51		}
52

wshafer / psr11-monolog

Pull Request — master (#2)

getActivationStrategy() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like