HtmlConversion::convertHtmlToOpenXMLTag() - Code Metrics - Inspection of "Fixing HTML conversion for single runs" - wrklst/docxmustache - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8119b8...50b35d )

by Tobias

created 2017-10-21 17:20 UTC

HtmlConversion::convertHtmlToOpenXMLTag() B

↳ Parent: HtmlConversion

Complexity

Conditions	6
Paths	10

Size

Total Lines	67
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	67
rs	8.5896
cc	6
eloc	35
nc	10
nop	2

How to fix Long Method

<?php

namespace WrkLst\DocxMustache;

class HtmlConversion
{
    /**
     * @param string $value
     */
    public static function convert($value)
    {
        $line_breaks = ['&lt;br /&gt;', '&lt;br/&gt;', '&lt;br&gt;', '<br />', '<br/>', '<br>'];
        $value = str_replace($line_breaks, '</w:t><w:br/><w:t xml:space="preserve">', $value);

        $value = self::convertHtmlToOpenXMLTag($value, 'b');
        $value = self::convertHtmlToOpenXMLTag($value, 'i');
        $value = self::convertHtmlToOpenXMLTag($value, 'u');

        return $value;
    }

    public static function convertHtmlToOpenXMLTag($value, $tag = 'b')
    {
        $value_array = [];
        $run_again = false;
        //this could be used instead if html was already escaped
        /*
        $bo = "&lt;";
        $bc = "&gt;";
        */
        $bo = '<';
        $bc = '>';

        //get first BOLD
        $tag_open_values = explode($bo.$tag.$bc, $value, 2);

        if (count($tag_open_values) > 1) {
            //save everything before the bold and close it
            $value_array[] = $tag_open_values[0];
            $value_array[] = '</w:t></w:r>';

            if($tag=="u")
            {
                $tag_ooxml = 'u w:val="single" ';
                $loose_formatting = "";
            }
            elseif($tag=="b")
            {
                $tag_ooxml = 'b ';
                $loose_formatting = "";
            }
            elseif($tag=="i")
            {
                $tag_ooxml = 'i ';
                $loose_formatting = "<w:i w:val=\"0\"/>";
            }

            //define styling parameters
            $wrPr_open = strrpos($tag_open_values[0], '<w:rPr>');
            $wrPr_close = strrpos($tag_open_values[0], '</w:rPr>', $wrPr_open);
            $neutral_style = '<w:r><w:rPr>'.substr($tag_open_values[0], ($wrPr_open + 7), ($wrPr_close - ($wrPr_open + 7))).'</w:rPr><w:t xml:space="preserve">';
            $tagged_style = '<w:r><w:rPr><w:'.$tag_ooxml.'/>'.str_replace($loose_formatting,"",substr($tag_open_values[0], ($wrPr_open + 7), ($wrPr_close - ($wrPr_open + 7)))).'</w:rPr><w:t xml:space="preserve">';
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

            //open new text run and make it bold, include previous styling
            $value_array[] = $tagged_style;
            //get everything before bold close and after
            $tag_close_values = explode($bo.'/'.$tag.$bc, $tag_open_values[1], 2);
            //add bold text
            $value_array[] = $tag_close_values[0];
            //close bold run
            $value_array[] = '</w:t></w:r>';
            //open run for after bold
            $value_array[] = $neutral_style;
            $value_array[] = $tag_close_values[1];

            $run_again = true;
        } else {
            $value_array[] = $tag_open_values[0];
        }

        $value = implode('', $value_array);

        if ($run_again) {
            $value = self::convertHtmlToOpenXMLTag($value, $tag);
        }

        return $value;
    }
}


1			<?php
2
3			namespace WrkLst\DocxMustache;
4
5			class HtmlConversion
6			{
7			/**
8			* @param string $value
9			*/
10			public static function convert($value)
11			{
12			$line_breaks = ['<br />', '<br/>', '<br>', '<br />', '<br/>', '<br>'];
13			$value = str_replace($line_breaks, '</w:t><w:br/><w:t xml:space="preserve">', $value);
14
15			$value = self::convertHtmlToOpenXMLTag($value, 'b');
16			$value = self::convertHtmlToOpenXMLTag($value, 'i');
17			$value = self::convertHtmlToOpenXMLTag($value, 'u');
18
19			return $value;
20			}
21
22			public static function convertHtmlToOpenXMLTag($value, $tag = 'b')
23			{
24			$value_array = [];
25			$run_again = false;
26			//this could be used instead if html was already escaped
27			/*
28			$bo = "<";
29			$bc = ">";
30			*/
31			$bo = '<';
32			$bc = '>';
33
34			//get first BOLD
35			$tag_open_values = explode($bo.$tag.$bc, $value, 2);
36
37			if (count($tag_open_values) > 1) {
38			//save everything before the bold and close it
39			$value_array[] = $tag_open_values[0];
40			$value_array[] = '</w:t></w:r>';
41
42			if($tag=="u")
43			{
44			$tag_ooxml = 'u w:val="single" ';
45			$loose_formatting = "";
46			}
47			elseif($tag=="b")
48			{
49			$tag_ooxml = 'b ';
50			$loose_formatting = "";
51			}
52			elseif($tag=="i")
53			{
54			$tag_ooxml = 'i ';
55			$loose_formatting = "<w:i w:val=\"0\"/>";
56			}
57
58			//define styling parameters
59			$wrPr_open = strrpos($tag_open_values[0], '<w:rPr>');
60			$wrPr_close = strrpos($tag_open_values[0], '</w:rPr>', $wrPr_open);
61			$neutral_style = '<w:r><w:rPr>'.substr($tag_open_values[0], ($wrPr_open + 7), ($wrPr_close - ($wrPr_open + 7))).'</w:rPr><w:t xml:space="preserve">';
62			$tagged_style = '<w:r><w:rPr><w:'.$tag_ooxml.'/>'.str_replace($loose_formatting,"",substr($tag_open_values[0], ($wrPr_open + 7), ($wrPr_close - ($wrPr_open + 7)))).'</w:rPr><w:t xml:space="preserve">';
			0 ignored issues – show Bug introduced 2017-10-21 17:22 UTC by Report Bug Copy Issue Report The variable `$tag_ooxml` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history... Bug introduced 2017-10-21 17:22 UTC by Report Bug Copy Issue Report The variable `$loose_formatting` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
63
64			//open new text run and make it bold, include previous styling
65			$value_array[] = $tagged_style;
66			//get everything before bold close and after
67			$tag_close_values = explode($bo.'/'.$tag.$bc, $tag_open_values[1], 2);
68			//add bold text
69			$value_array[] = $tag_close_values[0];
70			//close bold run
71			$value_array[] = '</w:t></w:r>';
72			//open run for after bold
73			$value_array[] = $neutral_style;
74			$value_array[] = $tag_close_values[1];
75
76			$run_again = true;
77			} else {
78			$value_array[] = $tag_open_values[0];
79			}
80
81			$value = implode('', $value_array);
82
83			if ($run_again) {
84			$value = self::convertHtmlToOpenXMLTag($value, $tag);
85			}
86
87			return $value;
88			}
89			}
90

wrklst / docxmustache

Push — master ( 8119b8...50b35d )

HtmlConversion::convertHtmlToOpenXMLTag() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like