writesdown / app-cms

backend/controllers/MenuController.php

<?php
/**
 * @link http://www.writesdown.com/
 * @copyright Copyright (c) 2015 WritesDown
 * @license http://www.writesdown.com/license/
 */

namespace backend\controllers;

use common\components\Json;
use common\models\Menu;
use common\models\MenuItem;
use common\models\Post;
use common\models\PostType;
use common\models\Taxonomy;
use common\models\Term;
use Yii;
use yii\filters\AccessControl;
use yii\filters\VerbFilter;
use yii\helpers\ArrayHelper;
use yii\web\Controller;
use yii\web\NotFoundHttpException;

/**
 * MenuController, controlling the actions for Menu and MenuItem model.
 *
 * @author Agiel K. Saputra <13nightevil@gmail.com>
 * @since 0.1.0
 */
class MenuController extends Controller
{
    /**
     * @inheritdoc
     */
    public function behaviors()

This method seems to be duplicated in your project.

    {
        return [
            'access' => [
                'class' => AccessControl::className(),
                'rules' => [
                    [
                        'actions' => ['index', 'update', 'create', 'delete', 'create-menu-item', 'delete-menu-item'],
                        'allow' => true,
                        'roles' => ['administrator'],
                    ],
                ],
            ],
            'verbs' => [
                'class' => VerbFilter::className(),
                'actions' => [
                    'delete' => ['post'],
                    'update' => ['post'],
                    'create-menu-item' => ['post'],
                    'delete-menu-item' => ['post'],
                ],
            ],
        ];
    }

    /**
     * Displays menu page consists of CRUD for Menu and MenuItem model.
     *
     * @param null $id
     * @return mixed
     */
    public function actionIndex($id = null)
    {
        $model = new Menu();
        $postTypes = PostType::find()->where(['menu_builder' => PostType::MENU_BUILDER])->all();
        $taxonomies = Taxonomy::find()->where(['menu_builder' => Taxonomy::MENU_BUILDER])->all();

        if ($available = ArrayHelper::map(Menu::find()->all(), 'id', 'title')) {
            if ($id === null && $available) {

The expression $available of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

                reset($available);
                $id = key($available);
            }
            $selected = $this->findModel($id);
        }

        return $this->render('index', [
            'model' => $model,
            'available' => $available,
            'selected' => isset($selected) ? $selected : null,
            'postTypes' => $postTypes,
            'taxonomies' => $taxonomies,
        ]);
    }

    /**
     * Creates a new Menu model.
     * If creation is successful, the browser will be redirected to the 'index' page.
     *
     * @return mixed
     */
    public function actionCreate()
    {
        $model = new Menu();

        if ($model->load(Yii::$app->request->post()) && $model->save()) {
            return $this->redirect(['index', 'id' => $model->id]);
        }

        return $this->redirect(['index']);
    }

    /**
     * Updates an existing Menu model.
     * If update is successful, the browser will be redirected to the 'view' page.
     *
     * @param integer $id
     * @return mixed
     */
    public function actionUpdate($id)
    {
        $model = $this->findModel($id);

        if ($model->load(Yii::$app->request->post()) && $model->save()) {

The method load cannot be called on $model (of type array|boolean).

The method save cannot be called on $model (of type array|boolean).

            if ($menuOrder = Yii::$app->request->post('MenuOrder')) {
                $this->saveMenuItem(Json::decode($menuOrder));
            }
        }

        Yii::$app->getSession()->setFlash('success', Yii::t('writesdown', 'Menu successfully saved.'));

The method getSession does only exist in yii\web\Application, but not in yii\console\Application.

        return $this->redirect(['/menu/index', 'id' => $id]);
    }

    /**
     * Deletes an existing Menu model.
     * If deletion is successful, the browser will be redirected to the 'index' page.
     *
     * @return mixed
     * @throws NotFoundHttpException
     * @throws \Exception
     */
    public function actionDelete()
    {
        $id = Yii::$app->request->post('id');
        $this->findModel($id)->delete();

The method delete cannot be called on $this->findModel($id) (of type array|boolean).

        return $this->redirect(['index']);
    }

    /**
     * Create MenuItem models.
     *
     * @param int $id
     * @return string
     */
    public function actionCreateMenuItem($id)
    {
        $items = '';

        if (Yii::$app->request->post('type') === 'link') {
            $model = new MenuItem();
            $model->menu_id = $id;
            if ($model->load(Yii::$app->request->post()) && $model->save()) {
                $items .= $this->renderPartial('_render-item', ['item' => $model, 'wrap' => 'true']);
            }
        }

        if (Yii::$app->request->post('type') === 'post' && $postIds = Yii::$app->request->post('postIds')) {

This code seems to be duplicated across your project.

            foreach ($postIds as $postId) {
                if ($post = $this->findPost($postId)) {
                    $model = new MenuItem([
                        'menu_id' => $id,
                        'label' => $post->title,
                        'url' => $post->getUrl(),

The method getUrl cannot be called on $post (of type array|boolean).

                    ]);
                    if ($model->save()) {
                        $items .= $this->renderPartial('_render-item', ['item' => $model, 'wrap' => 'true']);
                    }
                }
            }
        }

        if (Yii::$app->request->post('type') === 'taxonomy' && $termIds = Yii::$app->request->post('termIds')) {

This code seems to be duplicated across your project.

            foreach ($termIds as $termId) {
                if ($term = $this->findTerm($termId)) {
                    $model = new MenuItem([
                        'menu_id' => $id,
                        'label' => $term->name,
                        'url' => $term->getUrl(),

The method getUrl cannot be called on $term (of type array|boolean).

                    ]);
                    if ($model->save()) {
                        $items .= $this->renderPartial('_render-item', ['item' => $model, 'wrap' => 'true']);
                    }
                }
            }
        }

        return $items;
    }

    /**
     * Delete an existing MenuItem model via AJAX request.
     *
     * @throws NotFoundHttpException
     * @throws \Exception
     */
    public function actionDeleteMenuItem()
    {
        /* @var $children \common\models\MenuItem[] */
        if ($id = Yii::$app->request->post('id')) {
            $model = $this->findMenuItem($id);
            if ($model && $model->delete()) {

The method delete cannot be called on $model (of type array|boolean).

                $children = MenuItem::find()->where(['parent' => $model->id])->all();
                foreach ($children as $child) {
                    $child->updateAttributes(['parent' => $model->parent]);
                }
            } else {
                throw new NotFoundHttpException(Yii::t('writesdown', 'The requested page does not exist.'));
            }
        }
    }

    /**
     * Save menu item recursively based on parent and child.
     *
     * @param array $menuOrder
     * @param int $menuParent
     */
    protected function saveMenuItem($menuOrder, $menuParent = 0)
    {
        foreach ($menuOrder as $key => $order) {
            $menuItem = Yii::$app->request->post('MenuItem')[$order['id']];
            if ($model = $this->findMenuItem($order['id'])) {
                $model->setAttributes($menuItem);

The method setAttributes cannot be called on $model (of type array|boolean).

                $model->setAttributes([

The method setAttributes cannot be called on $model (of type array|boolean).

                    'parent' => $menuParent,
                    'order' => $key,
                ]);
                if ($model->save()) {

The method save cannot be called on $model (of type array|boolean).

                    if ($orderItems = ArrayHelper::getValue($order, 'items')) {
                        $this->saveMenuItem($orderItems, $model->id);
                    }
                }
            }
        }
    }

    /**
     * Finds the Menu model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     *
     * @param integer $id
     * @return Menu the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($id)
    {
        if (($model = Menu::findOne($id)) !== null) {
            return $model;
        }

        throw new NotFoundHttpException(Yii::t('writesdown', 'The requested page does not exist.'));
    }

    /**
     * Finds the MenuItem model based on its primary key value.
     * If the model is not found, it will return false.
     *
     * @param integer $id
     * @return MenuItem the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findMenuItem($id)
    {
        if (($model = MenuItem::findOne($id)) !== null) {
            return $model;
        }

        throw new NotFoundHttpException(Yii::t('writesdown', 'The requested page does not exist.'));
    }

    /**
     * Finds the Post model based on its primary key value.
     * If the model is not found, it will return false.
     *
     * @param integer $id
     * @return Post the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findPost($id)
    {
        if (($model = Post::findOne($id)) !== null) {
            return $model;
        }

        throw new NotFoundHttpException(Yii::t('writesdown', 'The requested page does not exist.'));
    }

    /**
     * Finds the Term model based on its primary key value.
     * If the model is not found, it will return false.
     *
     * @param integer $id
     * @return Term the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findTerm($id)
    {
        if (($model = Term::findOne($id)) !== null) {
            return $model;
        }

        throw new NotFoundHttpException(Yii::t('writesdown', 'The requested page does not exist.'));
    }
}