Post::search() - Code Metrics - writesdown/app-cms - Measure and Improve Code Quality continuously with Scrutinizer

Post::search() A
last analyzed 2016-04-17 09:32 UTC

↳ Parent: Post

Complexity

Conditions	3
Paths	4

Size

Total Lines	53
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	53
rs	9.5797
cc	3
eloc	35
nc	4
nop	3

How to fix Long Method

<?php
/**
 * @link http://www.writesdown.com/
 * @copyright Copyright (c) 2015 WritesDown
 * @license http://www.writesdown.com/license/
 */

namespace common\models\search;

use common\models\Post as PostModel;
use Yii;
use yii\base\Model;
use yii\data\ActiveDataProvider;
use yii\helpers\ArrayHelper;

/**
 * Post represents the model behind the search form about `common\models\Post`.
 *
 * @author Agiel K. Saputra <[email protected]>
 * @since 0.1.0
 */
class Post extends PostModel
{
    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['id', 'author', 'type', 'comment_count'], 'integer'],
            [
                [
                    'title',
                    'excerpt',
                    'content',
                    'date',
                    'modified',
                    'status',
                    'password',
                    'slug',
                    'comment_status',
                    'username',
                ],
                'safe',
            ],
        ];
    }

    /**
     * @inheritdoc
     */
    public function scenarios()
    {
        // bypass scenarios() implementation in the parent class
        return Model::scenarios();
    }

    /**
     * Creates data provider instance with search query applied
     *
     * @param array $params
     * @param int $type
     * @param null|string $user
     *
     * @return ActiveDataProvider
     */
    public function search($params, $type, $user = null)
    {
        $query = PostModel::find();
        $query->innerJoinWith(['postAuthor'])->from(['post' => static::tableName()]);
        $query->andWhere(['type' => $type]);

        if ($user) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $query->andWhere(['author' => $user]);
        }

        $dataProvider = new ActiveDataProvider([
            'query' => $query,
        ]);

        $dataProvider->setSort([
            'attributes' => ArrayHelper::merge($dataProvider->sort->attributes, [
                'username' => [
                    'asc' => ['username' => SORT_ASC],
                    'desc' => ['username' => SORT_DESC],
                    'label' => 'Author',
                    'value' => 'username',
                ],
            ]),
            'defaultOrder' => ['id' => SORT_DESC],
        ]);

        $this->load($params);

        if (!$this->validate()) {
            return $dataProvider;
        }

        $query->andFilterWhere([
            'post.id' => $this->id,
            'author' => $this->author,
            'type' => $this->type,
            'comment_count' => $this->comment_count,
        ]);

        $query->andFilterWhere(['like', 'title', $this->title])
            ->andFilterWhere(['like', 'excerpt', $this->excerpt])
            ->andFilterWhere(['like', 'content', $this->content])
            ->andFilterWhere(['like', 'post.status', $this->status])
            ->andFilterWhere(['like', 'password', $this->password])
            ->andFilterWhere(['like', 'slug', $this->slug])
            ->andFilterWhere(['like', 'date', $this->date])
            ->andFilterWhere(['like', 'modified', $this->modified])
            ->andFilterWhere(['like', 'comment_status', $this->comment_status])
            ->andFilterWhere(['like', 'username', $this->username]);


        return $dataProvider;
    }
}


1			<?php
2			/**
3			* @link http://www.writesdown.com/
4			* @copyright Copyright (c) 2015 WritesDown
5			* @license http://www.writesdown.com/license/
6			*/
7
8			namespace common\models\search;
9
10			use common\models\Post as PostModel;
11			use Yii;
12			use yii\base\Model;
13			use yii\data\ActiveDataProvider;
14			use yii\helpers\ArrayHelper;
15
16			/**
17			* Post represents the model behind the search form about `common\models\Post`.
18			*
19			* @author Agiel K. Saputra <[email protected]>
20			* @since 0.1.0
21			*/
22			class Post extends PostModel
23			{
24			/**
25			* @inheritdoc
26			*/
27			public function rules()
28			{
29			return [
30			[['id', 'author', 'type', 'comment_count'], 'integer'],
31			[
32			[
33			'title',
34			'excerpt',
35			'content',
36			'date',
37			'modified',
38			'status',
39			'password',
40			'slug',
41			'comment_status',
42			'username',
43			],
44			'safe',
45			],
46			];
47			}
48
49			/**
50			* @inheritdoc
51			*/
52			public function scenarios()
53			{
54			// bypass scenarios() implementation in the parent class
55			return Model::scenarios();
56			}
57
58			/**
59			* Creates data provider instance with search query applied
60			*
61			* @param array $params
62			* @param int $type
63			* @param null\|string $user
64			*
65			* @return ActiveDataProvider
66			*/
67			public function search($params, $type, $user = null)
68			{
69			$query = PostModel::find();
70			$query->innerJoinWith(['postAuthor'])->from(['post' => static::tableName()]);
71			$query->andWhere(['type' => $type]);
72
73			if ($user) {
			0 ignored issues – show Bug Best Practice introduced 2016-02-11 01:42 UTC by Report Bug Copy Issue Report The expression `$user` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
74			$query->andWhere(['author' => $user]);
75			}
76
77			$dataProvider = new ActiveDataProvider([
78			'query' => $query,
79			]);
80
81			$dataProvider->setSort([
82			'attributes' => ArrayHelper::merge($dataProvider->sort->attributes, [
83			'username' => [
84			'asc' => ['username' => SORT_ASC],
85			'desc' => ['username' => SORT_DESC],
86			'label' => 'Author',
87			'value' => 'username',
88			],
89			]),
90			'defaultOrder' => ['id' => SORT_DESC],
91			]);
92
93			$this->load($params);
94
95			if (!$this->validate()) {
96			return $dataProvider;
97			}
98
99			$query->andFilterWhere([
100			'post.id' => $this->id,
101			'author' => $this->author,
102			'type' => $this->type,
103			'comment_count' => $this->comment_count,
104			]);
105
106			$query->andFilterWhere(['like', 'title', $this->title])
107			->andFilterWhere(['like', 'excerpt', $this->excerpt])
108			->andFilterWhere(['like', 'content', $this->content])
109			->andFilterWhere(['like', 'post.status', $this->status])
110			->andFilterWhere(['like', 'password', $this->password])
111			->andFilterWhere(['like', 'slug', $this->slug])
112			->andFilterWhere(['like', 'date', $this->date])
113			->andFilterWhere(['like', 'modified', $this->modified])
114			->andFilterWhere(['like', 'comment_status', $this->comment_status])
115			->andFilterWhere(['like', 'username', $this->username]);
116
117
118			return $dataProvider;
119			}
120			}
121

writesdown / app-cms

Post::search() A last analyzed 2016-04-17 09:32 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

Post::search() A
last analyzed 2016-04-17 09:32 UTC