wp-pay-gateways / targetpay

src/Gateway.php

<?php

namespace Pronamic\WordPress\Pay\Gateways\TargetPay;

use Pronamic\WordPress\Pay\Banks\BankAccountDetails;
use Pronamic\WordPress\Pay\Core\Gateway as Core_Gateway;
use Pronamic\WordPress\Pay\Core\PaymentMethods;
use Pronamic\WordPress\Pay\Payments\Payment;

/**
 * Title: TargetPay gateway
 * Description:
 * Copyright: 2005-2021 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.3
 * @since   1.0.0
 */
class Gateway extends Core_Gateway {
	/**
	 * Client.
	 *
	 * @var Client
	 */
	protected $client;

	/**
	 * Constructs and initializes an TargetPay gateway
	 *
	 * @param Config $config Config.
	 */
	public function __construct( Config $config ) {
		parent::__construct( $config );

		$this->set_method( self::METHOD_HTTP_REDIRECT );

		// Supported features.
		$this->supports = array(
			'payment_status_request',
		);

		// Client.
		$this->client = new Client();
	}

	/**
	 * Get issuers
	 *
	 * @see Core_Gateway::get_issuers()
	 */
	public function get_issuers() {
		$groups = array();

		$result = $this->client->get_issuers();

		if ( $result ) {
			$groups[] = array(
				'options' => $result,
			);
		}

		return $groups;
	}

	/**
	 * Get supported payment methods
	 *
	 * @see Core_Gateway::get_supported_payment_methods()
	 */
	public function get_supported_payment_methods() {
		return array(
			PaymentMethods::IDEAL,
		);
	}

	/**
	 * Start
	 *
	 * @see Core_Gateway::start()
	 *
	 * @param Payment $payment Payment.
	 */
	public function start( Payment $payment ) {
		$parameters                    = new IDealStartParameters();
		$parameters->rtlo              = $this->config->layoutcode;
		$parameters->bank              = $payment->get_issuer();
		$parameters->description       = $payment->get_description();
		$parameters->amount            = $payment->get_total_amount()->get_minor_units()->format( 0, '', '' );

The method format() does not exist on integer.

		$parameters->return_url        = $payment->get_return_url();
		$parameters->report_url        = $payment->get_return_url();
		$parameters->cinfo_in_callback = 1;

The property $cinfo_in_callback was declared of type boolean, but 1 is of type integer. Maybe add a type cast?

		$result = $this->client->start_transaction( $parameters );

		if ( $result ) {

$result is of type stdClass, thus it always evaluated to true.

			$payment->set_action_url( $result->url );
			$payment->set_transaction_id( $result->transaction_id );
		}
	}

	/**
	 * Update status of the specified payment
	 *
	 * @param Payment $payment Payment.
	 */
	public function update_status( Payment $payment ) {
		// Get transaction status.
		$status = $this->client->check_status(
			$this->config->layoutcode,
			$payment->get_transaction_id(),
			false,

false of type false is incompatible with the type string expected by parameter $once of Pronamic\WordPress\Pay\Gateways\TargetPay\Client::check_status().

			self::MODE_TEST === $this->config->mode
		);

		if ( ! $status ) {

$status is of type Pronamic\WordPress\Pay\Gateways\TargetPay\Status, thus it always evaluated to true.

			return;
		}

		// Update payment status.
		$payment->set_status( Statuses::transform( $status->code ) );

		// Set payment consumer details.
		if ( Statuses::OK === $status->code ) {
			$consumer_bank_details = $payment->get_consumer_bank_details();

			if ( null === $consumer_bank_details ) {
				$consumer_bank_details = new BankAccountDetails();

				$payment->set_consumer_bank_details( $consumer_bank_details );
			}

			$consumer_bank_details->set_name( $status->account_name );
			$consumer_bank_details->set_account_number( $status->account_number );
			$consumer_bank_details->set_city( $status->account_city );
		}
	}
}