Pronamic\WordPress\Pay\Gateways\TargetPay\SofortClient

Complexity

Total Complexity

3

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	start_transaction()	0	4	1
A	__construct()	0	1	1
A	remote_get()	0	1	1

<?php

namespace Pronamic\WordPress\Pay\Gateways\TargetPay;

use Pronamic\WordPress\Pay\Core\Util;

/**
 * Title: TargetPay SOFORT Banking client
 * Description:
 * Copyright: 2005-2020 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.0
 * @since   1.0.0
 */
class SofortClient {
	/**
	 * URL to start an transaction
	 *
	 * @var string
	 */
	const URL_START_TRANSACTION = 'https://www.targetpay.com/directebanking/start';

	/**
	 * Constructs and initializes an TargetPay SOFORT Banking client object
	 */
	public function __construct() {

	}

	/**
	 * Remote get.
	 *
	 * @param string $url Request URL.
	 */
	private static function remote_get( $url ) {

The parameter $url is not used and could be removed.

	}

	/**
	 * Start transaction
	 *
	 * @param SofortStartParameters $parameters Sofort start parameters.
	 */
	public function start_transaction( SofortStartParameters $parameters ) {
		$url = Util::build_url( self::URL_START_TRANSACTION, (array) $parameters );

		$data = self::remote_get( $url );

The assignment to $data is dead and can be removed.

Are you sure the assignment to $data is correct as self::remote_get($url) targeting Pronamic\WordPress\Pay\Gateways\TargetPay\SofortClient::remote_get() seems to always return null.

		// @todo need work
	}
}