Issues in SofortClient.php - Failed Issues - Inspection of "Added section." - wp-pay-gateways/targetpay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( e6c5de...8e18ff )

by Remco

created 2019-05-29 14:12 UTC

src/SofortClient.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace Pronamic\WordPress\Pay\Gateways\TargetPay;

use Pronamic\WordPress\Pay\Core\Util;

/**
 * Title: TargetPay SOFORT Banking client
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.0
 * @since   1.0.0
 */
class SofortClient {
	/**
	 * URL to start an transaction
	 *
	 * @var string
	 */
	const URL_START_TRANSACTION = 'https://www.targetpay.com/directebanking/start';

	/**
	 * Constructs and initializes an TargetPay SOFORT Banking client object
	 */
	public function __construct() {

	}

	/**
	 * Remote get.
	 *
	 * @param string $url Request URL.
	 */
	private static function remote_get( $url ) {
	}

	/**
	 * Start transaction
	 *
	 * @param SofortStartParameters $parameters Sofort start parameters.
	 */
	public function start_transaction( SofortStartParameters $parameters ) {
		$url = Util::build_url( self::URL_START_TRANSACTION, (array) $parameters );

		$data = self::remote_get( $url );
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

		// @todo need work
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\TargetPay;
4
5			use Pronamic\WordPress\Pay\Core\Util;
6
7			/**
8			* Title: TargetPay SOFORT Banking client
9			* Description:
10			* Copyright: 2005-2019 Pronamic
11			* Company: Pronamic
12			*
13			* @author Remco Tolsma
14			* @version 2.0.0
15			* @since 1.0.0
16			*/
17			class SofortClient {
18			/**
19			* URL to start an transaction
20			*
21			* @var string
22			*/
23			const URL_START_TRANSACTION = 'https://www.targetpay.com/directebanking/start';
24
25			/**
26			* Constructs and initializes an TargetPay SOFORT Banking client object
27			*/
28			public function __construct() {
29
30			}
31
32			/**
33			* Remote get.
34			*
35			* @param string $url Request URL.
36			*/
37			private static function remote_get( $url ) {
38			}
39
40			/**
41			* Start transaction
42			*
43			* @param SofortStartParameters $parameters Sofort start parameters.
44			*/
45			public function start_transaction( SofortStartParameters $parameters ) {
46			$url = Util::build_url( self::URL_START_TRANSACTION, (array) $parameters );
47
48			$data = self::remote_get( $url );
			0 ignored issues – show Bug introduced 2018-10-23 12:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the assignment to `$data` is correct as `self::remote_get($url)` targeting `Pronamic\WordPress\Pay\G...ortClient::remote_get()` seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
49
50			// @todo need work
51			}
52			}
53

wp-pay-gateways / targetpay

Push — develop ( e6c5de...8e18ff )

src/SofortClient.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like