Statuses::transform() - Code Metrics - Inspection of "Remove unused imports and signature data in transa..." - wp-pay-gateways/sisow - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — feature/post-pay ( 891b87...037c25 )

by Reüel

created 2018-10-30 15:34 UTC

Statuses::transform() B

↳ Parent: Statuses

Complexity

Conditions	10
Paths	10

Size

Total Lines	25
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes

Metric	Value
eloc	18
dl	0
loc	25
c	0
b	0
f	0
ccs	0
cts	19
cp	0
rs	7.6666
cc	10
nc	10
nop	1
crap	110

How to fix Complexity

<?php

namespace Pronamic\WordPress\Pay\Gateways\Sisow;

use Pronamic\WordPress\Pay\Core\Statuses as Core_Statuses;

/**
 * Title: Sisow statuses constants
 * Description:
 * Copyright: Copyright (c) 2005 - 2018
 * Company: Pronamic
 *
 * @author  Reüel van der Steege
 * @version 2.0.1
 * @since   2.0.1
 */
class Statuses {
	/**
	 * Open.
	 *
	 * @var string
	 */
	const OPEN = 'Open';

	/**
	 * Pending.
	 *
	 * @var string
	 */
	const PENDING = 'Pending';

	/**
	 * Reservation.
	 *
	 * @var string
	 */
	const RESERVATION = 'Reservation';

	/**
	 * Paid.
	 *
	 * @var string
	 */
	const SUCCESS = 'Success';

	/**
	 * Cancelled.
	 *
	 * @var string
	 */
	const CANCELLED = 'Cancelled';

	/**
	 * Expired.
	 *
	 * @var string
	 */
	const EXPIRED = 'Expired';

	/**
	 * Denied.
	 *
	 * @var string
	 */
	const DENIED = 'Denied';

	/**
	 * Failure.
	 *
	 * @var string
	 */
	const FAILURE = 'Failure';

	/**
	 * Reversed.
	 *
	 * @var string
	 */
	const REVERSED = 'Reversed';

	/**
	 * Transform an Sisow state to a more global status.
	 *
	 * @param string $status Sisow status.
	 *
	 * @return string|null Pay status.
	 */
	public static function transform( $status ) {
		switch ( $status ) {
			case self::PENDING:
			case self::OPEN:
				return Core_Statuses::OPEN;

			case self::RESERVATION:
				return Core_Statuses::RESERVED;


			case self::SUCCESS:
				return Core_Statuses::SUCCESS;

			case self::CANCELLED:
				return Core_Statuses::CANCELLED;

			case self::EXPIRED:
				return Core_Statuses::EXPIRED;

			case self::DENIED:
			case self::FAILURE:
				return Core_Statuses::FAILURE;

			case self::REVERSED:
			default:
				return null;
		}
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\Sisow;
4
5			use Pronamic\WordPress\Pay\Core\Statuses as Core_Statuses;
6
7			/**
8			* Title: Sisow statuses constants
9			* Description:
10			* Copyright: Copyright (c) 2005 - 2018
11			* Company: Pronamic
12			*
13			* @author Reüel van der Steege
14			* @version 2.0.1
15			* @since 2.0.1
16			*/
17			class Statuses {
18			/**
19			* Open.
20			*
21			* @var string
22			*/
23			const OPEN = 'Open';
24
25			/**
26			* Pending.
27			*
28			* @var string
29			*/
30			const PENDING = 'Pending';
31
32			/**
33			* Reservation.
34			*
35			* @var string
36			*/
37			const RESERVATION = 'Reservation';
38
39			/**
40			* Paid.
41			*
42			* @var string
43			*/
44			const SUCCESS = 'Success';
45
46			/**
47			* Cancelled.
48			*
49			* @var string
50			*/
51			const CANCELLED = 'Cancelled';
52
53			/**
54			* Expired.
55			*
56			* @var string
57			*/
58			const EXPIRED = 'Expired';
59
60			/**
61			* Denied.
62			*
63			* @var string
64			*/
65			const DENIED = 'Denied';
66
67			/**
68			* Failure.
69			*
70			* @var string
71			*/
72			const FAILURE = 'Failure';
73
74			/**
75			* Reversed.
76			*
77			* @var string
78			*/
79			const REVERSED = 'Reversed';
80
81			/**
82			* Transform an Sisow state to a more global status.
83			*
84			* @param string $status Sisow status.
85			*
86			* @return string\|null Pay status.
87			*/
88			public static function transform( $status ) {
89			switch ( $status ) {
90			case self::PENDING:
91			case self::OPEN:
92			return Core_Statuses::OPEN;
93
94			case self::RESERVATION:
95			return Core_Statuses::RESERVED;
			0 ignored issues – show Bug introduced 2018-10-30 15:40 UTC by Report Bug Copy Issue Report The constant `Pronamic\WordPress\Pay\Core\Statuses::RESERVED` was not found. Maybe you did not declare it correctly or list all dependencies? Loading history...
96
97			case self::SUCCESS:
98			return Core_Statuses::SUCCESS;
99
100			case self::CANCELLED:
101			return Core_Statuses::CANCELLED;
102
103			case self::EXPIRED:
104			return Core_Statuses::EXPIRED;
105
106			case self::DENIED:
107			case self::FAILURE:
108			return Core_Statuses::FAILURE;
109
110			case self::REVERSED:
111			default:
112			return null;
113			}
114			}
115			}
116

wp-pay-gateways / sisow

Push — feature/post-pay ( 891b87...037c25 )

Statuses::transform() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like