Test Failed
Push — main ( 28b955...362ef3 )
by Reüel
14:17 queued 10s
created

tests/src/TransactionTest.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * Transaction Test
4
 *
5
 * @author    Pronamic <[email protected]>
6
 * @copyright 2005-2021 Pronamic
7
 * @license   GPL-3.0-or-later
8
 * @package   Pronamic\WordPress\Pay\Gateways\Payvision
9
 */
10
11
namespace Pronamic\WordPress\Pay\Gateways\Payvision;
12
13
/**
14
 * Transaction Test
15
 *
16
 * @author  Remco Tolsma
17
 * @version 1.1.0
18
 * @since   1.0.0
19
 */
20
class TransactionTest extends \WP_UnitTestCase {
21
	/**
22
	 * Test.
23
	 */
24
	public function test() {
25
		$transaction = new Transaction( '123456', 50, 'EUR', '12345678' );
26
27
		$transaction->set_brand_id( BrandId::IDEAL );
28
		$transaction->set_purchase_id( 123456 );
29
		$transaction->set_return_url( 'https://example.com/' );
30
31
		$this->assertInstanceOf( Transaction::class, $transaction );
32
33
		$this->assertEquals( BrandId::IDEAL, $transaction->get_brand_id() );
34
35
		// JSON.
36
		$json_file = __DIR__ . '/../json/transaction-request.json';
37
38
		$json_string = \wp_json_encode( $transaction, \JSON_PRETTY_PRINT );
39
40
		$this->assertJsonStringEqualsJsonFile( $json_file, $json_string );
0 ignored issues
show
It seems like $json_string defined by \wp_json_encode($transaction, \JSON_PRETTY_PRINT) on line 38 can also be of type false; however, PHPUnit\Framework\Assert...nStringEqualsJsonFile() does only seem to accept string, did you maybe forget to handle an error condition?

This check looks for type mismatches where the missing type is false. This is usually indicative of an error condtion.

Consider the follow example

<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}

This function either returns a new DateTime object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned false before passing on the value to another function or method that may not be able to handle a false.

Loading history...
41
	}
42
}
43