Integration::admin_notice_tld_test() - Code Metrics - Inspection of "Only display admin notice for .test return URL if..." - wp-pay-gateways/omnikassa-2 - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 5ad3a9...9073dd )

by Reüel

created 2019-01-03 10:27 UTC

Integration::admin_notice_tld_test() B

↳ Parent: Integration

Complexity

Conditions	8
Paths	8

Size

Total Lines	60
Code Lines	36

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes

Metric	Value
cc	8
eloc	36
nc	8
nop	0
dl	0
loc	60
ccs	0
cts	47
cp	0
crap	72
rs	8.0995
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Integration
 *
 * @author    Pronamic <[email protected]>
 * @copyright 2005-2018 Pronamic
 * @license   GPL-3.0-or-later
 * @package   Pronamic\WordPress\Pay\Gateways\OmniKassa2
 */

namespace Pronamic\WordPress\Pay\Gateways\OmniKassa2;

use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;
filter:
    dependency_paths: ["lib/*"]

/**
 * Integration
 *
 * @author  Remco Tolsma
 * @version 2.1.0
 * @since   1.0.0
 */
class Integration extends AbstractIntegration {
	/**
	 * Construct and initialize integration.
	 */
	public function __construct() {
		$this->id            = 'rabobank-omnikassa-2';

		$this->name          = 'Rabobank - OmniKassa 2.0';

		$this->product_url   = 'https://www.rabobank.nl/bedrijven/betalen/geld-ontvangen/rabo-omnikassa/';

		$this->dashboard_url = 'https://bankieren.rabobank.nl/omnikassa-dashboard/';

		$this->provider      = 'rabobank';


		/**
		 * Webhook listener function.
		 *
		 * @var callable $webhook_listener_function
		 */
		$webhook_listener_function = array( __NAMESPACE__ . '\WebhookListener', 'listen' );

		if ( ! has_action( 'wp_loaded', $webhook_listener_function ) ) {
			add_action( 'wp_loaded', $webhook_listener_function );
		}

		/**
		 * Save post.
		 *
		 * @link https://github.com/WordPress/WordPress/blob/5.0/wp-includes/post.php#L3724-L3736
		 *
		 * @var callable $delete_access_token_meta_function
		 */
		$delete_access_token_meta_function = array( __NAMESPACE__ . '\ConfigFactory', 'delete_access_token_meta' );

		if ( ! has_action( 'save_post_pronamic_gateway', $delete_access_token_meta_function ) ) {
			add_action( 'save_post_pronamic_gateway', $delete_access_token_meta_function );
		}

		/**
		 * Admin notices.
		 *
		 * @link https://github.com/WordPress/WordPress/blob/5.0/wp-admin/admin-header.php#L259-L264
		 *
		 * @var callable $admin_notices_function
		 */
		$admin_notices_function = array( $this, 'admin_notice_tld_test' );

		if ( ! has_action( 'admin_notices', $admin_notices_function ) ) {
			add_action( 'admin_notices', $admin_notices_function );
		}
	}

	/**
	 * Admin notice TLD .test.
	 *
	 * @link https://github.com/WordPress/WordPress/blob/5.0/wp-admin/admin-header.php#L259-L264
	 * @link https://developer.wordpress.org/reference/hooks/admin_notices/
	 * @link https://developer.wordpress.org/reference/functions/get_current_screen/
	 */
	public function admin_notice_tld_test() {
		if ( has_filter( 'pronamic_pay_omnikassa_2_merchant_return_url' ) ) {
			return;
		}

		$screen = get_current_screen();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();

		if ( null === $screen ) {

			return;
		}

		if ( 'pronamic_gateway' !== $screen->id ) {
			return;
		}

		$host = wp_parse_url( home_url( '/' ), PHP_URL_HOST );

		if ( is_array( $host ) ) {
			return;
		}

		if ( '.test' !== substr( $host, -5 ) ) {
			return;
		}

		$post_id = get_the_ID();

		if ( empty( $post_id ) ) {
			return;
		}

		$gateway_id = get_post_meta( $post_id, '_pronamic_gateway_id', true );

		if ( 'rabobank-omnikassa-2' !== $gateway_id ) {
			return;
		}

		$class   = 'notice notice-error';
		$message = sprintf(
			/* translators: 1: Pronamic Pay, 2: Documentation link, 3: <code>.test</code> */
			__( '%1$s — <a href="%2$s">OmniKassa 2 does not accept payments from %3$s environments</a>.', 'pronamic_ideal' ),
			sprintf(
				'<strong>%s</strong>',
				__( 'Pronamic Pay', 'pronamic_ideal' )
			),
			'https://github.com/wp-pay-gateways/omnikassa-2/tree/develop/documentation#merchantreturnurl-is-not-a-valid-web-address',
			'<code>.test</code>'
		);

		printf(
			'<div class="%1$s"><p>%2$s</p></div>',
			esc_attr( $class ),
			wp_kses(
				$message,
				array(
					'a'      => array(
						'href' => true,
					),
					'code'   => array(),
					'strong' => array(),
				)
			)
		);
	}

	/**
	 * Get config factory class.
	 *
	 * @return string
	 */
	public function get_config_factory_class() {
		return __NAMESPACE__ . '\ConfigFactory';
	}

	/**
	 * Get settings class.
	 *
	 * @return string
	 */
	public function get_settings_class() {
		return __NAMESPACE__ . '\Settings';
	}

	/**
	 * Get required settings for this integration.
	 *
	 * @link https://github.com/wp-premium/gravityforms/blob/1.9.16/includes/fields/class-gf-field-multiselect.php#L21-L42
	 * @since 1.1.6
	 * @return array
	 */
	public function get_settings() {
		$settings = parent::get_settings();

		$settings[] = 'omnikassa-2';

		return $settings;
	}
}


1			<?php
2			/**
3			* Integration
4			*
5			* @author Pronamic <[email protected]>
6			* @copyright 2005-2018 Pronamic
7			* @license GPL-3.0-or-later
8			* @package Pronamic\WordPress\Pay\Gateways\OmniKassa2
9			*/
10
11			namespace Pronamic\WordPress\Pay\Gateways\OmniKassa2;
12
13			use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;
			0 ignored issues – show Bug introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The type `Pronamic\WordPress\Pay\G...mon\AbstractIntegration` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
14
15			/**
16			* Integration
17			*
18			* @author Remco Tolsma
19			* @version 2.1.0
20			* @since 1.0.0
21			*/
22			class Integration extends AbstractIntegration {
23			/**
24			* Construct and initialize integration.
25			*/
26			public function __construct() {
27			$this->id = 'rabobank-omnikassa-2';
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The property `id` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
28			$this->name = 'Rabobank - OmniKassa 2.0';
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The property `name` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
29			$this->product_url = 'https://www.rabobank.nl/bedrijven/betalen/geld-ontvangen/rabo-omnikassa/';
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The property `product_url` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
30			$this->dashboard_url = 'https://bankieren.rabobank.nl/omnikassa-dashboard/';
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The property `dashboard_url` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
31			$this->provider = 'rabobank';
			0 ignored issues – show Bug Best Practice introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report The property `provider` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
32
33			/**
34			* Webhook listener function.
35			*
36			* @var callable $webhook_listener_function
37			*/
38			$webhook_listener_function = array( __NAMESPACE__ . '\WebhookListener', 'listen' );
39
40			if ( ! has_action( 'wp_loaded', $webhook_listener_function ) ) {
41			add_action( 'wp_loaded', $webhook_listener_function );
42			}
43
44			/**
45			* Save post.
46			*
47			* @link https://github.com/WordPress/WordPress/blob/5.0/wp-includes/post.php#L3724-L3736
48			*
49			* @var callable $delete_access_token_meta_function
50			*/
51			$delete_access_token_meta_function = array( __NAMESPACE__ . '\ConfigFactory', 'delete_access_token_meta' );
52
53			if ( ! has_action( 'save_post_pronamic_gateway', $delete_access_token_meta_function ) ) {
54			add_action( 'save_post_pronamic_gateway', $delete_access_token_meta_function );
55			}
56
57			/**
58			* Admin notices.
59			*
60			* @link https://github.com/WordPress/WordPress/blob/5.0/wp-admin/admin-header.php#L259-L264
61			*
62			* @var callable $admin_notices_function
63			*/
64			$admin_notices_function = array( $this, 'admin_notice_tld_test' );
65
66			if ( ! has_action( 'admin_notices', $admin_notices_function ) ) {
67			add_action( 'admin_notices', $admin_notices_function );
68			}
69			}
70
71			/**
72			* Admin notice TLD .test.
73			*
74			* @link https://github.com/WordPress/WordPress/blob/5.0/wp-admin/admin-header.php#L259-L264
75			* @link https://developer.wordpress.org/reference/hooks/admin_notices/
76			* @link https://developer.wordpress.org/reference/functions/get_current_screen/
77			*/
78			public function admin_notice_tld_test() {
79			if ( has_filter( 'pronamic_pay_omnikassa_2_merchant_return_url' ) ) {
80			return;
81			}
82
83			$screen = get_current_screen();
			1 ignored issue – show Bug introduced 2019-01-03 10:32 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$screen` is correct as `get_current_screen()` seems to always return `null`. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
84
85			if ( null === $screen ) {
			1 ignored issue – show introduced 2018-12-27 19:51 UTC by Report Bug Copy Issue Report The condition `null === $screen` is always `true`. Loading history...
86			return;
87			}
88
89			if ( 'pronamic_gateway' !== $screen->id ) {
90			return;
91			}
92
93			$host = wp_parse_url( home_url( '/' ), PHP_URL_HOST );
94
95			if ( is_array( $host ) ) {
96			return;
97			}
98
99			if ( '.test' !== substr( $host, -5 ) ) {
100			return;
101			}
102
103			$post_id = get_the_ID();
104
105			if ( empty( $post_id ) ) {
106			return;
107			}
108
109			$gateway_id = get_post_meta( $post_id, '_pronamic_gateway_id', true );
110
111			if ( 'rabobank-omnikassa-2' !== $gateway_id ) {
112			return;
113			}
114
115			$class = 'notice notice-error';
116			$message = sprintf(
117			/* translators: 1: Pronamic Pay, 2: Documentation link, 3: <code>.test</code> */
118			__( '%1$s — <a href="%2$s">OmniKassa 2 does not accept payments from %3$s environments</a>.', 'pronamic_ideal' ),
119			sprintf(
120			'<strong>%s</strong>',
121			__( 'Pronamic Pay', 'pronamic_ideal' )
122			),
123			'https://github.com/wp-pay-gateways/omnikassa-2/tree/develop/documentation#merchantreturnurl-is-not-a-valid-web-address',
124			'<code>.test</code>'
125			);
126
127			printf(
128			'<div class="%1$s"><p>%2$s</p></div>',
129			esc_attr( $class ),
130			wp_kses(
131			$message,
132			array(
133			'a' => array(
134			'href' => true,
135			),
136			'code' => array(),
137			'strong' => array(),
138			)
139			)
140			);
141			}
142
143			/**
144			* Get config factory class.
145			*
146			* @return string
147			*/
148			public function get_config_factory_class() {
149			return __NAMESPACE__ . '\ConfigFactory';
150			}
151
152			/**
153			* Get settings class.
154			*
155			* @return string
156			*/
157			public function get_settings_class() {
158			return __NAMESPACE__ . '\Settings';
159			}
160
161			/**
162			* Get required settings for this integration.
163			*
164			* @link https://github.com/wp-premium/gravityforms/blob/1.9.16/includes/fields/class-gf-field-multiselect.php#L21-L42
165			* @since 1.1.6
166			* @return array
167			*/
168			public function get_settings() {
169			$settings = parent::get_settings();
170
171			$settings[] = 'omnikassa-2';
172
173			return $settings;
174			}
175			}
176

wp-pay-gateways / omnikassa-2

Push — develop ( 5ad3a9...9073dd )

Integration::admin_notice_tld_test() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like