Client::get_data() - Code Metrics - Inspection of "Merge branch 'release/2.0.2'" - wp-pay-gateways/ogone - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( ef4611...12f600 )

by Remco

created 2019-03-28 12:45 UTC

Client::get_data() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	2
ccs	0
cts	2
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

namespace Pronamic\WordPress\Pay\Gateways\Ingenico\OrderStandardEasy;

use Pronamic\WordPress\Pay\Gateways\Ingenico\Data;
use Pronamic\WordPress\Pay\Gateways\Ingenico\Parameters;

/**
 * Title: Ingenico OrderStandard easy client
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.0
 * @since   1.0.0
 */
class Client {
	/**
	 * An payment type indicator for iDEAL
	 *
	 * @var string
	 */
	const PAYMENT_TYPE_IDEAL = 'iDEAL';

	/**
	 * The URL for testing
	 *
	 * @var string
	 */
	private $payment_server_url;

	/**
	 * Home URL
	 *
	 * @var string
	 */
	private $data;

	/**
	 * Constructs and initialize a iDEAL easy object
	 *
	 * @param string $psp_id
	 */
	public function __construct( $psp_id ) {
		$this->data = new Data();

		$this->data->set_field( Parameters::PSPID, $psp_id );
		$this->data->set_field( 'PM', self::PAYMENT_TYPE_IDEAL );
	}

	/**
	 * Get the payment server URL
	 *
	 * @return string the payment server URL
	 */
	public function get_payment_server_url() {
		return $this->payment_server_url;
	}

	/**
	 * Set the payment server URL
	 *
	 * @param string $url an URL
	 */
	public function set_payment_server_url( $url ) {
		$this->payment_server_url = $url;
	}

	/**
	 * Get data
	 *
	 * @return Data
	 */
	public function get_data() {
		return $this->data;

	}

	/**
	 * Get fields
	 *
	 * @since 1.2.1
	 * @return array
	 */
	public function get_fields() {
		return $this->data->get_fields();
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\Ingenico\OrderStandardEasy;
4
5			use Pronamic\WordPress\Pay\Gateways\Ingenico\Data;
6			use Pronamic\WordPress\Pay\Gateways\Ingenico\Parameters;
7
8			/**
9			* Title: Ingenico OrderStandard easy client
10			* Description:
11			* Copyright: 2005-2019 Pronamic
12			* Company: Pronamic
13			*
14			* @author Remco Tolsma
15			* @version 2.0.0
16			* @since 1.0.0
17			*/
18			class Client {
19			/**
20			* An payment type indicator for iDEAL
21			*
22			* @var string
23			*/
24			const PAYMENT_TYPE_IDEAL = 'iDEAL';
25
26			/**
27			* The URL for testing
28			*
29			* @var string
30			*/
31			private $payment_server_url;
32
33			/**
34			* Home URL
35			*
36			* @var string
37			*/
38			private $data;
39
40			/**
41			* Constructs and initialize a iDEAL easy object
42			*
43			* @param string $psp_id
44			*/
45			public function __construct( $psp_id ) {
46			$this->data = new Data();
			0 ignored issues – show Documentation Bug introduced 2018-10-23 12:31 UTC by Report Bug Copy Issue Report It seems like `new Pronamic\WordPress\P...ateways\Ingenico\Data()` of type `Pronamic\WordPress\Pay\Gateways\Ingenico\Data` is incompatible with the declared type `string` of property `$data`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
47			$this->data->set_field( Parameters::PSPID, $psp_id );
48			$this->data->set_field( 'PM', self::PAYMENT_TYPE_IDEAL );
49			}
50
51			/**
52			* Get the payment server URL
53			*
54			* @return string the payment server URL
55			*/
56			public function get_payment_server_url() {
57			return $this->payment_server_url;
58			}
59
60			/**
61			* Set the payment server URL
62			*
63			* @param string $url an URL
64			*/
65			public function set_payment_server_url( $url ) {
66			$this->payment_server_url = $url;
67			}
68
69			/**
70			* Get data
71			*
72			* @return Data
73			*/
74			public function get_data() {
75			return $this->data;
			0 ignored issues – show Bug Best Practice introduced 2018-10-23 12:31 UTC by Report Bug Copy Issue Report The expression `return $this->data` returns the type `string` which is incompatible with the documented return type `Pronamic\WordPress\Pay\Gateways\Ingenico\Data`. Loading history...
76			}
77
78			/**
79			* Get fields
80			*
81			* @since 1.2.1
82			* @return array
83			*/
84			public function get_fields() {
85			return $this->data->get_fields();
86			}
87			}
88

wp-pay-gateways / ogone

Push — master ( ef4611...12f600 )

Client::get_data() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like