wp-pay-gateways / ogone

src/DirectLink/Client.php

<?php

namespace Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;

use Pronamic\WordPress\Pay\Core\Util;
use Pronamic\WordPress\Pay\Core\XML\Security;
use Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;
use Pronamic\WordPress\Pay\Gateways\Ingenico\Error;
use Pronamic\WordPress\Pay\Gateways\Ingenico\XML\OrderResponseParser;
use WP_Error;

/**
 * Title: Ingenico DirectLink client
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.0
 * @since   1.0.0
 */
class Client {
	/**
	 * Error.
	 *
	 * @var WP_Error
	 */
	private $error;

	/**
	 * API URL.
	 *
	 * @var string
	 */
	public $api_url;

	/**
	 * PSP ID.
	 *
	 * @var string
	 */
	public $psp_id;

	/**
	 * SHA IN.
	 *
	 * @var string
	 */
	public $sha_in;

	/**
	 * User ID.
	 *
	 * @var string
	 */
	public $user_id;

	/**
	 * Password.
	 *
	 * @var string
	 */
	public $password;

	/**
	 * Constructs and initializes an Ogone DirectLink client
	 */
	public function __construct() {
		$this->api_url = DirectLink::API_PRODUCTION_URL;
	}

	/**
	 * Get error
	 *
	 * @return WP_Error
	 */
	public function get_error() {
		return $this->error;
	}

	/**
	 * Order direct
	 *
	 * @param array $data Data.
	 *
	 * @return bool|OrderResponse
	 */
	public function order_direct( array $data = array() ) {
		$order_response = false;

		$result = Util::remote_get_body(
			$this->api_url,
			200,
			array(
				'method'    => 'POST',
				'sslverify' => false,
				'body'      => $data,
			)
		);

		if ( is_wp_error( $result ) ) {
			$this->error = $result;

It seems like $result can also be of type string. However, the property $error is declared as type WP_Error. Maybe add an additional type check?

		} else {
			$xml = Util::simplexml_load_string( $result );

It seems like $result can also be of type WP_Error; however, parameter $string of Pronamic\WordPress\Pay\Core\Util::simplexml_load_string() does only seem to accept string, maybe add an additional type check?

			if ( is_wp_error( $xml ) ) {
				$this->error = $xml;
			} else {
				$order_response = OrderResponseParser::parse( $xml );

				if ( ! empty( $order_response->nc_error ) ) {
					$ogone_error = new Error(
						Security::filter( $order_response->nc_error ),
						Security::filter( $order_response->nc_error_plus )
					);

					$this->error = new WP_Error( 'ogone_error', (string) $ogone_error, $ogone_error );
				}
			}
		}

		return $order_response;
	}
}