Client::order_direct() - Code Metrics - Inspection of "Update libraries, coding standards, tests and Trav..." - wp-pay-gateways/ogone - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 9cc0c5...5590ec )

by Reüel

created 2019-02-09 02:20 UTC

Client::order_direct() A

↳ Parent: Client

Complexity

Conditions	4
Paths	4

Size

Total Lines	35
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
cc	4
eloc	22
nc	4
nop	1
dl	0
loc	35
ccs	0
cts	29
cp	0
crap	20
rs	9.568
c	0
b	0
f	0

<?php

namespace Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;

use Pronamic\WordPress\Pay\Core\Util;
use Pronamic\WordPress\Pay\Core\XML\Security;
use Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;
use Pronamic\WordPress\Pay\Gateways\Ingenico\Error;
use Pronamic\WordPress\Pay\Gateways\Ingenico\XML\OrderResponseParser;
use WP_Error;

/**
 * Title: Ingenico DirectLink client
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.0
 * @since   1.0.0
 */
class Client {
	/**
	 * Error.
	 *
	 * @var WP_Error
	 */
	private $error;

	/**
	 * API URL.
	 *
	 * @var string
	 */
	public $api_url;

	/**
	 * PSP ID.
	 *
	 * @var string
	 */
	public $psp_id;

	/**
	 * SHA IN.
	 *
	 * @var string
	 */
	public $sha_in;

	/**
	 * User ID.
	 *
	 * @var string
	 */
	public $user_id;

	/**
	 * Password.
	 *
	 * @var string
	 */
	public $password;

	/**
	 * Constructs and initializes an Ogone DirectLink client
	 */
	public function __construct() {
		$this->api_url = DirectLink::API_PRODUCTION_URL;
	}

	/**
	 * Get error
	 *
	 * @return WP_Error
	 */
	public function get_error() {
		return $this->error;
	}

	/**
	 * Order direct
	 *
	 * @param array $data Data.
	 *
	 * @return bool|OrderResponse
	 */
	public function order_direct( array $data = array() ) {
		$order_response = false;

		$result = Util::remote_get_body(
			$this->api_url,
			200,
			array(
				'method'    => 'POST',
				'sslverify' => false,
				'body'      => $data,
			)
		);

		if ( is_wp_error( $result ) ) {
			$this->error = $result;
		} else {
			$xml = Util::simplexml_load_string( $result );

			if ( is_wp_error( $xml ) ) {
				$this->error = $xml;

			} else {
				$order_response = OrderResponseParser::parse( $xml );

				if ( ! empty( $order_response->nc_error ) ) {
					$ogone_error = new Error(
						Security::filter( $order_response->nc_error ),
						Security::filter( $order_response->nc_error_plus )
					);

					$this->error = new WP_Error( 'ogone_error', (string) $ogone_error, $ogone_error );
				}
			}
		}

		return $order_response;
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;
4
5			use Pronamic\WordPress\Pay\Core\Util;
6			use Pronamic\WordPress\Pay\Core\XML\Security;
7			use Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink;
8			use Pronamic\WordPress\Pay\Gateways\Ingenico\Error;
9			use Pronamic\WordPress\Pay\Gateways\Ingenico\XML\OrderResponseParser;
10			use WP_Error;
11
12			/**
13			* Title: Ingenico DirectLink client
14			* Description:
15			* Copyright: 2005-2019 Pronamic
16			* Company: Pronamic
17			*
18			* @author Remco Tolsma
19			* @version 2.0.0
20			* @since 1.0.0
21			*/
22			class Client {
23			/**
24			* Error.
25			*
26			* @var WP_Error
27			*/
28			private $error;
29
30			/**
31			* API URL.
32			*
33			* @var string
34			*/
35			public $api_url;
36
37			/**
38			* PSP ID.
39			*
40			* @var string
41			*/
42			public $psp_id;
43
44			/**
45			* SHA IN.
46			*
47			* @var string
48			*/
49			public $sha_in;
50
51			/**
52			* User ID.
53			*
54			* @var string
55			*/
56			public $user_id;
57
58			/**
59			* Password.
60			*
61			* @var string
62			*/
63			public $password;
64
65			/**
66			* Constructs and initializes an Ogone DirectLink client
67			*/
68			public function __construct() {
69			$this->api_url = DirectLink::API_PRODUCTION_URL;
70			}
71
72			/**
73			* Get error
74			*
75			* @return WP_Error
76			*/
77			public function get_error() {
78			return $this->error;
79			}
80
81			/**
82			* Order direct
83			*
84			* @param array $data Data.
85			*
86			* @return bool\|OrderResponse
87			*/
88			public function order_direct( array $data = array() ) {
89			$order_response = false;
90
91			$result = Util::remote_get_body(
92			$this->api_url,
93			200,
94			array(
95			'method' => 'POST',
96			'sslverify' => false,
97			'body' => $data,
98			)
99			);
100
101			if ( is_wp_error( $result ) ) {
102			$this->error = $result;
103			} else {
104			$xml = Util::simplexml_load_string( $result );
105
106			if ( is_wp_error( $xml ) ) {
107			$this->error = $xml;
			0 ignored issues – show Documentation Bug introduced 2018-12-12 13:50 UTC by Report Bug Copy Issue Report It seems like `$xml` of type `SimpleXMLElement` is incompatible with the declared type `WP_Error` of property `$error`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
108			} else {
109			$order_response = OrderResponseParser::parse( $xml );
110
111			if ( ! empty( $order_response->nc_error ) ) {
112			$ogone_error = new Error(
113			Security::filter( $order_response->nc_error ),
114			Security::filter( $order_response->nc_error_plus )
115			);
116
117			$this->error = new WP_Error( 'ogone_error', (string) $ogone_error, $ogone_error );
118			}
119			}
120			}
121
122			return $order_response;
123			}
124			}
125

wp-pay-gateways / ogone

Push — develop ( 9cc0c5...5590ec )

Client::order_direct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like