Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink\Client::order_direct()

Complexity

Conditions	2
Paths	2

Size

Total Lines	27
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

0

<?php
	public function order_direct( array $data = array() ) {
		$order_response = false;

The assignment to $order_response is dead and can be removed.

		$result = Util::remote_get_body(
			$this->api_url,
			200,
			array(
				'method'    => 'POST',
				'sslverify' => false,
				'body'      => $data,
			)
		);

		$xml = Util::simplexml_load_string( $result );

It seems like $result can also be of type WP_Error; however, parameter $string of Pronamic\WordPress\Pay\Core\Util::simplexml_load_string() does only seem to accept string, maybe add an additional type check?

		$order_response = OrderResponseParser::parse( $xml );

		if ( ! empty( $order_response->nc_error ) ) {
			$ogone_error = new Error(
				Security::filter( $order_response->nc_error ),
				Security::filter( $order_response->nc_error_plus )
			);

			throw new \Exception( (string) $ogone_error );
		}

		return $order_response;
	}