1 | <?php |
||
2 | |||
3 | namespace Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink; |
||
4 | |||
5 | use Pronamic\WordPress\Pay\Gateways\Ingenico\AbstractIntegration; |
||
6 | use Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink; |
||
7 | use Pronamic\WordPress\Pay\Gateways\Ingenico\Settings; |
||
8 | |||
9 | class Integration extends AbstractIntegration { |
||
10 | public function __construct( $args = array() ) { |
||
11 | $args = wp_parse_args( |
||
12 | $args, |
||
13 | array( |
||
14 | 'id' => 'ogone-directlink', |
||
15 | 'name' => 'Ingenico/Ogone - DirectLink', |
||
16 | ) |
||
17 | ); |
||
18 | |||
19 | parent::__construct( $args ); |
||
20 | } |
||
21 | |||
22 | public function get_settings_fields() { |
||
23 | return Settings::get_settings_fields( 'directlink' ); |
||
24 | } |
||
25 | |||
26 | public function get_config( $post_id ) { |
||
27 | $config = new Config(); |
||
28 | |||
29 | $config->mode = get_post_meta( $post_id, '_pronamic_gateway_mode', true ); |
||
0 ignored issues
–
show
|
|||
30 | $config->psp_id = get_post_meta( $post_id, '_pronamic_gateway_ogone_psp_id', true ); |
||
0 ignored issues
–
show
It seems like
get_post_meta($post_id, ...ay_ogone_psp_id', true) can also be of type false . However, the property $psp_id is declared as type string . Maybe add an additional type check?
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable Either this assignment is in error or a type check should be added for that assignment. class Id
{
public $id;
public function __construct($id)
{
$this->id = $id;
}
}
class Account
{
/** @var Id $id */
public $id;
}
$account_id = false;
if (starsAreRight()) {
$account_id = new Id(42);
}
$account = new Account();
if ($account instanceof Id)
{
$account->id = $account_id;
}
Loading history...
|
|||
31 | $config->hash_algorithm = get_post_meta( $post_id, '_pronamic_gateway_ogone_hash_algorithm', true ); |
||
0 ignored issues
–
show
|
|||
32 | $config->sha_out_pass_phrase = get_post_meta( $post_id, '_pronamic_gateway_ogone_sha_out_pass_phrase', true ); |
||
0 ignored issues
–
show
|
|||
33 | $config->user_id = get_post_meta( $post_id, '_pronamic_gateway_ogone_user_id', true ); |
||
34 | $config->password = get_post_meta( $post_id, '_pronamic_gateway_ogone_password', true ); |
||
35 | $config->sha_in_pass_phrase = get_post_meta( $post_id, '_pronamic_gateway_ogone_directlink_sha_in_pass_phrase', true ); |
||
36 | $config->enabled_3d_secure = get_post_meta( $post_id, '_pronamic_gateway_ogone_3d_secure_enabled', true ); |
||
0 ignored issues
–
show
|
|||
37 | $config->order_id = get_post_meta( $post_id, '_pronamic_gateway_ogone_order_id', true ); |
||
0 ignored issues
–
show
|
|||
38 | $config->alias_enabled = get_post_meta( $post_id, '_pronamic_gateway_ogone_alias_enabled', true ); |
||
39 | $config->alias_usage = get_post_meta( $post_id, '_pronamic_gateway_ogone_alias_usage', true ); |
||
40 | |||
41 | // API URL |
||
42 | $is_utf8 = strcasecmp( get_bloginfo( 'charset' ), 'UTF-8' ) === 0; |
||
43 | |||
44 | switch ( $config->mode ) { |
||
45 | case Gateway::MODE_TEST: |
||
46 | if ( $is_utf8 ) { |
||
47 | $config->api_url = DirectLink::API_TEST_UTF8_URL; |
||
48 | } else { |
||
49 | $config->api_url = DirectLink::API_TEST_URL; |
||
50 | } |
||
51 | |||
52 | break; |
||
53 | default: |
||
54 | if ( $is_utf8 ) { |
||
55 | $config->api_url = DirectLink::API_PRODUCTION_UTF8_URL; |
||
56 | } else { |
||
57 | $config->api_url = DirectLink::API_PRODUCTION_URL; |
||
58 | } |
||
59 | } |
||
60 | |||
61 | return $config; |
||
62 | } |
||
63 | |||
64 | /** |
||
65 | * Get gateway. |
||
66 | * |
||
67 | * @param int $post_id Post ID. |
||
68 | * @return Gateway |
||
69 | */ |
||
70 | public function get_gateway( $post_id ) { |
||
71 | return new Gateway( $this->get_config( $post_id ) ); |
||
72 | } |
||
73 | } |
||
74 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountId
that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theid
property of an instance of theAccount
class. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.