Pronamic\WordPress\Pay\Gateways\Ingenico\XML\OrderResponseParser::parse()

Complexity

Conditions	3
Paths	4

Size

Total Lines	24
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	18
CRAP Score	3

Importance

Changes	1
Bugs	0	Features	0

<?php
	public static function parse( SimpleXMLElement $xml, $order_response = null ) {
		if ( ! $order_response instanceof OrderResponse ) {
			$order_response = new OrderResponse();
		}

		$order_response->order_id      = Security::filter( $xml['orderID'] );
		$order_response->pay_id        = Security::filter( $xml['PAYID'] );
		$order_response->nc_status     = Security::filter( $xml[ Parameters::NC_STATUS ] );
		$order_response->nc_error      = Security::filter( $xml[ Parameters::NC_ERROR ] );
		$order_response->nc_error_plus = Security::filter( $xml[ Parameters::NC_ERROR_PLUS ] );
		$order_response->acceptance    = Security::filter( $xml['ACCEPTANCE'] );
		$order_response->status        = Security::filter( $xml[ Parameters::STATUS ] );
		$order_response->eci           = Security::filter( $xml['ECI'] );
		$order_response->amount        = Security::filter( $xml[ Parameters::AMOUNT ] );
		$order_response->currency      = Security::filter( $xml[ Parameters::CURRENCY ] );
		$order_response->pm            = Security::filter( $xml['PM'] );
		$order_response->brand         = Security::filter( $xml['BRAND'] );

		if ( $xml->HTML_ANSWER ) {
			// phpcs:ignore WordPress.PHP.DiscouragedPHPFunctions.obfuscation_base64_decode
			$order_response->html_answer = base64_decode( Security::filter( $xml->HTML_ANSWER ) );

The property html_answer does not seem to exist on Pronamic\WordPress\Pay\Gateways\Ingenico\DirectLink\OrderResponse.

It seems like Pronamic\WordPress\Pay\Core\XML\Security::filter($xml->HTML_ANSWER) can also be of type null; however, parameter $string of base64_decode() does only seem to accept string, maybe add an additional type check?

		}

		return $order_response;
	}