wp-pay-gateways / nocks

src/Integration.php

<?php

namespace Pronamic\WordPress\Pay\Gateways\Nocks;

use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;

/**
 * Title: Nocks integration
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Reüel van der Steege
 * @version 2.0.0
 * @since   1.0.0
 */
class Integration extends AbstractIntegration {
	public function __construct() {
		$this->id            = 'nocks';
		$this->name          = 'Nocks - Checkout';
		$this->product_url   = 'https://www.nocks.com/';
		$this->dashboard_url = 'https://www.nocks.com/';
		$this->provider      = 'nocks';
		$this->supports      = array(

The property supports does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

			'payment_status_request',
			'webhook',
			'webhook_no_config',
		);

		// Actions
		$function = array( __NAMESPACE__ . '\Listener', 'listen' );

		if ( ! has_action( 'wp_loaded', $function ) ) {
			add_action( 'wp_loaded', $function );
		}
	}

	/**
	 * Get settings fields.
	 *
	 * @return array
	 */
	public function get_settings_fields() {
		$fields = array();

		// Access token.
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_nocks_access_token',
			'title'    => _x( 'Access Token', 'nocks', 'pronamic_ideal' ),
			'type'     => 'textarea',
			'classes'  => array( 'code' ),
		);

		// Merchant profile.
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_nocks_merchant_profile',
			'title'    => _x( 'Merchant Profile', 'nocks', 'pronamic_ideal' ),
			'type'     => 'description',
			'callback' => array( $this, 'field_merchant_profile' ),
		);

		// Webhook URL.
		$fields[] = array(
			'section'  => 'feedback',
			'title'    => __( 'Webhook URL', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'large-text', 'code' ),
			'value'    => add_query_arg( 'nocks_webhook', '', home_url( '/' ) ),
			'readonly' => true,
			'tooltip'  => __( 'The Webhook URL as sent with each transaction to receive automatic payment status updates on.', 'pronamic_ideal' ),
		);

		return $fields;
	}

	/**
	 * Field merchant profile select.
	 *
	 * @param array $field Settings field.
	 */
	public function field_merchant_profile( $field ) {
		$access_token     = get_post_meta( get_the_ID(), '_pronamic_gateway_nocks_access_token', true );

It seems like get_the_ID() can also be of type false; however, parameter $post_id of get_post_meta() does only seem to accept integer, maybe add an additional type check?

		$merchant_profile = get_post_meta( get_the_ID(), '_pronamic_gateway_nocks_merchant_profile', true );

		if ( ! $access_token ) {
			esc_html_e( 'First enter an API Key and save the configuration, to be able to choose from your Nocks merchant profiles.', 'pronamic_ideal' );

			return;
		}

		$client = new Client();

		$client->set_access_token( $access_token );

		// Select merchant profile.
		printf( '<select name="%s">', esc_attr( $field['meta_key'] ) );

		$options = array(
			__( '— Select Merchant Profile —', 'pronamic_ideal' ),
		);

		$options = array_merge( $options, $client->get_merchant_profiles() );

		$options = array(
			array(
				'options' => $options,
			),
		);

		echo Pay_Util::select_options_grouped( $options, $merchant_profile ); // WPCS: xss ok.

The type Pronamic\WordPress\Pay\Gateways\Nocks\Pay_Util was not found. Maybe you did not declare it correctly or list all dependencies?

		echo '</select>';
	}

	public function get_config( $post_id ) {
		$config = new Config();

		$config->post_id          = $post_id;
		$config->mode             = get_post_meta( $post_id, '_pronamic_gateway_mode', true );

It seems like get_post_meta($post_id, '_pronamic_gateway_mode', true) can also be of type false. However, the property $mode is declared as type string. Maybe add an additional type check?

		$config->access_token     = get_post_meta( $post_id, '_pronamic_gateway_nocks_access_token', true );
		$config->merchant_profile = get_post_meta( $post_id, '_pronamic_gateway_nocks_merchant_profile', true );

		return $config;
	}

	/**
	 * Get gateway.
	 *
	 * @param int $post_id Post ID.
	 * @return Gateway
	 */
	public function get_gateway( $post_id ) {
		return new Gateway( $this->get_config( $post_id ) );
	}
}