Issues in ConfigFactory.php - Failed Issues - Inspection of "Simplified settings." - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 5b958e...93bfb6 )

by Remco

created 2019-05-31 07:34 UTC

src/Connect/ConfigFactory.php (2 issues)

Labels

Severity

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\Connect;

use Pronamic\WordPress\Pay\Core\Gateway;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Pronamic\WordPress\Pay\Core\GatewayConfigFactory;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\MultiSafepay;

/**
 * Title: MultiSafepay config factory
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.2
 * @since   1.2.6
 */
class ConfigFactory extends GatewayConfigFactory {
	/**
	 * Get config.
	 *
	 * @param $post_id
	 *
	 * @return Config
	 */
	public function get_config( $post_id ) {
		$config = new Config();

		$config->mode       = get_post_meta( $post_id, '_pronamic_gateway_mode', true );
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
		$config->account_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_account_id', true );
		$config->site_id    = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_id', true );
		$config->site_code  = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_code', true );

		if ( Gateway::MODE_TEST === $config->mode ) {
			$config->api_url = MultiSafepay::API_TEST_URL;
		} else {
			$config->api_url = MultiSafepay::API_PRODUCTION_URL;
		}

		return $config;
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\Connect;
4
5			use Pronamic\WordPress\Pay\Core\Gateway;
			0 ignored issues – show Bug introduced 2018-10-23 12:34 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Pronamic\WordPress\Pay\G...Safepay\Connect\Gateway`. Consider defining an alias. Let?s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let?s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
6			use Pronamic\WordPress\Pay\Core\GatewayConfigFactory;
7			use Pronamic\WordPress\Pay\Gateways\MultiSafepay\MultiSafepay;
8
9			/**
10			* Title: MultiSafepay config factory
11			* Description:
12			* Copyright: 2005-2019 Pronamic
13			* Company: Pronamic
14			*
15			* @author Remco Tolsma
16			* @version 2.0.2
17			* @since 1.2.6
18			*/
19			class ConfigFactory extends GatewayConfigFactory {
20			/**
21			* Get config.
22			*
23			* @param $post_id
24			*
25			* @return Config
26			*/
27			public function get_config( $post_id ) {
28			$config = new Config();
29
30			$config->mode = get_post_meta( $post_id, '_pronamic_gateway_mode', true );
			0 ignored issues – show Documentation Bug introduced 2019-02-09 02:22 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `get_post_meta($post_id, ...ic_gateway_mode', true)` can also be of type `false`. However, the property `$mode` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
31			$config->account_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_account_id', true );
32			$config->site_id = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_id', true );
33			$config->site_code = get_post_meta( $post_id, '_pronamic_gateway_multisafepay_site_code', true );
34
35			if ( Gateway::MODE_TEST === $config->mode ) {
36			$config->api_url = MultiSafepay::API_TEST_URL;
37			} else {
38			$config->api_url = MultiSafepay::API_PRODUCTION_URL;
39			}
40
41			return $config;
42			}
43			}
44

wp-pay-gateways / multisafepay

Push — develop ( 5b958e...93bfb6 )

src/Connect/ConfigFactory.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like