Integration::get_settings_fields() - Code Metrics - Inspection of "Moved." - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( fd928b...40893b )

by Remco

created 2019-06-04 12:02 UTC

Integration::get_settings_fields() A

↳ Parent: Integration

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	35
dl	0
loc	52
rs	9.36
c	0
b	0
f	0
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;

use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;

/**
 * Title: MultiSafepay Connect integration
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.2
 * @since   1.2.6
 */
class Integration extends AbstractIntegration {
	/**
	 * Integration constructor.
	 */
	public function __construct() {
		$this->id            = 'multisafepay-connect';
		$this->name          = 'MultiSafepay - Connect';
		$this->url           = 'http://www.multisafepay.com/';
		$this->product_url   = __( 'http://www.multisafepay.com/', 'pronamic_ideal' );
		$this->dashboard_url = 'https://merchant.multisafepay.com/';
		$this->provider      = 'multisafepay';
		$this->supports      = array(

			'payment_status_request',
			'webhook',
			'webhook_no_config',
		);
	}

	/**
	 * Get config factory class.
	 *
	 * @return string
	 */
	public function get_config_factory_class() {
		return __NAMESPACE__ . '\ConfigFactory';
	}

	public function get_settings_fields() {
		$fields = array();

		// Account ID
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_account_id',
			'title'    => __( 'Account ID', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Account ID', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		// Site ID
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_site_id',
			'title'    => __( 'Site ID', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Site ID', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		// Site Security Code
		$fields[] = array(
			'section'  => 'general',
			'filter'   => FILTER_SANITIZE_STRING,
			'meta_key' => '_pronamic_gateway_multisafepay_site_code',
			'title'    => __( 'Site Security Code', 'pronamic_ideal' ),
			'type'     => 'text',
			'classes'  => array( 'code' ),
			'tooltip'  => sprintf(
				'%s %s.',
				__( 'Site Security Code', 'pronamic_ideal' ),
				/* translators: %s: MultiSafepay */
				sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
			),
		);

		return $fields;
	}
}


1			<?php
2
3			namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;
4
5			use Pronamic\WordPress\Pay\Gateways\Common\AbstractIntegration;
6
7			/**
8			* Title: MultiSafepay Connect integration
9			* Description:
10			* Copyright: 2005-2019 Pronamic
11			* Company: Pronamic
12			*
13			* @author Remco Tolsma
14			* @version 2.0.2
15			* @since 1.2.6
16			*/
17			class Integration extends AbstractIntegration {
18			/**
19			* Integration constructor.
20			*/
21			public function __construct() {
22			$this->id = 'multisafepay-connect';
23			$this->name = 'MultiSafepay - Connect';
24			$this->url = 'http://www.multisafepay.com/';
25			$this->product_url = __( 'http://www.multisafepay.com/', 'pronamic_ideal' );
26			$this->dashboard_url = 'https://merchant.multisafepay.com/';
27			$this->provider = 'multisafepay';
28			$this->supports = array(
			0 ignored issues – show Bug Best Practice introduced 2019-06-04 12:06 UTC by Report Bug Copy Issue Report The property `supports` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
29			'payment_status_request',
30			'webhook',
31			'webhook_no_config',
32			);
33			}
34
35			/**
36			* Get config factory class.
37			*
38			* @return string
39			*/
40			public function get_config_factory_class() {
41			return __NAMESPACE__ . '\ConfigFactory';
42			}
43
44			public function get_settings_fields() {
45			$fields = array();
46
47			// Account ID
48			$fields[] = array(
49			'section' => 'general',
50			'filter' => FILTER_SANITIZE_STRING,
51			'meta_key' => '_pronamic_gateway_multisafepay_account_id',
52			'title' => __( 'Account ID', 'pronamic_ideal' ),
53			'type' => 'text',
54			'classes' => array( 'code' ),
55			'tooltip' => sprintf(
56			'%s %s.',
57			__( 'Account ID', 'pronamic_ideal' ),
58			/* translators: %s: MultiSafepay */
59			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
60			),
61			);
62
63			// Site ID
64			$fields[] = array(
65			'section' => 'general',
66			'filter' => FILTER_SANITIZE_STRING,
67			'meta_key' => '_pronamic_gateway_multisafepay_site_id',
68			'title' => __( 'Site ID', 'pronamic_ideal' ),
69			'type' => 'text',
70			'classes' => array( 'code' ),
71			'tooltip' => sprintf(
72			'%s %s.',
73			__( 'Site ID', 'pronamic_ideal' ),
74			/* translators: %s: MultiSafepay */
75			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
76			),
77			);
78
79			// Site Security Code
80			$fields[] = array(
81			'section' => 'general',
82			'filter' => FILTER_SANITIZE_STRING,
83			'meta_key' => '_pronamic_gateway_multisafepay_site_code',
84			'title' => __( 'Site Security Code', 'pronamic_ideal' ),
85			'type' => 'text',
86			'classes' => array( 'code' ),
87			'tooltip' => sprintf(
88			'%s %s.',
89			__( 'Site Security Code', 'pronamic_ideal' ),
90			/* translators: %s: MultiSafepay */
91			sprintf( __( 'as mentioned in the %s dashboard', 'pronamic_ideal' ), __( 'MultiSafepay', 'pronamic_ideal' ) )
92			),
93			);
94
95			return $fields;
96			}
97			}
98

wp-pay-gateways / multisafepay

Push — develop ( fd928b...40893b )

Integration::get_settings_fields() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like