DirectTransactionRequestMessage::get_document() - Code Metrics - Inspection of "Coding standards." - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 43aea2...d560c3 )

by Reüel

created 2021-01-22 13:01 UTC

DirectTransactionRequestMessage::get_document() B

↳ Parent: DirectTransactionRequestMessage

Complexity

Conditions	2
Paths	2

Size

Total Lines	81
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	49
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	56
c	1
b	0
f	0
dl	0
loc	81
ccs	49
cts	49
cp	1
rs	8.9599
cc	2
nc	2
nop	0
crap	2

How to fix Long Method

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML;

use Pronamic\WordPress\Pay\Core\XML\Util as XML_Util;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Customer;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\GatewayInfo;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Merchant;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Transaction;

/**
 * Title: MultiSafepay Connect XML direct transaction request message
 * Description:
 * Copyright: 2005-2021 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.2
 * @since   1.2.0
 */
class DirectTransactionRequestMessage extends RequestMessage {
	/**
	 * The document element name
	 *
	 * @var string
	 */
	const NAME = 'directtransaction';

	/**
	 * Gateway info.
	 *
	 * @var GatewayInfo
	 */
	private $gateway_info;

	/**
	 * Constructs and initialize an directory response message
	 *
	 * @param Merchant    $merchant     Merchant.
	 * @param Customer    $customer     Customer.
	 * @param Transaction $transaction  Transaction.
	 * @param GatewayInfo $gateway_info Gateway info.
	 */
	public function __construct( Merchant $merchant, Customer $customer, Transaction $transaction, GatewayInfo $gateway_info = null ) {
		parent::__construct( self::NAME );

		$this->merchant     = $merchant;
		$this->customer     = $customer;
		$this->transaction  = $transaction;
		$this->gateway_info = $gateway_info;
	}

	/**
	 * Get document
	 *
	 * @see Pronamic_Gateways_IDealAdvancedV3_XML_RequestMessage::get_document()
	 */
	public function get_document() {
		$document = parent::get_document();

		// Merchant.
		$merchant = XML_Util::add_element( $document, $document->documentElement, 'merchant' );

		XML_Util::add_elements(
			$document,
			$merchant,
			array(
				'account'          => $this->merchant->account,
				'site_id'          => $this->merchant->site_id,
				'site_secure_code' => $this->merchant->site_secure_code,
				'notification_url' => $this->merchant->notification_url,
				'redirect_url'     => $this->merchant->redirect_url,
				'cancel_url'       => $this->merchant->cancel_url,
				'close_window'     => $this->merchant->close_window,
			)
		);

		// Customer.
		$customer = XML_Util::add_element( $document, $document->documentElement, 'customer' );

		XML_Util::add_elements(
			$document,
			$customer,
			array(
				'locale'      => $this->customer->locale,
				'ipaddress'   => $this->customer->ip_address,
				'forwardedip' => $this->customer->forwarded_ip,
				'firstname'   => $this->customer->first_name,
				'lastname'    => $this->customer->last_name,
				'address1'    => $this->customer->address_1,
				'address2'    => $this->customer->address_2,
				'housenumber' => $this->customer->house_number,
				'zipcode'     => $this->customer->zip_code,
				'city'        => $this->customer->city,
				'country'     => $this->customer->country,
				'phone'       => $this->customer->phone,
				'email'       => $this->customer->email,
			)
		);

		// Transaction.
		$transaction = XML_Util::add_element( $document, $document->documentElement, 'transaction' );

		XML_Util::add_elements(
			$document,
			$transaction,
			array(
				'id'          => $this->transaction->id,
				'currency'    => $this->transaction->currency,
				'amount'      => $this->transaction->amount,
				'description' => $this->transaction->description,
				'var1'        => $this->transaction->var1,
				'var2'        => $this->transaction->var2,
				'var3'        => $this->transaction->var3,
				'items'       => $this->transaction->items,
				'manual'      => $this->transaction->manual,
				'gateway'     => $this->transaction->gateway,
				'daysactive'  => $this->transaction->days_active,
			)
		);

		// Gateway info.
		if ( $this->gateway_info ) {
			$gateway_info = XML_Util::add_element( $document, $document->documentElement, 'gatewayinfo' );

			XML_Util::add_elements(
				$document,
				$gateway_info,
				array(
					'issuerid' => $this->gateway_info->issuer_id,
				)
			);
		}

		// Signature.
		XML_Util::add_element( $document, $document->documentElement, 'signature', $this->signature );


		return $document;
	}
}


1		<?php
2
3		namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML;
4
5		use Pronamic\WordPress\Pay\Core\XML\Util as XML_Util;
6		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Customer;
7		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\GatewayInfo;
8		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Merchant;
9		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\Transaction;
10
11		/**
12		* Title: MultiSafepay Connect XML direct transaction request message
13		* Description:
14		* Copyright: 2005-2021 Pronamic
15		* Company: Pronamic
16		*
17		* @author Remco Tolsma
18		* @version 2.0.2
19		* @since 1.2.0
20		*/
21		class DirectTransactionRequestMessage extends RequestMessage {
22		/**
23		* The document element name
24		*
25		* @var string
26		*/
27		const NAME = 'directtransaction';
28
29		/**
30		* Gateway info.
31		*
32		* @var GatewayInfo
33		*/
34		private $gateway_info;
35
36		/**
37		* Constructs and initialize an directory response message
38		*
39		* @param Merchant $merchant Merchant.
40		* @param Customer $customer Customer.
41		* @param Transaction $transaction Transaction.
42		* @param GatewayInfo $gateway_info Gateway info.
43		*/
44	1	public function __construct( Merchant $merchant, Customer $customer, Transaction $transaction, GatewayInfo $gateway_info = null ) {
45	1	parent::__construct( self::NAME );
46
47	1	$this->merchant = $merchant;
48	1	$this->customer = $customer;
49	1	$this->transaction = $transaction;
50	1	$this->gateway_info = $gateway_info;
51	1	}
52
53		/**
54		* Get document
55		*
56		* @see Pronamic_Gateways_IDealAdvancedV3_XML_RequestMessage::get_document()
57		*/
58	1	public function get_document() {
59	1	$document = parent::get_document();
60
61		// Merchant.
62	1	$merchant = XML_Util::add_element( $document, $document->documentElement, 'merchant' );
63
64	1	XML_Util::add_elements(
65	1	$document,
66		$merchant,
67		array(
68	1	'account' => $this->merchant->account,
69	1	'site_id' => $this->merchant->site_id,
70	1	'site_secure_code' => $this->merchant->site_secure_code,
71	1	'notification_url' => $this->merchant->notification_url,
72	1	'redirect_url' => $this->merchant->redirect_url,
73	1	'cancel_url' => $this->merchant->cancel_url,
74	1	'close_window' => $this->merchant->close_window,
75		)
76		);
77
78		// Customer.
79	1	$customer = XML_Util::add_element( $document, $document->documentElement, 'customer' );
80
81	1	XML_Util::add_elements(
82	1	$document,
83		$customer,
84		array(
85	1	'locale' => $this->customer->locale,
86	1	'ipaddress' => $this->customer->ip_address,
87	1	'forwardedip' => $this->customer->forwarded_ip,
88	1	'firstname' => $this->customer->first_name,
89	1	'lastname' => $this->customer->last_name,
90	1	'address1' => $this->customer->address_1,
91	1	'address2' => $this->customer->address_2,
92	1	'housenumber' => $this->customer->house_number,
93	1	'zipcode' => $this->customer->zip_code,
94	1	'city' => $this->customer->city,
95	1	'country' => $this->customer->country,
96	1	'phone' => $this->customer->phone,
97	1	'email' => $this->customer->email,
98		)
99		);
100
101		// Transaction.
102	1	$transaction = XML_Util::add_element( $document, $document->documentElement, 'transaction' );
103
104	1	XML_Util::add_elements(
105	1	$document,
106		$transaction,
107		array(
108	1	'id' => $this->transaction->id,
109	1	'currency' => $this->transaction->currency,
110	1	'amount' => $this->transaction->amount,
111	1	'description' => $this->transaction->description,
112	1	'var1' => $this->transaction->var1,
113	1	'var2' => $this->transaction->var2,
114	1	'var3' => $this->transaction->var3,
115	1	'items' => $this->transaction->items,
116	1	'manual' => $this->transaction->manual,
117	1	'gateway' => $this->transaction->gateway,
118	1	'daysactive' => $this->transaction->days_active,
119		)
120		);
121
122		// Gateway info.
123	1	if ( $this->gateway_info ) {
124	1	$gateway_info = XML_Util::add_element( $document, $document->documentElement, 'gatewayinfo' );
125
126	1	XML_Util::add_elements(
127	1	$document,
128		$gateway_info,
129		array(
130	1	'issuerid' => $this->gateway_info->issuer_id,
131		)
132		);
133		}
134
135		// Signature.
136	1	XML_Util::add_element( $document, $document->documentElement, 'signature', $this->signature );
		0 ignored issues – show Bug Best Practice introduced 2019-06-04 12:06 UTC by Report Bug Copy Issue Report The property `signature` does not exist on `Pronamic\WordPress\Pay\G...ansactionRequestMessage`. Did you maybe forget to declare it? Loading history...
137
138	1	return $document;
139		}
140		}
141

wp-pay-gateways / multisafepay

Push — develop ( 43aea2...d560c3 )

DirectTransactionRequestMessage::get_document() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like