DirectTransactionResponseMessage::parse() - Code Metrics - Inspection of "Merge branch 'release/2.0.5'" - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — master ( 90f63b...5c8958 )

by Reüel

created 2019-12-22 21:58 UTC

DirectTransactionResponseMessage::parse() A

↳ Parent: DirectTransactionResponseMessage

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	19
ccs	10
cts	10
cp	1
rs	9.9666
cc	2
nc	2
nop	1
crap	2

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML;

use Pronamic\WordPress\Pay\Core\XML\Security;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\GatewayInfo;
use SimpleXMLElement;

/**
 * Title: MultiSafepay Connect XML direct transaction response message
 * Description:
 * Copyright: 2005-2019 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.2
 * @since   1.2.0
 */
class DirectTransactionResponseMessage {
	/**
	 * Result
	 *
	 * @var string
	 */
	public $result;

	/**
	 * Transaction
	 *
	 * @var DirectTransactionResponseMessage
	 */
	public $transaction;

	/**
	 * Gateway info.
	 *
	 * @var GatewayInfo
	 */
	public $gateway_info;

	/**
	 * Parse the specified XML element into an iDEAL transaction object
	 *
	 * @param SimpleXMLElement $xml
	 *
	 * @return DirectTransactionResponseMessage
	 */
	public static function parse( SimpleXMLElement $xml ) {
		// Message
		$message = new DirectTransactionResponseMessage();

		// Result
		$message->result = Security::filter( $xml['result'] );

		// Transaction
		$message->transaction = TransactionParser::parse( $xml->transaction );


		// Gateway info
		if ( $xml->gatewayinfo ) {
			$message->gateway_info               = new GatewayInfo();
			$message->gateway_info->redirect_url = Security::filter( $xml->gatewayinfo->redirecturl );
			$message->gateway_info->ext_var      = Security::filter( $xml->gatewayinfo->extvar );
			$message->gateway_info->issuer_id    = Security::filter( $xml->gatewayinfo->issuerid );
		}

		return $message;
	}
}


1		<?php
2
3		namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML;
4
5		use Pronamic\WordPress\Pay\Core\XML\Security;
6		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\GatewayInfo;
7		use SimpleXMLElement;
8
9		/**
10		* Title: MultiSafepay Connect XML direct transaction response message
11		* Description:
12		* Copyright: 2005-2019 Pronamic
13		* Company: Pronamic
14		*
15		* @author Remco Tolsma
16		* @version 2.0.2
17		* @since 1.2.0
18		*/
19		class DirectTransactionResponseMessage {
20		/**
21		* Result
22		*
23		* @var string
24		*/
25		public $result;
26
27		/**
28		* Transaction
29		*
30		* @var DirectTransactionResponseMessage
31		*/
32		public $transaction;
33
34		/**
35		* Gateway info.
36		*
37		* @var GatewayInfo
38		*/
39		public $gateway_info;
40
41		/**
42		* Parse the specified XML element into an iDEAL transaction object
43		*
44		* @param SimpleXMLElement $xml
45		*
46		* @return DirectTransactionResponseMessage
47		*/
48	2	public static function parse( SimpleXMLElement $xml ) {
49		// Message
50	2	$message = new DirectTransactionResponseMessage();
51
52		// Result
53	2	$message->result = Security::filter( $xml['result'] );
54
55		// Transaction
56	2	$message->transaction = TransactionParser::parse( $xml->transaction );
		0 ignored issues – show Documentation Bug introduced 2019-06-04 12:06 UTC by Report Bug Copy Issue Report It seems like `Pronamic\WordPress\Pay\G...arse($xml->transaction)` of type `Pronamic\WordPress\Pay\G...ultiSafepay\Transaction` is incompatible with the declared type `Pronamic\WordPress\Pay\G...nsactionResponseMessage` of property `$transaction`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
57
58		// Gateway info
59	2	if ( $xml->gatewayinfo ) {
60	2	$message->gateway_info = new GatewayInfo();
61	2	$message->gateway_info->redirect_url = Security::filter( $xml->gatewayinfo->redirecturl );
62	2	$message->gateway_info->ext_var = Security::filter( $xml->gatewayinfo->extvar );
63	2	$message->gateway_info->issuer_id = Security::filter( $xml->gatewayinfo->issuerid );
64		}
65
66	2	return $message;
67		}
68		}
69

wp-pay-gateways / multisafepay

Push — master ( 90f63b...5c8958 )

DirectTransactionResponseMessage::parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like