Issues in Gateway.php - New Issues - Inspection of "Update setting consumer bank details." - wp-pay-gateways/multisafepay - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 39b9b1...0f6081 )

by Reüel

created 2020-04-29 19:48 UTC

src/Gateway.php (2 issues)

Labels

Bug 2

Severity

Major 2

<?php

namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;

use Pronamic\WordPress\Pay\Banks\BankAccountDetails;
use Pronamic\WordPress\Pay\Core\Gateway as Core_Gateway;
use Pronamic\WordPress\Pay\Core\PaymentMethods;
use Pronamic\WordPress\Pay\Core\Server;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\DirectTransactionRequestMessage;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\RedirectTransactionRequestMessage;
use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\StatusRequestMessage;
use Pronamic\WordPress\Pay\Payments\Payment;

/**
 * Title: MultiSafepay Connect gateay
 * Description:
 * Copyright: 2005-2020 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 2.0.3
 * @since   1.0.1
 */
class Gateway extends Core_Gateway {
	/**
	 * Client.
	 *
	 * @var Client
	 */
	protected $client;

	/**
	 * Config
	 *
	 * @var Config
	 */
	protected $config;

	/**
	 * Constructs and initializes an MultiSafepay Connect gateway
	 *
	 * @param Config $config Config.
	 */
	public function __construct( Config $config ) {
		parent::__construct( $config );

		$this->set_method( self::METHOD_HTTP_REDIRECT );

		// Supported features.
		$this->supports = array(
			'payment_status_request',
		);

		// Client.
		$this->client = new Client();

		$this->client->api_url = $config->api_url;
	}

	/**
	 * Get iDEAL issuers
	 *
	 * @see Core_Gateway::get_issuers()
	 * @since 1.2.0
	 */
	public function get_issuers() {
		$groups = array();

		// Merchant.
		$merchant                   = new Merchant();
		$merchant->account          = $this->config->account_id;
		$merchant->site_id          = $this->config->site_id;
		$merchant->site_secure_code = $this->config->site_code;

		$result = $this->client->get_ideal_issuers( $merchant );

		if ( $result ) {
			$groups[] = array(
				'options' => $result,
			);
		}

		return $groups;
	}

	/**
	 * Get credit card issuers
	 *
	 * @see Core_Gateway::get_credit_card_issuers()
	 */
	public function get_credit_card_issuers() {
		$groups[] = array(
			'options' => array(
				Methods::AMEX       => _x( 'AMEX', 'Payment method name', 'pronamic_ideal' ),
				Methods::MAESTRO    => _x( 'Maestro', 'Payment method name', 'pronamic_ideal' ),
				Methods::MASTERCARD => _x( 'MASTER', 'Payment method name', 'pronamic_ideal' ),
				Methods::VISA       => _x( 'VISA', 'Payment method name', 'pronamic_ideal' ),
			),
		);

		return $groups;
	}

	/**
	 * Get payment methods
	 *
	 * @see Pronamic_WP_Pay_Gateway::get_payment_methods()
	 */
	public function get_available_payment_methods() {
		$payment_methods = array();

		// Merchant.
		$merchant                   = new Merchant();
		$merchant->account          = $this->config->account_id;
		$merchant->site_id          = $this->config->site_id;
		$merchant->site_secure_code = $this->config->site_code;

		// Customer.
		$customer = new Customer();

		// Get gateways.
		try {
			$result = $this->client->get_gateways( $merchant, $customer );
		} catch ( \Exception $e ) {
			$error = new \WP_Error( 'multisafepay_error', $e->getMessage() );

			$this->set_error( $error );

			return $payment_methods;
		}

		if ( false === $result ) {
			return $payment_methods;
		}

		foreach ( $result as $method => $title ) {
			$payment_method = Methods::transform_gateway_method( $method );

			if ( $payment_method ) {
				$payment_methods[] = $payment_method;
			}
		}

		return $payment_methods;
	}

	/**
	 * Get supported payment methods
	 *
	 * @see Pronamic_WP_Pay_Gateway::get_supported_payment_methods()
	 */
	public function get_supported_payment_methods() {
		return array(
			PaymentMethods::ALIPAY,
			PaymentMethods::BANCONTACT,
			PaymentMethods::BANK_TRANSFER,
			PaymentMethods::BELFIUS,
			PaymentMethods::CREDIT_CARD,
			PaymentMethods::DIRECT_DEBIT,
			PaymentMethods::IDEAL,
			PaymentMethods::IDEALQR,
			PaymentMethods::GIROPAY,
			PaymentMethods::KBC,
			PaymentMethods::PAYPAL,
			PaymentMethods::SOFORT,
		);
	}

	/**
	 * Start payment.
	 *
	 * @param Payment $payment Payment object.
	 */
	public function start( Payment $payment ) {
		$payment_method = $payment->get_method();

		$transaction_description = $payment->get_description();

		if ( empty( $transaction_description ) ) {
			$transaction_description = $payment->get_id();
		}

		// Merchant.
		$merchant                   = new Merchant();
		$merchant->account          = $this->config->account_id;
		$merchant->site_id          = $this->config->site_id;
		$merchant->site_secure_code = $this->config->site_code;
		$merchant->notification_url = $payment->get_return_url();
		$merchant->redirect_url     = $payment->get_return_url();
		$merchant->cancel_url       = $payment->get_return_url();
		$merchant->close_window     = 'false';

		// Customer.
		$customer               = new Customer();
		$customer->ip_address   = Server::get( 'REMOTE_ADDR', FILTER_VALIDATE_IP );
		$customer->forwarded_ip = Server::get( 'HTTP_X_FORWARDED_FOR', FILTER_VALIDATE_IP );

		if ( null !== $payment->get_customer() ) {
			$name = $payment->get_customer()->get_name();

			if ( null !== $name ) {
				$customer->first_name = $name->get_first_name();
				$customer->last_name  = $name->get_last_name();
			}

			$customer->locale = $payment->get_customer()->get_locale();
			$customer->email  = $payment->get_customer()->get_email();
		}

		// Transaction.
		$transaction              = new Transaction();
		$transaction->id          = uniqid();
		$transaction->currency    = $payment->get_total_amount()->get_currency()->get_alphabetic_code();
		$transaction->amount      = $payment->get_total_amount()->get_cents();
		$transaction->description = $transaction_description;

		switch ( $payment_method ) {
			case PaymentMethods::IDEAL:
				$transaction->gateway = Methods::IDEAL;

				$issuer = $payment->get_issuer();

				if ( empty( $issuer ) ) {
					$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );
				} else {
					$gateway_info = new GatewayInfo();

					$gateway_info->issuer_id = $issuer;

					$message = new DirectTransactionRequestMessage( $merchant, $customer, $transaction, $gateway_info );
				}

				break;
			case PaymentMethods::CREDIT_CARD:
				$gateway = Methods::transform( $payment_method );

				$issuer = $payment->get_issuer();

				if ( empty( $issuer ) ) {
					if ( $gateway ) {
						$transaction->gateway = $gateway;
					}
				} else {
					$transaction->gateway = $issuer;
				}

				$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );

				break;
			default:
				$gateway = Methods::transform( $payment_method );

				if ( $gateway ) {
					$transaction->gateway = $gateway;
				}

				if ( ! isset( $transaction->gateway ) && ! empty( $payment_method ) ) {
					// Leap of faith if the WordPress payment method could not transform to a Mollie method?
					$transaction->gateway = $payment_method;
				}

				$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );
		}

		$signature = Signature::generate( $transaction->amount, $transaction->currency, $merchant->account, $merchant->site_id, $transaction->id );

		$message->signature = $signature;

		try {
			$response = $this->client->start_transaction( $message );
		} catch ( \Exception $e ) {
			$error = new \WP_Error( 'multisafepay_error', $e->getMessage() );

			$this->set_error( $error );

			return;
		}

		if ( false !== $response ) {
			$transaction = $response->transaction;

			$payment->set_transaction_id( $transaction->id );

			if ( isset( $transaction->payment_url ) ) {
				$payment->set_action_url( $transaction->payment_url );
			}

			if ( isset( $response->gateway_info->redirect_url ) ) {
				$payment->set_action_url( $response->gateway_info->redirect_url );
			}
		}
	}

	/**
	 * Update status.
	 *
	 * @param Payment $payment Payment.
	 */
	public function update_status( Payment $payment ) {
		$merchant = new Merchant();

		$merchant->account          = $this->config->account_id;
		$merchant->site_id          = $this->config->site_id;
		$merchant->site_secure_code = $this->config->site_code;

		$message = new StatusRequestMessage( $merchant, $payment->get_transaction_id() );

		try {
			$result = $this->client->get_status( $message );
		} catch ( \Exception $e ) {
			$this->error = new \WP_Error( 'multisafepay_error', $e->getMessage() );

			return;
		}

		if ( false === $result ) {
			return;
		}

		// Status.
		$status = Statuses::transform( $result->ewallet->status );

		$payment->set_status( $status );

		// Consumer bank details.
		$consumer_bank_details = $payment->get_consumer_bank_details();

		if ( null === $consumer_bank_details ) {
			$consumer_bank_details = new BankAccountDetails();

			$payment->set_consumer_bank_details( $consumer_bank_details );
		}

		$consumer_bank_details->set_name( $result->payment_details->account_holder_name );

		$consumer_bank_details->set_iban( $result->payment_details->account_iban );
		$consumer_bank_details->set_bic( $result->payment_details->account_bic );
		$consumer_bank_details->set_account_number( $result->payment_details->account_id );
	}
}


1		<?php
2
3		namespace Pronamic\WordPress\Pay\Gateways\MultiSafepay;
4
5		use Pronamic\WordPress\Pay\Banks\BankAccountDetails;
6		use Pronamic\WordPress\Pay\Core\Gateway as Core_Gateway;
7		use Pronamic\WordPress\Pay\Core\PaymentMethods;
8		use Pronamic\WordPress\Pay\Core\Server;
9		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\DirectTransactionRequestMessage;
10		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\RedirectTransactionRequestMessage;
11		use Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\StatusRequestMessage;
12		use Pronamic\WordPress\Pay\Payments\Payment;
13
14		/**
15		* Title: MultiSafepay Connect gateay
16		* Description:
17		* Copyright: 2005-2020 Pronamic
18		* Company: Pronamic
19		*
20		* @author Remco Tolsma
21		* @version 2.0.3
22		* @since 1.0.1
23		*/
24		class Gateway extends Core_Gateway {
25		/**
26		* Client.
27		*
28		* @var Client
29		*/
30		protected $client;
31
32		/**
33		* Config
34		*
35		* @var Config
36		*/
37		protected $config;
38
39		/**
40		* Constructs and initializes an MultiSafepay Connect gateway
41		*
42		* @param Config $config Config.
43		*/
44	1	public function __construct( Config $config ) {
45	1	parent::__construct( $config );
46
47	1	$this->set_method( self::METHOD_HTTP_REDIRECT );
48
49		// Supported features.
50	1	$this->supports = array(
51		'payment_status_request',
52		);
53
54		// Client.
55	1	$this->client = new Client();
56
57	1	$this->client->api_url = $config->api_url;
58	1	}
59
60		/**
61		* Get iDEAL issuers
62		*
63		* @see Core_Gateway::get_issuers()
64		* @since 1.2.0
65		*/
66	1	public function get_issuers() {
67	1	$groups = array();
68
69		// Merchant.
70	1	$merchant = new Merchant();
71	1	$merchant->account = $this->config->account_id;
72	1	$merchant->site_id = $this->config->site_id;
73	1	$merchant->site_secure_code = $this->config->site_code;
74
75	1	$result = $this->client->get_ideal_issuers( $merchant );
76
77	1	if ( $result ) {
78	1	$groups[] = array(
79	1	'options' => $result,
80		);
81		}
82
83	1	return $groups;
84		}
85
86		/**
87		* Get credit card issuers
88		*
89		* @see Core_Gateway::get_credit_card_issuers()
90		*/
91		public function get_credit_card_issuers() {
92		$groups[] = array(
93		'options' => array(
94		Methods::AMEX => _x( 'AMEX', 'Payment method name', 'pronamic_ideal' ),
95		Methods::MAESTRO => _x( 'Maestro', 'Payment method name', 'pronamic_ideal' ),
96		Methods::MASTERCARD => _x( 'MASTER', 'Payment method name', 'pronamic_ideal' ),
97		Methods::VISA => _x( 'VISA', 'Payment method name', 'pronamic_ideal' ),
98		),
99		);
100
101		return $groups;
102		}
103
104		/**
105		* Get payment methods
106		*
107		* @see Pronamic_WP_Pay_Gateway::get_payment_methods()
108		*/
109		public function get_available_payment_methods() {
110		$payment_methods = array();
111
112		// Merchant.
113		$merchant = new Merchant();
114		$merchant->account = $this->config->account_id;
115		$merchant->site_id = $this->config->site_id;
116		$merchant->site_secure_code = $this->config->site_code;
117
118		// Customer.
119		$customer = new Customer();
120
121		// Get gateways.
122		try {
123		$result = $this->client->get_gateways( $merchant, $customer );
124		} catch ( \Exception $e ) {
125		$error = new \WP_Error( 'multisafepay_error', $e->getMessage() );
126
127		$this->set_error( $error );
128
129		return $payment_methods;
130		}
131
132		if ( false === $result ) {
133		return $payment_methods;
134		}
135
136		foreach ( $result as $method => $title ) {
137		$payment_method = Methods::transform_gateway_method( $method );
138
139		if ( $payment_method ) {
140		$payment_methods[] = $payment_method;
141		}
142		}
143
144		return $payment_methods;
145		}
146
147		/**
148		* Get supported payment methods
149		*
150		* @see Pronamic_WP_Pay_Gateway::get_supported_payment_methods()
151		*/
152		public function get_supported_payment_methods() {
153		return array(
154		PaymentMethods::ALIPAY,
155		PaymentMethods::BANCONTACT,
156		PaymentMethods::BANK_TRANSFER,
157		PaymentMethods::BELFIUS,
158		PaymentMethods::CREDIT_CARD,
159		PaymentMethods::DIRECT_DEBIT,
160		PaymentMethods::IDEAL,
161		PaymentMethods::IDEALQR,
162		PaymentMethods::GIROPAY,
163		PaymentMethods::KBC,
164		PaymentMethods::PAYPAL,
165		PaymentMethods::SOFORT,
166		);
167		}
168
169		/**
170		* Start payment.
171		*
172		* @param Payment $payment Payment object.
173		*/
174		public function start( Payment $payment ) {
175		$payment_method = $payment->get_method();
176
177		$transaction_description = $payment->get_description();
178
179		if ( empty( $transaction_description ) ) {
180		$transaction_description = $payment->get_id();
181		}
182
183		// Merchant.
184		$merchant = new Merchant();
185		$merchant->account = $this->config->account_id;
186		$merchant->site_id = $this->config->site_id;
187		$merchant->site_secure_code = $this->config->site_code;
188		$merchant->notification_url = $payment->get_return_url();
189		$merchant->redirect_url = $payment->get_return_url();
190		$merchant->cancel_url = $payment->get_return_url();
191		$merchant->close_window = 'false';
192
193		// Customer.
194		$customer = new Customer();
195		$customer->ip_address = Server::get( 'REMOTE_ADDR', FILTER_VALIDATE_IP );
196		$customer->forwarded_ip = Server::get( 'HTTP_X_FORWARDED_FOR', FILTER_VALIDATE_IP );
197
198		if ( null !== $payment->get_customer() ) {
199		$name = $payment->get_customer()->get_name();
200
201		if ( null !== $name ) {
202		$customer->first_name = $name->get_first_name();
203		$customer->last_name = $name->get_last_name();
204		}
205
206		$customer->locale = $payment->get_customer()->get_locale();
207		$customer->email = $payment->get_customer()->get_email();
208		}
209
210		// Transaction.
211		$transaction = new Transaction();
212		$transaction->id = uniqid();
213		$transaction->currency = $payment->get_total_amount()->get_currency()->get_alphabetic_code();
214		$transaction->amount = $payment->get_total_amount()->get_cents();
215		$transaction->description = $transaction_description;
216
217		switch ( $payment_method ) {
218		case PaymentMethods::IDEAL:
219		$transaction->gateway = Methods::IDEAL;
220
221		$issuer = $payment->get_issuer();
222
223		if ( empty( $issuer ) ) {
224		$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );
225		} else {
226		$gateway_info = new GatewayInfo();
227
228		$gateway_info->issuer_id = $issuer;
229
230		$message = new DirectTransactionRequestMessage( $merchant, $customer, $transaction, $gateway_info );
231		}
232
233		break;
234		case PaymentMethods::CREDIT_CARD:
235		$gateway = Methods::transform( $payment_method );
236
237		$issuer = $payment->get_issuer();
238
239		if ( empty( $issuer ) ) {
240		if ( $gateway ) {
241		$transaction->gateway = $gateway;
242		}
243		} else {
244		$transaction->gateway = $issuer;
245		}
246
247		$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );
248
249		break;
250		default:
251		$gateway = Methods::transform( $payment_method );
252
253		if ( $gateway ) {
254		$transaction->gateway = $gateway;
255		}
256
257		if ( ! isset( $transaction->gateway ) && ! empty( $payment_method ) ) {
258		// Leap of faith if the WordPress payment method could not transform to a Mollie method?
259		$transaction->gateway = $payment_method;
260		}
261
262		$message = new RedirectTransactionRequestMessage( $merchant, $customer, $transaction );
263		}
264
265		$signature = Signature::generate( $transaction->amount, $transaction->currency, $merchant->account, $merchant->site_id, $transaction->id );
266
267		$message->signature = $signature;
268
269		try {
270		$response = $this->client->start_transaction( $message );
271		} catch ( \Exception $e ) {
272		$error = new \WP_Error( 'multisafepay_error', $e->getMessage() );
273
274		$this->set_error( $error );
275
276		return;
277		}
278
279		if ( false !== $response ) {
280		$transaction = $response->transaction;
281
282		$payment->set_transaction_id( $transaction->id );
283
284		if ( isset( $transaction->payment_url ) ) {
285		$payment->set_action_url( $transaction->payment_url );
286		}
287
288		if ( isset( $response->gateway_info->redirect_url ) ) {
289		$payment->set_action_url( $response->gateway_info->redirect_url );
290		}
291		}
292		}
293
294		/**
295		* Update status.
296		*
297		* @param Payment $payment Payment.
298		*/
299		public function update_status( Payment $payment ) {
300		$merchant = new Merchant();
301
302		$merchant->account = $this->config->account_id;
303		$merchant->site_id = $this->config->site_id;
304		$merchant->site_secure_code = $this->config->site_code;
305
306		$message = new StatusRequestMessage( $merchant, $payment->get_transaction_id() );
307
308		try {
309		$result = $this->client->get_status( $message );
310		} catch ( \Exception $e ) {
311		$this->error = new \WP_Error( 'multisafepay_error', $e->getMessage() );
312
313		return;
314		}
315
316		if ( false === $result ) {
317		return;
318		}
319
320		// Status.
321		$status = Statuses::transform( $result->ewallet->status );
322
323		$payment->set_status( $status );
324
325		// Consumer bank details.
326		$consumer_bank_details = $payment->get_consumer_bank_details();
327
328		if ( null === $consumer_bank_details ) {
329		$consumer_bank_details = new BankAccountDetails();
330
331		$payment->set_consumer_bank_details( $consumer_bank_details );
332		}
333
334		$consumer_bank_details->set_name( $result->payment_details->account_holder_name );
		0 ignored issues – show Bug introduced 2020-04-29 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `payment_details` does not seem to exist on `Pronamic\WordPress\Pay\G...nsactionResponseMessage`. Loading history... Bug introduced 2020-04-29 20:11 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `payment_details` does not seem to exist on `Pronamic\WordPress\Pay\G...nsactionResponseMessage`. Loading history...
335		$consumer_bank_details->set_iban( $result->payment_details->account_iban );
336		$consumer_bank_details->set_bic( $result->payment_details->account_bic );
337		$consumer_bank_details->set_account_number( $result->payment_details->account_id );
338		}
339		}
340

wp-pay-gateways / multisafepay

Push — develop ( 39b9b1...0f6081 )

src/Gateway.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like