Pronamic\WordPress\Pay\Gateways\MultiSafepay\XML\IDealIssuersResponseMessage::parse()

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

<?php
	public static function parse( SimpleXMLElement $xml ) {
		$message = new IDealIssuersResponseMessage();

		$message->issuers = array();

The property issuers does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

		foreach ( $xml->issuers->issuer as $issuer ) {
			$code        = Security::filter( $issuer->code );
			$description = Security::filter( $issuer->description );

			$message->issuers[ $code ] = $description;
		}

		return $message;
	}