ProfileDataStore::save_profile() - Code Metrics - Inspection of "vendor/bin/phpcbf" - wp-pay-gateways/mollie - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 889b97...9fde12 )

by Remco

created 2020-02-26 15:27 UTC

ProfileDataStore::save_profile() A

↳ Parent: ProfileDataStore

Complexity

Conditions	4
Paths	4

Size

Total Lines	55
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	34
c	1
b	0
f	0
nc	4
nop	3
dl	0
loc	55
rs	9.376

How to fix Long Method

<?php
/**
 * Mollie profile data store.
 *
 * @author    Pronamic <[email protected]>
 * @copyright 2005-2020 Pronamic
 * @license   GPL-3.0-or-later
 * @package   Pronamic\WordPress\Pay
 */

namespace Pronamic\WordPress\Pay\Gateways\Mollie;

/**
 * Title: Mollie profile data store
 * Description:
 * Copyright: 2005-2020 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 3.0.0
 * @since   3.0.0
 */
class ProfileDataStore {
	/**
	 * Get profile data for specified Mollie profile.
	 *
	 * @param Profile $profile Profile.
	 * @return object|null
	 */
	public function get_profile( Profile $profile ) {
		global $wpdb;

		$id = $profile->get_id();

		if ( null === $id ) {
			return null;
		}

		$query = $wpdb->prepare( "SELECT * FROM $wpdb->pronamic_pay_mollie_profiles WHERE mollie_id = %s LIMIT 1;", $id );

		$data = $wpdb->get_row( $query );

		return $data;
	}

	/**
	 * Save Mollie profile.
	 *
	 * @param Profile $profile Profile.
	 * @param array   $data   Data.
	 * @param array   $format Format.
	 * @return int
	 */
	public function save_profile( Profile $profile, $data = array(), $format = array() ) {
		global $wpdb;

		$id = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM $wpdb->pronamic_pay_mollie_profiles WHERE mollie_id = %s", $profile->get_id() ) );

		$data['email']   = $profile->email;

		$format['email'] = '%s';

		$data['name']   = $profile->name;

		$format['name'] = '%s';

		if ( null === $id ) {
			$data['mollie_id']   = $profile->get_id();
			$foramt['mollie_id'] = '%s';


			$result = $wpdb->insert(
				$wpdb->pronamic_pay_mollie_profiles,
				$data,
				$format
			);

			if ( false === $result ) {
				\WP_CLI::error(
filter:
    dependency_paths: ["lib/*"]
					sprintf(
						'Database error: %s.',
						$wpdb->last_error
					)
				);
			}

			$id = $wpdb->insert_id;
		} else {
			$result = $wpdb->update(
				$wpdb->pronamic_pay_mollie_profiles,
				$data,
				array(
					'id' => $id,
				),
				$format,
				array(
					'id' => '%d',
				)
			);

			if ( false === $result ) {
				\WP_CLI::error(
					sprintf(
						'Database error: %s.',
						$wpdb->last_error
					)
				);
			}
		}

		return $id;
	}
}


1			<?php
2			/**
3			* Mollie profile data store.
4			*
5			* @author Pronamic <[email protected]>
6			* @copyright 2005-2020 Pronamic
7			* @license GPL-3.0-or-later
8			* @package Pronamic\WordPress\Pay
9			*/
10
11			namespace Pronamic\WordPress\Pay\Gateways\Mollie;
12
13			/**
14			* Title: Mollie profile data store
15			* Description:
16			* Copyright: 2005-2020 Pronamic
17			* Company: Pronamic
18			*
19			* @author Remco Tolsma
20			* @version 3.0.0
21			* @since 3.0.0
22			*/
23			class ProfileDataStore {
24			/**
25			* Get profile data for specified Mollie profile.
26			*
27			* @param Profile $profile Profile.
28			* @return object\|null
29			*/
30			public function get_profile( Profile $profile ) {
31			global $wpdb;
32
33			$id = $profile->get_id();
34
35			if ( null === $id ) {
36			return null;
37			}
38
39			$query = $wpdb->prepare( "SELECT * FROM $wpdb->pronamic_pay_mollie_profiles WHERE mollie_id = %s LIMIT 1;", $id );
40
41			$data = $wpdb->get_row( $query );
42
43			return $data;
44			}
45
46			/**
47			* Save Mollie profile.
48			*
49			* @param Profile $profile Profile.
50			* @param array $data Data.
51			* @param array $format Format.
52			* @return int
53			*/
54			public function save_profile( Profile $profile, $data = array(), $format = array() ) {
55			global $wpdb;
56
57			$id = $wpdb->get_var( $wpdb->prepare( "SELECT id FROM $wpdb->pronamic_pay_mollie_profiles WHERE mollie_id = %s", $profile->get_id() ) );
58
59			$data['email'] = $profile->email;
			0 ignored issues – show Bug introduced 2020-02-26 15:26 UTC by Report Bug Copy Issue Report The property `email` does not seem to exist on `Pronamic\WordPress\Pay\Gateways\Mollie\Profile`. Loading history...
60			$format['email'] = '%s';
61
62			$data['name'] = $profile->name;
			0 ignored issues – show Bug introduced 2020-02-26 15:26 UTC by Report Bug Copy Issue Report The property `name` does not seem to exist on `Pronamic\WordPress\Pay\Gateways\Mollie\Profile`. Loading history...
63			$format['name'] = '%s';
64
65			if ( null === $id ) {
66			$data['mollie_id'] = $profile->get_id();
67			$foramt['mollie_id'] = '%s';
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-02-26 14:12 UTC by Report Bug Copy Issue Report `$foramt` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$foramt = array();` before regardless. Loading history...
68
69			$result = $wpdb->insert(
70			$wpdb->pronamic_pay_mollie_profiles,
71			$data,
72			$format
73			);
74
75			if ( false === $result ) {
76			\WP_CLI::error(
			0 ignored issues – show Bug introduced 2020-02-26 14:12 UTC by Report Bug Copy Issue Report The type `WP_CLI` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
77			sprintf(
78			'Database error: %s.',
79			$wpdb->last_error
80			)
81			);
82			}
83
84			$id = $wpdb->insert_id;
85			} else {
86			$result = $wpdb->update(
87			$wpdb->pronamic_pay_mollie_profiles,
88			$data,
89			array(
90			'id' => $id,
91			),
92			$format,
93			array(
94			'id' => '%d',
95			)
96			);
97
98			if ( false === $result ) {
99			\WP_CLI::error(
100			sprintf(
101			'Database error: %s.',
102			$wpdb->last_error
103			)
104			);
105			}
106			}
107
108			return $id;
109			}
110			}
111

wp-pay-gateways / mollie

Push — develop ( 889b97...9fde12 )

ProfileDataStore::save_profile() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like