Upgrade300::execute() - Code Metrics - Inspection of "Added upgrade 3.0.0 script for custom tables." - wp-pay-gateways/mollie - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 4d80cd...5b7daa )

by Remco

created 2020-02-10 14:03 UTC

Upgrade300::execute() A

↳ Parent: Upgrade300

Complexity

Conditions	1
Paths	1

Size

Total Lines	81
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	20
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	81
rs	9.6

How to fix Long Method

<?php
/**
 * Upgrade 3.0.0
 *
 * @author    Pronamic <[email protected]>
 * @copyright 2005-2020 Pronamic
 * @license   GPL-3.0-or-later
 * @package   Pronamic\WordPress\Pay\Gateways\Mollie
 */

namespace Pronamic\WordPress\Pay\Gateways\Mollie;

use Pronamic\WordPress\Pay\Upgrades\Upgrade;

/**
 * Upgrade 3.0.0
 *
 * @author  Remco Tolsma
 * @version 3.0.0
 * @since   3.0.0
 */
class Upgrade300 extends Upgrade {
	/**
	 * Construct 3.0.0 upgrade.
	 */
	public function __construct() {
		parent::__construct( '3.0.0' );
	}

	/**
	 * Execute.
	 *
	 * @link https://github.com/WordPress/WordPress/blob/5.3/wp-includes/wp-db.php#L992-L1072
	 * @link https://github.com/WordPress/WordPress/blob/5.3/wp-admin/includes/schema.php#L25-L344
	 * @link https://developer.wordpress.org/reference/functions/dbdelta/
	 * @link https://github.com/wp-premium/gravityforms/blob/2.4.16/includes/class-gf-upgrade.php#L518-L531
	 */
	public function execute() {
		global $wpdb;

		/**
		 * Requirements.
		 */
		require_once ABSPATH . 'wp-admin/includes/upgrade.php';

		/**
		 * Other.
		 */
		$charset_collate = $wpdb->get_charset_collate();

		/**
		 * Queries.
		 */
		$queries = "
			CREATE TABLE $wpdb->pronamic_pay_mollie_organisations (
				id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
				mollie_id VARCHAR( 16 ) NOT NULL,

				PRIMARY KEY  ( id ),
				UNIQUE KEY mollie_id ( mollie_id )
			) $charset_collate;

			CREATE TABLE $wpdb->pronamic_pay_mollie_customers (
				id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
				mollie_id VARCHAR( 16 ) NOT NULL,
				organisation_id BIGINT( 20 ) NOT NULL,
				test_mode BOOL NOT NULL,
				email VARCHAR( 100 ) DEFAULT NULL,

				PRIMARY KEY  ( id ),
				UNIQUE KEY mollie_id ( mollie_id ),
				KEY organisation_id ( organisation_id ),
				KEY test_mode ( test_mode ),
				KEY email ( email )
			) $charset_collate;

			CREATE TABLE $wpdb->pronamic_pay_mollie_customer_users (
				id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
				customer_id BIGINT( 20 ) UNSIGNED NOT NULL,
				user_id BIGINT( 20 ) UNSIGNED NOT NULL,

				PRIMARY KEY  ( id ),
				UNIQUE KEY customer_user ( customer_id, user_id )
			) $charset_collate;
		";

		/**
		 * Execute.
		 */
		\dbDelta( $queries );

		/**
		 * Foreign keys.
		 *
		 * @link https://core.trac.wordpress.org/ticket/19207
		 */
		$wpdb->query( "
			ALTER TABLE $wpdb->pronamic_pay_mollie_customers 
			ADD FOREIGN KEY ( organisation_id )
			REFERENCES $wpdb->pronamic_pay_mollie_organisations ( id )
			ON DELETE RESTRICT
			ON UPDATE RESTRICT
			;
		" );

		$wpdb->query( "
			ALTER TABLE $wpdb->pronamic_pay_mollie_customer_users 
			ADD FOREIGN KEY ( customer_id )
			REFERENCES $wpdb->pronamic_pay_mollie_customers ( id )
			ON DELETE RESTRICT
			ON UPDATE RESTRICT
			;
		" );

		$wpdb->query( "
			ALTER TABLE $wpdb->pronamic_pay_mollie_customer_users 
			ADD FOREIGN KEY ( user_id )
			REFERENCES $wpdb->users ( id )
			ON DELETE RESTRICT
			ON UPDATE RESTRICT
			;
		" );
	}
}


1			<?php
2			/**
3			* Upgrade 3.0.0
4			*
5			* @author Pronamic <[email protected]>
6			* @copyright 2005-2020 Pronamic
7			* @license GPL-3.0-or-later
8			* @package Pronamic\WordPress\Pay\Gateways\Mollie
9			*/
10
11			namespace Pronamic\WordPress\Pay\Gateways\Mollie;
12
13			use Pronamic\WordPress\Pay\Upgrades\Upgrade;
14
15			/**
16			* Upgrade 3.0.0
17			*
18			* @author Remco Tolsma
19			* @version 3.0.0
20			* @since 3.0.0
21			*/
22			class Upgrade300 extends Upgrade {
23			/**
24			* Construct 3.0.0 upgrade.
25			*/
26			public function __construct() {
27			parent::__construct( '3.0.0' );
28			}
29
30			/**
31			* Execute.
32			*
33			* @link https://github.com/WordPress/WordPress/blob/5.3/wp-includes/wp-db.php#L992-L1072
34			* @link https://github.com/WordPress/WordPress/blob/5.3/wp-admin/includes/schema.php#L25-L344
35			* @link https://developer.wordpress.org/reference/functions/dbdelta/
36			* @link https://github.com/wp-premium/gravityforms/blob/2.4.16/includes/class-gf-upgrade.php#L518-L531
37			*/
38			public function execute() {
39			global $wpdb;
40
41			/**
42			* Requirements.
43			*/
44			require_once ABSPATH . 'wp-admin/includes/upgrade.php';
45
46			/**
47			* Other.
48			*/
49			$charset_collate = $wpdb->get_charset_collate();
50
51			/**
52			* Queries.
53			*/
54			$queries = "
55			CREATE TABLE $wpdb->pronamic_pay_mollie_organisations (
56			id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
57			mollie_id VARCHAR( 16 ) NOT NULL,
58
59			PRIMARY KEY ( id ),
60			UNIQUE KEY mollie_id ( mollie_id )
61			) $charset_collate;
62
63			CREATE TABLE $wpdb->pronamic_pay_mollie_customers (
64			id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
65			mollie_id VARCHAR( 16 ) NOT NULL,
66			organisation_id BIGINT( 20 ) NOT NULL,
67			test_mode BOOL NOT NULL,
68			email VARCHAR( 100 ) DEFAULT NULL,
69
70			PRIMARY KEY ( id ),
71			UNIQUE KEY mollie_id ( mollie_id ),
72			KEY organisation_id ( organisation_id ),
73			KEY test_mode ( test_mode ),
74			KEY email ( email )
75			) $charset_collate;
76
77			CREATE TABLE $wpdb->pronamic_pay_mollie_customer_users (
78			id BIGINT( 20 ) UNSIGNED NOT NULL AUTO_INCREMENT,
79			customer_id BIGINT( 20 ) UNSIGNED NOT NULL,
80			user_id BIGINT( 20 ) UNSIGNED NOT NULL,
81
82			PRIMARY KEY ( id ),
83			UNIQUE KEY customer_user ( customer_id, user_id )
84			) $charset_collate;
85			";
86
87			/**
88			* Execute.
89			*/
90			\dbDelta( $queries );
91
92			/**
93			* Foreign keys.
94			*
95			* @link https://core.trac.wordpress.org/ticket/19207
96			*/
97			$wpdb->query( "
98			ALTER TABLE $wpdb->pronamic_pay_mollie_customers
99			ADD FOREIGN KEY ( organisation_id )
100			REFERENCES $wpdb->pronamic_pay_mollie_organisations ( id )
101			ON DELETE RESTRICT
102			ON UPDATE RESTRICT
103			;
104			" );
105
106			$wpdb->query( "
107			ALTER TABLE $wpdb->pronamic_pay_mollie_customer_users
108			ADD FOREIGN KEY ( customer_id )
109			REFERENCES $wpdb->pronamic_pay_mollie_customers ( id )
110			ON DELETE RESTRICT
111			ON UPDATE RESTRICT
112			;
113			" );
114
115			$wpdb->query( "
116			ALTER TABLE $wpdb->pronamic_pay_mollie_customer_users
117			ADD FOREIGN KEY ( user_id )
118			REFERENCES $wpdb->users ( id )
119			ON DELETE RESTRICT
120			ON UPDATE RESTRICT
121			;
122			" );
123			}
124			}
125

wp-pay-gateways / mollie

Push — develop ( 4d80cd...5b7daa )

Upgrade300::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like